Re: [trojita] Merge threading & sorting options

[Jan Kundrát]

On Thursday, 12 September 2013 15:57:37 CEST, Pali Rohár wrote:
-            allIds.append(node.internalId);
+            allIds.append(offset+1);

You're mixing ThreadNodeInfo::internalId which is an opaque internal 
identifier with some consecutive counter -- that won't work.

@@ -498,6 +498,8 @@ void ThreadingMsgListModel::updateNoThreading()
     }
     updatePersistentIndexesPhase2();
     emit layoutChanged();
+
+    searchSortPreferenceImplementation(m_currentSearchConditions, 
m_currentSortingCriteria, m_sortReverse ? 
Qt::DescendingOrder : Qt::AscendingOrder);
 }
 
 void ThreadingMsgListModel::wantThreading(const SkipSortSearch 
skipSortSearch)

This second patch is now in my pali-gsoc branch.

This looks suspicious and as a possible recursion on a quick glance (I 
could be wrong).

Cheers,
Jan

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/