On Thursday, 12 September 2013 15:52:38 CEST, Pali Rohár wrote:
First I changed all find_package with trojita_find_package which
handle also feature summary cmake module and second there is for
example qt dbus and qt test libraries which are not required
always (only if dbus and test options are set to AUTO or ON).
I understand what you did and why you made it so. Despite that, I want to
unify the Qt5 setup with how it's done by other projects, and that means
that the cmake setup shall look like this:
find_package(Qt5Core REQUIRED)
qt5_use_modules(DesktopGui Widgets)
qt5_use_modules(Imap Network)
etc.
Regarding the automagic dependencies -- I think it's OK to use your
wrappers for discovering whether DBUS is here. But even in that case and
when you detect that it is here, please use the qt5_use_modules calls for
actual build configuration for all Qt modules including qtdbus and qttest.
With kind regards,
Jan
--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
