On Wednesday 31 July 2013 00:01:29 Thomas Lübking wrote:
> On Dienstag, 30. Juli 2013 23:23:13 CEST, Kevin Krammer wrote:
> >> +void KDEAddressbookProcess::slotApplicationLoaded()
> >> this is superfluous, you can bind the finished signal to
> >
> > Might even connect the signal to deleteLater dir
On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote:
> On Tuesday, 2013-07-30, Thomas Lübking wrote:
> > +void AkonadiAddressbookCompletionJob::result()
> > +{
> > +NameEmailList completion;
> > +
> > +const KABC::Addressee::List &list = job->contacts();
> > Since KABC is claimed deprecate
On Thursday, 2013-08-08, Pali Rohár wrote:
> On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote:
> > On Tuesday, 2013-07-30, Thomas Lübking wrote:
> > > +const KABC::Addressee::List &list = job->contacts();
> > > Since KABC is claimed deprecated, is there no replacement
> > > API?
> >
> > K
On Tuesday 30 July 2013 22:58:42 Thomas Lübking wrote:
> Set #2 of comments:
>
> +QAction *actionComposeMail = m_window->findChild *>(QLatin1String("action_compose_mail")); +QAction
> *actionComposeDraft = m_window->findChild *>(QLatin1String("action_compose_draft")); ...
> +QAction *a
On Thursday 08 August 2013 09:38:16 Kevin Krammer wrote:
> On Thursday, 2013-08-08, Pali Rohár wrote:
> > On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote:
> > > On Tuesday, 2013-07-30, Thomas Lübking wrote:
> > > > @Kevin
> > > > How are chances about having query restrictions in
> > > > akona
On Wednesday 07 August 2013 15:07:39 Jan Kundrát wrote:
> On Wednesday, 17 July 2013 21:42:04 CEST, Pali Rohár wrote:
> > My current code have common "interface" classes for password
> > and addressbook plugins. Because trojita working only with
> > pointers of these common objects, code of interfa
On Thursday, 2013-08-08, Pali Rohár wrote:
> On Thursday 08 August 2013 09:38:16 Kevin Krammer wrote:
> > On Thursday, 2013-08-08, Pali Rohár wrote:
> > > KResourceAddressbook sounds good. Current name is
> > > "KDE Addressbook (traditional)". Do you want to change it?
> >
> > I would use "Legacy
On Thursday, 8 August 2013 09:49:37 CEST, Pali Rohár wrote:
KDE XML menu file contains above object names. So if somebody
change them, it will break Kontact plugin (Kontact will not show
any Trojita menus/buttons). So here can be good test if trojita
code will still OK.
What other think? Use
On Thursday 08 August 2013 10:10:54 Jan Kundrát wrote:
> On Thursday, 8 August 2013 09:49:37 CEST, Pali Rohár wrote:
> > KDE XML menu file contains above object names. So if
> > somebody change them, it will break Kontact plugin (Kontact
> > will not show any Trojita menus/buttons). So here can be
On Thursday, 8 August 2013 10:15:53 CEST, Pali Rohár wrote:
KMail is written as KDE KPart application.
I know nothing about KParts, so let me rephrase my suggestion -- if there's
something in KMail which is setting up the menus etc. *and* if this is
applicable to Trojita, I'd suggest to go th
On Thursday 08 August 2013 10:26:49 Jan Kundrát wrote:
> On Thursday, 8 August 2013 10:15:53 CEST, Pali Rohár wrote:
> > KMail is written as KDE KPart application.
>
> I know nothing about KParts, so let me rephrase my suggestion
> -- if there's something in KMail which is setting up the
> menus e
On Thursday, 8 August 2013 10:44:44 CEST, Pali Rohár wrote:
In XML file are defined menubars and toolbars with all K/QActions.
It matching objectName(). In your cpp code you need to push all
KActions objects to some list (KActionCollection).
My Kontact plugin will got pointers to QAction objec
On Tuesday 06 August 2013 15:29:55 Jan Kundrát wrote:
> Hi Pali,
> there's some chat about students blogging about what they are
> doing, any obstacles they hit, new stuff they learn etc.
> These blogs also make it clear that the project they're
> involved in is lively, etc.
>
> How do you think a
On Thursday, 2013-08-08, Jan Kundrát wrote:
> On Thursday, 8 August 2013 10:44:44 CEST, Pali Rohár wrote:
> > In XML file are defined menubars and toolbars with all K/QActions.
> > It matching objectName(). In your cpp code you need to push all
> > KActions objects to some list (KActionCollection).
On Thursday, 2013-08-08, Pali Rohár wrote:
> On Tuesday 06 August 2013 15:29:55 Jan Kundrát wrote:
> > Hi Pali,
> > there's some chat about students blogging about what they are
> > doing, any obstacles they hit, new stuff they learn etc.
> > These blogs also make it clear that the project they're
On Donnerstag, 8. August 2013 11:24:35 CEST, Kevin Krammer wrote:
I think what Thomas was suggesting was to make the action objects directly
accessible instead of making Qt traverse the QObject tree to find them.
Exactly.
Whether unilateral changes in the XML menu file breaks things doesn't mat
On Monday 29 July 2013 19:35:22 Thomas Lübking wrote:
> +
> +AddressbookJob *job = m_completionRequests.take(toEdit);
> +
> +if (job) {
> +disconnect(job, 0, 0, 0);
> +job->stop();
> +job->deleteLater();
> +}
>
> The completion race (you type faster than the bac
On Monday 05 August 2013 22:29:20 Jan Kundrát wrote:
>
> >> you mean to disconnect(job, 0, this, 0)?
> >
> > I think this is to protect against stop() emitting any
> > signals. Probably easier to call job->disconnect();
> > Or avoiding sigals in stop().
>
> I was thinking about another valid use
On Donnerstag, 8. August 2013 15:52:56 CEST, Pali Rohár wrote:
For emails with lot of recipients this could lead to application
crash... For each email address trojita is starting job.
You mean for OOM due to job overhead?
You could still keep up to 32 jobs in parallel or so.
(Everytime one re
On Thursday 08 August 2013 19:32:13 Thomas Lübking wrote:
> On Donnerstag, 8. August 2013 15:52:56 CEST, Pali Rohár wrote:
> > For emails with lot of recipients this could lead to
> > application crash... For each email address trojita is
> > starting job.
>
> You mean for OOM due to job overhead?
On Donnerstag, 8. August 2013 19:57:56 CEST, Pali Rohár wrote:
Reason why I used QTimer::singleShot was that it is offent used in
trojita code. Just run wc -l:
Yes, it's a very popular abuse, doesn't change it's an abuse.
(Though FWWI: The coarse timer operates on 5% base, since 5% of 0 is 0
21 matches
Mail list logo
