Re: [Spice-devel] [spice-gtk Win32 v5 22/22] usb-device-manager: mingw: ignore "remove" udev event when un/installing a driver

2012-07-09 Thread Marc-André Lureau
On Mon, Jul 9, 2012 at 2:15 PM, Uri Lublin wrote: > --- > gtk/usb-device-manager.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c > index 65119ad..2a92ff8 100644 > --- a/gtk/usb-device-manager.c > +++ b/g

Re: [Spice-devel] [spice-gtk Win32 v5 21/22] usb-device-manager: mingw: keep driver install/uninstall state of a device

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:15 PM, Uri Lublin wrote: > Currently only driver install/unsinstall is of interest, such that > extra udev events can be ignored. > --- > gtk/usb-device-manager.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/gtk/usb-device-manager.

Re: [Spice-devel] [spice-gtk Win32 v5 20/22] usb-device-manager: add 'state' field to SpiceUsbDeviceInfo

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:15 PM, Uri Lublin wrote: > To be used on Win32 to ignore extra udev events > received during driver install/uninstall. > --- > gtk/usb-device-manager.c | 37 + > 1 files changed, 37 insertions(+), 0 deletions(-) > > diff --git a/

Re: [Spice-devel] [spice-gtk Win32 v5 18/22] Win32/mingw: usb-device-manager: uninstall win usb driver upon device disconnect

2012-07-09 Thread Marc-André Lureau
ack -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-gtk Win32 v5 16/22] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-07-09 Thread Marc-André Lureau
- Mensaje original - > spice_usb_device_manager_drv_install_cb() frees the installer. ah right ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-gtk Win32 v5 16/22] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-07-09 Thread Uri Lublin
On 07/09/2012 07:47 PM, Marc-André Lureau wrote: Hi On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: +void spice_usb_device_manager_connect_device_async(SpiceUsbDeviceManager *self, + SpiceUsbDevice *device, +

Re: [Spice-devel] [spice-gtk Win32 v5 17/22] win-usb-driver-install: add capability to remove (uninstall) a win usb driver

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:15 PM, Uri Lublin wrote: > --- > gtk/win-usb-driver-install.c | 67 + > gtk/win-usb-driver-install.h |6 > 2 files changed, 53 insertions(+), 20 deletions(-) > > diff --git a/gtk/win-usb-driver-install.c b/gtk/win-us

Re: [Spice-devel] [spice-gtk Win32 v5 16/22] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-07-09 Thread Marc-André Lureau
Hi On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > +void spice_usb_device_manager_connect_device_async(SpiceUsbDeviceManager > *self, > + SpiceUsbDevice *device, > + GCancellable *cancellable, > +

Re: [Spice-devel] its posible to install spice client on HP t5556z

2012-07-09 Thread David Jaša
Hi, enzo píše v Po 09. 07. 2012 v 18:28 +0200: > ok > > its > HP t5556z model. The only result from google was this email thread. I can't help you anymore without some link or more details (OS at least). > > we going to do over RDP cos was imposible for us to configure spice on > firefox (

Re: [Spice-devel] Usb-redirect

2012-07-09 Thread David Jaša
Hi Salavat, Шарапов Салават píše v Út 03. 07. 2012 v 08:35 +0400: > Hello! Project Wonderful! > Using SPICE for six months. > Satisfied. > It took a traverse USB-device on the virtual machine, read the How to .. > seems to be understood. Does not work. > Brought together with the package SPICE us

Re: [Spice-devel] its posible to install spice client on HP t5556z

2012-07-09 Thread David Jaša
Hi Enzo, Could you specify more precisely what device it is? HP won't help you? David enzo píše v Čt 05. 07. 2012 v 15:34 +0200: > helo: > > you know if its posible to install spice client on HP t5556z.??? > > > rhev 3 infraestructure > > thanks.enzo > > -- > > ___

Re: [Spice-devel] [spice-gtk Win32 v5 15/22] Windows mingw: usb: implement GUdevDevice & GUdevClient for windows

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > From: Arnon Gilboa > > - Added win-usb-dev.[ch] > - Added GUdevDevice and GUdevClient like classes > - Added uevent signal based on WM_DEVICECHANGE > --- > gtk/Makefile.am | 13 ++ > gtk/usb-device-manager.c |8 + > gtk/win-

Re: [Spice-devel] [spice-gtk Win32 v5 13/22] Introduce SpiceUsbDeviceInfo to be kept instead of a libusb_device

2012-07-09 Thread Marc-André Lureau
- Mensaje original - > On 07/09/2012 05:50 PM, Marc-André Lureau wrote: > > I am missing why it has to be named "SpiceUsbDeviceInfo" and not > > simply "SpiceUsbDevice". Any idea? > > The type SpiceUsbDevice already exists. But it doesn't conflict, it's the boxed front type, you can hav

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 08:47:34AM -0500, Jeremy White wrote: > > abort happens only on critical by default, not on error, so this is > > strange - unless you've set SPICE_ABORT_LEVEL_DEFAULT to something else. > > See http://cgit.freedesktop.org/spice/spice-common/tree/common/log.c#n84 > > Um, I

Re: [Spice-devel] [spice-gtk Win32 v5 14/22] Make SpiceUsbDevice a box for SpiceUsbDeviceInfo, instead of a box for libusb_device

2012-07-09 Thread Marc-André Lureau
misc comments, ack otherwise On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > Note that this change may affect performance a bit, as sometimes there is > a need to find the libusb_device or the SpiceUsbDevice. Likely it's > negligible. > --- > gtk/usb-device-manager-priv.h |7 ++- > gtk/

Re: [Spice-devel] [PATCH] update rdf versions - plugin, firefox

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 03:25:54PM +0200, Peter Hatina wrote: > Hi, > > I am rising spice-xpi version and also supported Raising. Ack. I sure hope there is a saner way then chasing the ever increasing version numbers.. > versions of firefox. > > Peter Hatina > EMEA ENG-Desktop Development > Re

Re: [Spice-devel] [spice-gtk Win32 v5 13/22] Introduce SpiceUsbDeviceInfo to be kept instead of a libusb_device

2012-07-09 Thread Uri Lublin
On 07/09/2012 05:50 PM, Marc-André Lureau wrote: I am missing why it has to be named "SpiceUsbDeviceInfo" and not simply "SpiceUsbDevice". Any idea? The type SpiceUsbDevice already exists. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.o

Re: [Spice-devel] [spice-gtk Win32 v5 13/22] Introduce SpiceUsbDeviceInfo to be kept instead of a libusb_device

2012-07-09 Thread Marc-André Lureau
I am missing why it has to be named "SpiceUsbDeviceInfo" and not simply "SpiceUsbDevice". Any idea? (misc style, extra parenthesis unneeded) On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > For Windows, it's better not to keep references for libusb_devices > that are not used. > So instead of

Re: [Spice-devel] [spice-gtk Win32 v5 12/22] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > For windows GUDEV is not required > For Linux GUDEV is checked as a part of USBREDIR block, but > as a separate check. > --- > configure.ac| 15 ++- > gtk/Makefile.am |2 ++ > 2 files changed, 16 insertions(+), 1 delet

Re: [Spice-devel] [spice-gtk Win32 v5 11/22] usb-device-manager: mingw: add_dev: ignore already known devices

2012-07-09 Thread Marc-André Lureau
On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > +g_warning("USB device at %d.%d already exists", bus, address); If it's an expected and repeatable event that is normal to ignore, please turn this into SPICE_DEBUG. ack anyway regards -- Marc-André Lureau ___

Re: [Spice-devel] [spice-gtk Win32 v5 10/22] usb-device-manager: add a helper function to find a usb device

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > And use it in spice_usb_device_manager_remove_dev > --- > gtk/usb-device-manager.c | 32 +--- > 1 files changed, 21 insertions(+), 11 deletions(-) > > diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-mana

Re: [Spice-devel] [spice-gtk Win32 v5 09/22] spice_usb_device_get_description: use device-descriptor only to get

2012-07-09 Thread Marc-André Lureau
ack, (misc style below) On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > In preparation for a different SpiceUsbDevice. > > With the new SpiceUsbDeviceInfo, will be provided by > SpiceUsbDevice, and not by the device_descriptor (from libusb) > --- > gtk/usb-device-manager.c | 17 ++

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Alon Levy
On Sat, Jul 07, 2012 at 03:26:22PM -0500, Jeremy White wrote: > On 07/06/2012 01:47 PM, Jeremy White wrote: > > On 07/05/2012 04:38 AM, Alon Levy wrote: > >> Replaced mostly with spice_debug, but spice_warning & spice_error as > >> well where appropriate. > > > > Boy, I do like this patch, but odd

Re: [Spice-devel] [spice-gtk Win32 v5 08/22] spice_usb_device_manager_device_error: replace SpiceUsbDevice with libusb_device

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > Its only user is channel-usbredir, which needs the libusb_device. > > In preparations for a different SpiceUsbDevice. > --- > gtk/channel-usbredir.c|2 +- > gtk/usb-device-manager-priv.h |5 - > gtk/usb-device-manager.c

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Jeremy White
> abort happens only on critical by default, not on error, so this is > strange - unless you've set SPICE_ABORT_LEVEL_DEFAULT to something else. > See http://cgit.freedesktop.org/spice/spice-common/tree/common/log.c#n84 Um, I think: http://cgit.freedesktop.org/spice/spice-common/tree/common/log.

[Spice-devel] [PATCH] update rdf versions - plugin, firefox

2012-07-09 Thread Peter Hatina
Hi, I am rising spice-xpi version and also supported versions of firefox. Peter Hatina EMEA ENG-Desktop Development Red Hat Czech, Brno --- SpiceXPI/src/install.rdf |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SpiceXPI/src/install.rdf b/SpiceXPI/src/install.rdf ind

Re: [Spice-devel] spicy usbredir with USB mass storage device spend 30~60 seconds

2012-07-09 Thread Hans de Goede
Hi, On 07/08/2012 06:12 AM, Lv Basen wrote: HI all: I have setup a box running spicy with usb redirection, when pulg-in a usb mass storage device( 200GB ) in the box, It shoud spend 60 seconds, then we can found the usb device in virtual machine os. I enabled the debug l

Re: [Spice-devel] [spice-gtk Win32 v5 05/22] spice_usb_device_manager_add_dev: check auto_ok before freeing libusb device list

2012-07-09 Thread Uri Lublin
On 07/09/2012 03:54 PM, Marc-André Lureau wrote: It would have been more sensible to move libusb_free_device_list() to the end of the function, perhaps (goto cleanup or something). Although very unlikely, that may cause a race between freeing the list and opening the specific device after drive

Re: [Spice-devel] [Spice-commits] ...

2012-07-09 Thread Peter Hatina
Hi, On 07/02/2012 12:10 PM, Christophe Fergeau wrote: > Hey Peter, > > Just a few notes after quickly testing this: > - spice_xpi_generator is a bit unusual, command names generally use '-' > instead of '_' > - spice_xpi_generator --help tells me an arg is required (?) Both will be fixed. > -

Re: [Spice-devel] [spice-gtk Win32 v5 07/22] spice_usb_device_manager_auto_connect_cb: use type SpiceUsbDevice for "device"

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > Currently SpiceUsbDevice is a BOX for libusb_device. > In preparation for a different SpiceUsbDevice. > --- > gtk/usb-device-manager.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gtk/usb-device-manager

Re: [Spice-devel] [spice-gtk Win32 v5 06/22] spice_usb_device_manager_add_dev: use type SpiceUsbDevice for "device"

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > Currently SpiceUsbDevice is a BOX for libusb_device. > In preparation for a different SpiceUsbDevice. > > Renamed the libusb_device variable to libdev. Needed when > asking usbredir to check the filter. > --- > gtk/usb-device-manager.c |

Re: [Spice-devel] [spice-gtk Win32 v5 05/22] spice_usb_device_manager_add_dev: check auto_ok before freeing libusb device list

2012-07-09 Thread Marc-André Lureau
It would have been more sensible to move libusb_free_device_list() to the end of the function, perhaps (goto cleanup or something). ack anyway On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > In preparation for a different SpiceUsbDevice. > --- > gtk/usb-device-manager.c | 15 +

Re: [Spice-devel] [spice-gtk Win32 v5 04/22] spice_usb_device_manager_remove_dev: use type SpiceUsbDevice for "device"

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > Currently SpiceUsbDevice is a BOX for libusb_device. > In preparation for a different SpiceUsbDevice. > --- > gtk/usb-device-manager.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gtk/usb-device-manag

Re: [Spice-devel] [spice-gtk Win32 v5 03/22] controller/test.c: mingw: fix compiler bad param warning for ReadFile

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > It seems that ssize_t is int, while DWORD is long > > Compiler warning (some whitespaces where added for readability): > ../../../gtk/controller/test.c: In function 'read_from_pipe': > ../../../gtk/controller/test.c:108:5: warning: passi

Re: [Spice-devel] [spice-gtk Win32 v5 02/22] usb-device-manager: warn if a device to remove was not found

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > Also changed a bit the warning text on device-add to differentiate the two. > --- > gtk/usb-device-manager.c |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-mana

Re: [Spice-devel] [spice-gtk Win32 v5 01/22] spicy: more informative presentation of usb devices in menu

2012-07-09 Thread Marc-André Lureau
ack On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin wrote: > Using the default format. > --- > gtk/spicy.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gtk/spicy.c b/gtk/spicy.c > index 98a44d5..5ffe3b7 100644 > --- a/gtk/spicy.c > +++ b/gtk/spicy.c > @@ -460,7 +460,

Re: [Spice-devel] Audio recording device - Win 7 guest

2012-07-09 Thread Nick Causton
Hi Gerd, What is the current situation with accessing a Microphone in a VM from a Spice client? Is this likely to work any time soon within a Win 7 VM under KVM or are there still libvirt & kvm changes to be made before this works. Thanks, Nick -Original Message- From: Gerd Hoffmann

Re: [Spice-devel] Audio recording device - Win 7 guest

2012-07-09 Thread Marc-André Lureau
- Mensaje original - > On 07/09/12 14:09, Nick Causton wrote: > > Hi Gerd, > > > > What is the current situation with accessing a Microphone in a VM > > from a Spice client? Is this likely to work any time soon within a > > Win 7 VM under KVM or are there still libvirt & kvm changes to be

Re: [Spice-devel] Audio recording device - Win 7 guest

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 14:09, Nick Causton wrote: > Hi Gerd, > > What is the current situation with accessing a Microphone in a VM > from a Spice client? Is this likely to work any time soon within a > Win 7 VM under KVM or are there still libvirt & kvm changes to be > made before this works. All changes a

[Spice-devel] [spice-gtk Win32 v5 22/22] usb-device-manager: mingw: ignore "remove" udev event when un/installing a driver

2012-07-09 Thread Uri Lublin
--- gtk/usb-device-manager.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 65119ad..2a92ff8 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-manager.c @@ -719,6 +719,16 @@ static void spice_us

[Spice-devel] [spice-gtk Win32 v5 21/22] usb-device-manager: mingw: keep driver install/uninstall state of a device

2012-07-09 Thread Uri Lublin
Currently only driver install/unsinstall is of interest, such that extra udev events can be ignored. --- gtk/usb-device-manager.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 306b22b..65119ad 100644 --- a/gtk/

[Spice-devel] [spice-gtk Win32 v5 20/22] usb-device-manager: add 'state' field to SpiceUsbDeviceInfo

2012-07-09 Thread Uri Lublin
To be used on Win32 to ignore extra udev events received during driver install/uninstall. --- gtk/usb-device-manager.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 7733682..30

[Spice-devel] [spice-gtk Win32 v5 19/22] Win32/mingw: win-usb-dev: skip hubs

2012-07-09 Thread Uri Lublin
also skip devices with bad (0) device-address. --- gtk/win-usb-dev.c | 26 -- 1 files changed, 24 insertions(+), 2 deletions(-) diff --git a/gtk/win-usb-dev.c b/gtk/win-usb-dev.c index bc21e08..c188807 100644 --- a/gtk/win-usb-dev.c +++ b/gtk/win-usb-dev.c @@ -94,6 +94,8

[Spice-devel] [spice-gtk Win32 v5 18/22] Win32/mingw: usb-device-manager: uninstall win usb driver upon device disconnect

2012-07-09 Thread Uri Lublin
--- gtk/usb-device-manager.c | 42 +- 1 files changed, 37 insertions(+), 5 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 3a6caf7..7733682 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-manager.c @@ -746,6

[Spice-devel] [spice-gtk Win32 v5 17/22] win-usb-driver-install: add capability to remove (uninstall) a win usb driver

2012-07-09 Thread Uri Lublin
--- gtk/win-usb-driver-install.c | 67 + gtk/win-usb-driver-install.h |6 2 files changed, 53 insertions(+), 20 deletions(-) diff --git a/gtk/win-usb-driver-install.c b/gtk/win-usb-driver-install.c index 5b9db62..8b326b5 100644 --- a/gtk/win-usb-

[Spice-devel] [spice-gtk Win32 v5 16/22] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-07-09 Thread Uri Lublin
- Added win-usb-driver-install.[ch] - Added win-usb-clerk.h Operation (on Windows, spice-gtk point of view): - After some sanity checks, just before redir'ing a USB device a libusb driver needs to be installed (before libusb can open the device) - A connection (NamedPipe) is established with usb

[Spice-devel] [spice-gtk Win32 v5 15/22] Windows mingw: usb: implement GUdevDevice & GUdevClient for windows

2012-07-09 Thread Uri Lublin
From: Arnon Gilboa - Added win-usb-dev.[ch] - Added GUdevDevice and GUdevClient like classes - Added uevent signal based on WM_DEVICECHANGE --- gtk/Makefile.am | 13 ++ gtk/usb-device-manager.c |8 + gtk/win-usb-dev.c| 510 ++ g

[Spice-devel] [spice-gtk Win32 v5 14/22] Make SpiceUsbDevice a box for SpiceUsbDeviceInfo, instead of a box for libusb_device

2012-07-09 Thread Uri Lublin
Note that this change may affect performance a bit, as sometimes there is a need to find the libusb_device or the SpiceUsbDevice. Likely it's negligible. --- gtk/usb-device-manager-priv.h |7 ++- gtk/usb-device-manager.c | 137 ++--- 2 files changed, 1

[Spice-devel] [spice-gtk Win32 v5 13/22] Introduce SpiceUsbDeviceInfo to be kept instead of a libusb_device

2012-07-09 Thread Uri Lublin
For Windows, it's better not to keep references for libusb_devices that are not used. So instead of makeing SpiceUsbDevice a box for a libusb_device it is going to be a box for a SpiceUsbDeviceInfo. --- gtk/usb-device-manager.c | 131 ++ 1 files changed

[Spice-devel] [spice-gtk Win32 v5 12/22] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-07-09 Thread Uri Lublin
For windows GUDEV is not required For Linux GUDEV is checked as a part of USBREDIR block, but as a separate check. --- configure.ac| 15 ++- gtk/Makefile.am |2 ++ 2 files changed, 16 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 3841c56..233ce

[Spice-devel] [spice-gtk Win32 v5 11/22] usb-device-manager: mingw: add_dev: ignore already known devices

2012-07-09 Thread Uri Lublin
Sometimes on a Windows client, udev events are received while the driver is being un/installed. so just ignore it --- gtk/usb-device-manager.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index ffddb3b..f77d09a

[Spice-devel] [spice-gtk Win32 v5 10/22] usb-device-manager: add a helper function to find a usb device

2012-07-09 Thread Uri Lublin
And use it in spice_usb_device_manager_remove_dev --- gtk/usb-device-manager.c | 32 +--- 1 files changed, 21 insertions(+), 11 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 04c3169..ffddb3b 100644 --- a/gtk/usb-device-manager.c

[Spice-devel] [spice-gtk Win32 v5 09/22] spice_usb_device_get_description: use device-descriptor only to get

2012-07-09 Thread Uri Lublin
In preparation for a different SpiceUsbDevice. With the new SpiceUsbDeviceInfo, will be provided by SpiceUsbDevice, and not by the device_descriptor (from libusb) --- gtk/usb-device-manager.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/gtk/usb-device

[Spice-devel] [spice-gtk Win32 v5 08/22] spice_usb_device_manager_device_error: replace SpiceUsbDevice with libusb_device

2012-07-09 Thread Uri Lublin
Its only user is channel-usbredir, which needs the libusb_device. In preparations for a different SpiceUsbDevice. --- gtk/channel-usbredir.c|2 +- gtk/usb-device-manager-priv.h |5 - gtk/usb-device-manager.c |3 ++- 3 files changed, 7 insertions(+), 3 deletions(-) di

[Spice-devel] [spice-gtk Win32 v5 07/22] spice_usb_device_manager_auto_connect_cb: use type SpiceUsbDevice for "device"

2012-07-09 Thread Uri Lublin
Currently SpiceUsbDevice is a BOX for libusb_device. In preparation for a different SpiceUsbDevice. --- gtk/usb-device-manager.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index d4ad1f9..dbf3493 100644 --- a/gtk

[Spice-devel] [spice-gtk Win32 v5 06/22] spice_usb_device_manager_add_dev: use type SpiceUsbDevice for "device"

2012-07-09 Thread Uri Lublin
Currently SpiceUsbDevice is a BOX for libusb_device. In preparation for a different SpiceUsbDevice. Renamed the libusb_device variable to libdev. Needed when asking usbredir to check the filter. --- gtk/usb-device-manager.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-

[Spice-devel] [spice-gtk Win32 v5 05/22] spice_usb_device_manager_add_dev: check auto_ok before freeing libusb device list

2012-07-09 Thread Uri Lublin
In preparation for a different SpiceUsbDevice. --- gtk/usb-device-manager.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index c50a7da..a81db57 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-m

[Spice-devel] [spice-gtk Win32 v5 04/22] spice_usb_device_manager_remove_dev: use type SpiceUsbDevice for "device"

2012-07-09 Thread Uri Lublin
Currently SpiceUsbDevice is a BOX for libusb_device. In preparation for a different SpiceUsbDevice. --- gtk/usb-device-manager.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 8b277cc..c50a7da 100644 --- a/g

[Spice-devel] [spice-gtk Win32 v5 03/22] controller/test.c: mingw: fix compiler bad param warning for ReadFile

2012-07-09 Thread Uri Lublin
It seems that ssize_t is int, while DWORD is long Compiler warning (some whitespaces where added for readability): ../../../gtk/controller/test.c: In function 'read_from_pipe': ../../../gtk/controller/test.c:108:5: warning: passing argument 4 \ of 'ReadFile' from incompatible pointer ty

[Spice-devel] [spice-gtk Win32 v5 02/22] usb-device-manager: warn if a device to remove was not found

2012-07-09 Thread Uri Lublin
Also changed a bit the warning text on device-add to differentiate the two. --- gtk/usb-device-manager.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index b39c2d4..8b277cc 100644 --- a/gtk/usb-device-manager.c

[Spice-devel] [spice-gtk Win32 v5 00/22] usbredir support for Windows (mingw)

2012-07-09 Thread Uri Lublin
New in V5: - More and smaller patches - cancellable is passed to iostream (for install/uninstall) ==> driver install/uninstall does not register for cancelled event. - continue with usbredir even if driver install failed ==> usbredir would fail libusb_open ==> better cleanup, and

[Spice-devel] [spice-gtk Win32 v5 01/22] spicy: more informative presentation of usb devices in menu

2012-07-09 Thread Uri Lublin
Using the default format. --- gtk/spicy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 98a44d5..5ffe3b7 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -460,7 +460,7 @@ static void menu_cb_select_usb_devices(GtkAction *action, void *data)

Re: [Spice-devel] [Users] The problem with "spicevmc not supported in this QEMU binary"

2012-07-09 Thread xuejie chen
2012/7/6 Alon Levy : > On Fri, Jul 06, 2012 at 03:55:30PM +0300, Itamar Heim wrote: >> On 07/06/2012 06:46 AM, xuejie chen wrote: >> >Hi everyone, >> > >> >I installed the vdsm(4.9.6) in CentOS 6 and the libvirt version is 0.9.4. >> >I create a VM with all default values, >> >But, when I run the vm

Re: [Spice-devel] [Users] The problem with "spicevmc not supported in this QEMU binary"

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 10:25:13AM +0800, xuejie chen wrote: > 2012/7/6 Alon Levy : > > On Fri, Jul 06, 2012 at 03:55:30PM +0300, Itamar Heim wrote: > >> On 07/06/2012 06:46 AM, xuejie chen wrote: > >> >Hi everyone, > >> > > >> >I installed the vdsm(4.9.6) in CentOS 6 and the libvirt version is 0.9