Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-30 Thread Craig R Hughes
Ok, I've made this change and checked in the new Conf.pm C Tobias von Koch wrote: TvK> After thinking a bit about DCC's auto-reporting and discussing this with TvK> Richie Laager (thank you!) I'd now recommend to change the following TvK> line in Conf.pm: TvK>$self->{dcc_options} = '-QR'; T

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-30 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 30 Apr 2002, Michael Moncur stated: >> Seems to work fine for me. I've switched the require IPC::Open2 to >> use IPC::Open2 but moved it to the top of the file. Also removed the >> = {} from the hash declaration. All seems to work OK on my

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-30 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 29 Apr 2002, Kelsey Cummings stated: >> > Okay I did: >> > use IPC::Open2; instead of require IPC::Open2; and changed line >> > 270 back to what you had it, that gets rid of the Use of >> > uninitialized value line but not the wtr error

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-30 Thread Tobias von Koch
Hi, On Tue, 30 Apr 2002 04:32:23 -0600, Michael Moncur wrote: MM> > Seems to work fine for me. I've switched the require IPC::Open2 MM> > to use IPC::Open2 but moved it to the top of the file. Also MM> > removed the= {} from the MM> > hash declaration. All seems to work OK on my linux machine.

RE: [SAtalk] [PATCH] DCC Support for SA

2002-04-30 Thread Michael Moncur
> Seems to work fine for me. I've switched the require IPC::Open2 to use > IPC::Open2 but moved it to the top of the file. Also removed the > = {} from the > hash declaration. All seems to work OK on my linux machine. I installed DCC and tried this earlier and got the same errors, but after th

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-30 Thread Craig R Hughes
Rob McMillin wrote: RM> open2? Has anyone tested this with spamd? The reason I ask is that I RM> recently wrote a networking daemon in Perl that used open3() while doing RM> the canonical close() on STDOUT, STDIN, and STDERR. I couldn't get it to RM> work until I redirected those file handles to

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-30 Thread Rob McMillin
Kelsey Cummings wrote: >On Tue, Apr 30, 2002 at 01:42:26AM +0100, Sean Rima wrote: > >>-BEGIN PGP SIGNED MESSAGE- >>Hash: SHA1 >> >>On Tue, 30 Apr 2002, Sean Rima said: >> >> >SR> Use of uninitialized value at >SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line >

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Kelsey Cummings
On Tue, Apr 30, 2002 at 01:42:26AM +0100, Sean Rima wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Tue, 30 Apr 2002, Sean Rima said: > > > >>> SR> Use of uninitialized value at > >>> SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line > >>> SR> 270. DCC check skipp

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 29 Apr 2002, Craig R. Hughes yowled: > I switched that use to a require following someone else's advice > (forget whose) w/out thinking about what I was doing. Probably can > instead just move that use to the top of the module, outside the >

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 30 Apr 2002, Sean Rima said: >>> SR> Use of uninitialized value at >>> SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line >>> SR> 270. DCC check skipped: Undefined subroutine >>> SR> &Mail::SpamAssassin::PerMsgStatus::open2 cal

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Craig R Hughes
I switched that use to a require following someone else's advice (forget whose) w/out thinking about what I was doing. Probably can instead just move that use to the top of the module, outside the function where it presumably won't be executed over and over again. As for what the wtr thing is, I

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 30 Apr 2002, Sean Rima spake: >> SR> Use of uninitialized value at >> SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line >> SR> 270. DCC check skipped: Undefined subroutine >> SR> &Mail::SpamAssassin::PerMsgStatus::open2 called

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 29 Apr 2002, Craig R. Hughes moaned: > Sean Rima wrote: > > SR> Reference found where even-sized list expected at > SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line 250. > > Weird -- that line looks just fine to me -- it's m

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Craig R Hughes
Sean Rima wrote: SR> Reference found where even-sized list expected at SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line 250. Weird -- that line looks just fine to me -- it's making a has be initialized with an empty hash. Looks like an even-sized list to me. I'll try installin

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 29 Apr 2002, Craig R. Hughes spake: > Ooops, looks like a perl 5.6ism -- Anyone who knows enough about 5.0x > want to fix this? Seems to me like opening to a variable is entirely > reasonable thing to attempt... Looking at other bits of cod

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Craig R Hughes
ED]> SR> To: [EMAIL PROTECTED] SR> Subject: Re: [SAtalk] [PATCH] DCC Support for SA SR> SR> -BEGIN PGP SIGNED MESSAGE- SR> Hash: SHA1 SR> SR> On Mon, 29 Apr 2002, Craig R. Hughes spake thusly: SR> SR> > I put it in CVS last night. Thanks a lot for the work on

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 29 Apr 2002, Craig R. Hughes spake thusly: > I put it in CVS last night. Thanks a lot for the work on this Tobias. > I haven't installed DCC on my own machine yet, nor written a dcc.t, > but will do that probably this afternoon or evening.

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 29 Apr 2002, Craig R. Hughes muttered drunkenly: > I put it in CVS last night. Thanks a lot for the work on this Tobias. > I haven't installed DCC on my own machine yet, nor written a dcc.t, > but will do that probably this afternoon or even

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Craig R Hughes
I put it in CVS last night. Thanks a lot for the work on this Tobias. I haven't installed DCC on my own machine yet, nor written a dcc.t, but will do that probably this afternoon or evening. The patch looked good though, and passes all test w/out problem when DCC is *not* installed, so I checke

Re: [SAtalk] [PATCH] DCC Support for SA

2002-04-29 Thread Sean Rima
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sun, 28 Apr 2002, Tobias von Koch yowled: > Hi, > > attached is a patch which adds support for the Distributed Checksum > Clearinghouse (DCC) System to spamassassin. As discussed earlier on > this list, DCC is a system similar to Razor, which sup

[SAtalk] [PATCH] DCC Support for SA

2002-04-28 Thread Tobias von Koch
Hi, attached is a patch which adds support for the Distributed Checksum Clearinghouse (DCC) System to spamassassin. As discussed earlier on this list, DCC is a system similar to Razor, which supports fuzzy checksums. Please note: I did some tests with the patch and it *appears* to work. But I