Kelsey Cummings wrote: >On Tue, Apr 30, 2002 at 01:42:26AM +0100, Sean Rima wrote: > >>-----BEGIN PGP SIGNED MESSAGE----- >>Hash: SHA1 >> >>On Tue, 30 Apr 2002, Sean Rima said: >> >> >>>>>SR> Use of uninitialized value at >>>>>SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line >>>>>SR> 270. DCC check skipped: Undefined subroutine >>>>>SR> &Mail::SpamAssassin::PerMsgStatus::open2 called at >>>>>SR> /usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line >>>>>SR> 270. >>>>> >>>>>Weird again. Given that we've just required IPC::Open2 a few lines >>>>>above, I don't see how it can now be failing to find open2() -- I >>>>>suppose it might need to be IPC::Open2::open2() or something. >>>>>Again, I'll see what I can do after installing DCC. >>>>> >>>>I changed line 270 to: >>>>$pid = IPC::Open2::open2(....) and the result was: >>>>Use of uninitialized value at >>>>/usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line 270. >>>>DCC check skipped: open2: wtr should not be null at >>>>/usr/lib/perl5/site_perl/5.005/Mail/SpamAssassin/Dns.pm line 270 >>>> >>>Okay I did: >>> use IPC::Open2; >>> instead of require IPC::Open2; and changed line 270 back to what you >>> had it, that gets rid of the Use of uninitialized value line but >>> not the wtr error >>> >>I did this: >> $pid = open2(\*Dccout, \*Dccin, '...... >> > >Hrm. Typeglobs have always scared me for somereason. Then again, so has >open2. It's always seemed so kludgy. > open2? Has anyone tested this with spamd? The reason I ask is that I recently wrote a networking daemon in Perl that used open3() while doing the canonical close() on STDOUT, STDIN, and STDERR. I couldn't get it to work until I redirected those file handles to /dev/null rather than closing them. Probably something to do with the way open3() handles close-on-exec (FD_CLOEXEC) for filehandles other than those. I don't know if the current code handles this correctly or even does the close-on-exec, but it's a potential gotcha.
-- http://www.pricegrabber.com "We are smarter individually." -- Larry Niven _______________________________________________ Spamassassin-talk mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/spamassassin-talk