Re: CVS commit: src/sys/dev

2025-05-24 Thread Valery Ushakov
On Sat, May 24, 2025 at 16:50:54 +, Nia Alarie wrote: > Defining this layout is slightly optimistic, since even with latin-2 > fonts loaded and the appropriate locale set, wscons seems to struggle > to input most of these characters. > > Regardless, this allows the supposedly supported "pl" e

Re: CVS commit: src/sys/arch

2025-05-22 Thread Christoph Badura
I meant but forgot to mention in the commit message that I added the missing cinclude for XEN3_DOM0.local to amd64/conf/XEN3_DOM0. On Thu, May 22, 2025 at 09:37:40AM +, Christoph Badura wrote: > Module Name: src > Committed By: bad > Date: Thu May 22 09:37:40 UTC 2025 > > Modified Fi

Re: CVS commit: src/sys

2025-05-13 Thread RVP
On Thu, 8 May 2025, Paul Goyette wrote: Looks to me like duplicated code, since they fall thru to the trailing else clause. Yep, that's why I deleted 'em. -RVP

Re: CVS commit: src/sys

2025-05-08 Thread Paul Goyette
(b) I'm confused by how some parts of it are relevant to the goal, particularly these hunks: --- a/sys/lib/libsa/bootcfg.c Tue May 06 17:12:33 2025 + +++ b/sys/lib/libsa/bootcfg.c Tue May 06 18:16:12 2025 + ... @@ -227,8 +227,6 @@ perform_bootcfg(const char *conf, bootcf

Re: CVS commit: src/sys

2025-05-08 Thread Paul Goyette
On Thu, 8 May 2025, Taylor R Campbell wrote: Module Name:src Committed By: pgoyette Date: Tue May 6 18:16:12 UTC 2025 Modified Files: src/sys/arch/i386/stand/boot: boot2.c src/sys/arch/i386/stand/lib: bootmenu.c libi386.h src/sys/arch/i386/stand/pxeboot:

CVS commit: src/sys

2025-05-08 Thread Taylor R Campbell
> Module Name:src > Committed By: pgoyette > Date: Tue May 6 18:16:12 UTC 2025 > > Modified Files: > src/sys/arch/i386/stand/boot: boot2.c > src/sys/arch/i386/stand/lib: bootmenu.c libi386.h > src/sys/arch/i386/stand/pxeboot: main.c > src/sys/lib/li

Re: CVS commit: src/sys/arch/i386/stand

2025-04-29 Thread Paul Goyette
I've just committed a better, and more well-tested, version. Should work correctly now. Thanks for your patience, and sorry for the breakage. On Tue, 29 Apr 2025, Paul Goyette wrote: Thanks for the link to the log. I am investigating. On Tue, 29 Apr 2025, Thomas Klausner wrote: On Tue, A

Re: CVS commit: src/sys/arch/i386/stand

2025-04-29 Thread Paul Goyette
Thanks for the link to the log. I am investigating. On Tue, 29 Apr 2025, Thomas Klausner wrote: On Tue, Apr 29, 2025 at 09:08:38AM +, Martin Husemann wrote: Module Name:src Committed By: martin Date: Tue Apr 29 09:08:38 UTC 2025 Modified Files: src/sys/arch/i386/s

Re: CVS commit: src/sys/arch/i386/stand

2025-04-29 Thread Thomas Klausner
On Tue, Apr 29, 2025 at 09:08:38AM +, Martin Husemann wrote: > Module Name: src > Committed By: martin > Date: Tue Apr 29 09:08:38 UTC 2025 > > Modified Files: > src/sys/arch/i386/stand/boot: boot2.c > src/sys/arch/i386/stand/efiboot: boot.c > > Log Message: > Backout /fi

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-22 Thread Izumi Tsutsui
> > a) apply the workaround to all m68k ports: > > pros: same m68k binaries can be shared > > cons: requires extra performance penalty for all m68k (020/030/040/060) > > > > b) apply the workaround only for XC68LC040 users: > > pros: nothing? (only technical interests of developers?) > > cons:

Re: CVS commit: src/sys/net

2025-04-16 Thread Ryota Ozaki
On Wed, Apr 16, 2025 at 9:25 PM Taylor R Campbell wrote: > > > Module Name:src > > Committed By: ozaki-r > > Date: Wed Apr 16 05:29:45 UTC 2025 > > > > Modified Files: > > src/sys/net: if_bridge.c > > > > Log Message: > > bridge: avoid a race condition on stopping callout >

Re: CVS commit: src/sys/net

2025-04-16 Thread Taylor R Campbell
> Module Name:src > Committed By: ozaki-r > Date: Wed Apr 16 05:29:45 UTC 2025 > > Modified Files: > src/sys/net: if_bridge.c > > Log Message: > bridge: avoid a race condition on stopping callout > > Without BRIDGE_LOCK, the callout can be scheduled after callout_halt. O

Re: CVS commit: src/sys/dev/nvmm/x86

2025-04-15 Thread Andrius V
nvmm_x86_svm.c has same typos. On Mon, Apr 14, 2025, 01:00 Taylor R Campbell wrote: > Module Name:src > Committed By: riastradh > Date: Sun Apr 13 22:00:43 UTC 2025 > > Modified Files: > src/sys/dev/nvmm/x86: nvmm_x86_vmx.c > > Log Message: > nvmm(4): Fix typos in commen

Re: CVS commit: src/sys

2025-04-13 Thread Rin Okuyama
On 2025/04/13 15:50, Thomas Klausner wrote: On Sun, Apr 13, 2025 at 02:34:03AM +, Rin Okuyama wrote: ... XXX This is KABI change, and cannot be pulled up into netbsd-{10,9}. If this changes the ABI, shouldn't the NetBSD Version in sys/param.h be bumped? Thomas Good question ;) Thank

Re: CVS commit: src/sys

2025-04-12 Thread Thomas Klausner
On Sun, Apr 13, 2025 at 02:34:03AM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Sun Apr 13 02:34:03 UTC 2025 > > Modified Files: > src/sys/arch/usermode/dev: ld_thunkbus.c > src/sys/dev: ld.c ldvar.h > src/sys/dev/ata: ld_ataraid.c > src

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-12 Thread Nat Sloss
On Sun, 13 Apr 2025 08:28:04 Izumi Tsutsui wrote: > > Would you or isaki@ or martin@ like me to assign PR 13078 to either of > > you and I'll write a followup email to the binutils people stating that > > from now on you'll handle all responsibilty for the correspondance with > > them and assign ei

Re: CVS commit: src/sys/dev

2025-04-12 Thread Rin Okuyama
Hi Michael, On 2025/04/12 21:00, Michael van Elst wrote: On Sat, Apr 12, 2025 at 08:14:28PM +0900, Rin Okuyama wrote: Hi Michael, thanks for kind review! Hi rin, PS For ld_sdmmc.c, IIUC, check for ld_sdmmc_dump() yields ``` if (blkno + blkcnt - 1 > sc->sc_sf->csd.capacity) return

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-12 Thread Izumi Tsutsui
> Would you or isaki@ or martin@ like me to assign PR 13078 to either of you > and > I'll write a followup email to the binutils people stating that from now on > you'll handle all responsibilty for the correspondance with them and assign > either of you to the doc/HACKS note. Actually I had n

Re: CVS commit: src/sys/dev

2025-04-12 Thread Michael van Elst
On Sat, Apr 12, 2025 at 08:14:28PM +0900, Rin Okuyama wrote: > Hi Michael, thanks for kind review! Hi rin, > PS > For ld_sdmmc.c, IIUC, check for ld_sdmmc_dump() yields > > ``` > if (blkno + blkcnt - 1 > sc->sc_sf->csd.capacity) > return EIO; capacity is the block count, not the last bl

Re: CVS commit: src/sys/dev

2025-04-12 Thread Rin Okuyama
Hi Michael, thanks for kind review! On 2025/04/12 19:01, Michael van Elst wrote: On Sat, Apr 12, 2025 at 06:24:44PM +0900, Rin Okuyama wrote: Hi! I've made a draft patch to support dumping against > 2Gi blocks for backends like nvme(4) or virtio(4). Does it look reasonable to you? Hi rin,

Re: CVS commit: src/sys/dev

2025-04-12 Thread Michael van Elst
On Sat, Apr 12, 2025 at 02:42:33AM -0700, Paul Goyette wrote: > Does this help kern/59153? It avoids data loss and corruption in similar cases. The exact condition in kern/59153 luckily didn't dump at all. Greetings, -- Michael van Elst Internet: mlel...@serpens.d

Re: CVS commit: src/sys/dev

2025-04-12 Thread Michael van Elst
On Sat, Apr 12, 2025 at 06:24:44PM +0900, Rin Okuyama wrote: > Hi! > > I've made a draft patch to support dumping against > 2Gi blocks > for backends like nvme(4) or virtio(4). > > Does it look reasonable to you? Hi rin, > - if (blkno < 0 || blkno + nblk - 1 > INT_MAX) > + if (blkno

Re: kern/59153 crash doesn't dump (Was: CVS commit: src/sys/dev)

2025-04-12 Thread Rin Okuyama
Ah, yes, I'd just forgotten this PR! As mrg@ suggested, we should probably: (1) pullup mlelstv@'s fix to netbsd-10 and -9, then (2) commit something like my patch only for -current. (2) should fix the original problem, probably ;) Thanks, rin On 2025/04/12 18:44, Paul Goyette wrote: Is this r

Re: CVS commit: src/sys/dev

2025-04-12 Thread Paul Goyette
Is this related to kern/59153? On Sat, 12 Apr 2025, Rin Okuyama wrote: Hi! I've made a draft patch to support dumping against > 2Gi blocks for backends like nvme(4) or virtio(4). Does it look reasonable to you? Thanks, rin On 2025/04/12 16:30, Michael van Elst wrote: Module Name:src Co

Re: CVS commit: src/sys/dev

2025-04-12 Thread Paul Goyette
Does this help kern/59153? On Sat, 12 Apr 2025, Michael van Elst wrote: Module Name:src Committed By: mlelstv Date: Sat Apr 12 07:30:01 UTC 2025 Modified Files: src/sys/dev: ld.c Log Message: ld sc_dump backend takes an 'int' as disk address, fail when the disk address

Re: CVS commit: src/sys/dev

2025-04-12 Thread Rin Okuyama
Hi! I've made a draft patch to support dumping against > 2Gi blocks for backends like nvme(4) or virtio(4). Does it look reasonable to you? Thanks, rin On 2025/04/12 16:30, Michael van Elst wrote: Module Name:src Committed By: mlelstv Date: Sat Apr 12 07:30:01 UTC 2025 Modifi

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-10 Thread Nat Sloss
On Fri, 11 Apr 2025 02:07:06 Izumi Tsutsui wrote: > When committing code, it's important to provide a obvious explanation > of the technical rationale behind the implementation. > > Without such rationale, the code can become difficult to maintain > in the future, as later contributors may not und

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-10 Thread Nat Sloss
On Mon, 7 Apr 2025 17:58:26 Tetsuya Isaki wrote: > At Sat, 5 Apr 2025 22:47:39 +1100, > > Nat Sloss wrote: > > Before I placed the additional nops before rte I experienced 1 hard > > lockup which I attributed to the fpu (buggy lc) > > > The idea was this: > It can't be certain that the behavior i

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-10 Thread Izumi Tsutsui
> I did it to be on the safe side. If the kernel was to be built with -mlcfix > passed to gas(1) the nop would be inserted. It seems there might be some confusion between the goal (i.e. avoiding f-line exception during write-pending) and the approach/workaround (inserting a nop before F-line ins

Re: CVS commit: src/sys/kern

2025-04-09 Thread Rin Okuyama
Hmm, I was still confused. On 2025/04/10 11:08, Rin Okuyama wrote: On 2025/04/09 14:38, Rin Okuyama wrote: Module Name:    src Committed By:    rin Date:    Wed Apr  9 05:38:01 UTC 2025 Modified Files: src/sys/kern: subr_log.c Log Message: logread: Stop reading msgbuf without log_lock

Re: CVS commit: src/sys/kern

2025-04-09 Thread Rin Okuyama
On 2025/04/09 14:38, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Wed Apr 9 05:38:01 UTC 2025 Modified Files: src/sys/kern: subr_log.c Log Message: logread: Stop reading msgbuf without log_lock being held Oops, sorry, here I made typo; s/reading/writing/

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-09 Thread Nathanial Sloss
On Thu, 10 Apr 2025 00:44:02 Izumi Tsutsui wrote: > > Module Name:src > > Committed By: nat > > Date: Wed Apr 9 00:04:41 UTC 2025 > > > > Modified Files: > > src/sys/arch/m68k/m68k: fpu.c > > > > Log Message: > > Add workaround for fpu test for kernels defined wit

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-09 Thread Izumi Tsutsui
> Module Name: src > Committed By: nat > Date: Wed Apr 9 00:04:41 UTC 2025 > > Modified Files: > src/sys/arch/m68k/m68k: fpu.c > > Log Message: > Add workaround for fpu test for kernels defined with M68040. > > This is to accomodate kernels built without the -mlcfix option passed

Re: CVS commit: src/sys/arch/mac68k/mac68k

2025-04-08 Thread Nat Sloss
Module Name:src Committed By: nat Date: Tue Apr 8 23:42:08 UTC 2025 Modified Files: src/sys/arch/mac68k/mac68k: pmap_bootstrap.c Log Message: Move high back an additional 7 pages to fix crashing on kernels with ascaudio(4) enabled. Memory

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-08 Thread Nat Sloss
On Tue, 8 Apr 2025 15:10:24 Martin Husemann wrote: > On Tue, Apr 08, 2025 at 10:45:23AM +1000, Nat Sloss wrote: > > nop - f* instructions are not atomicwhat will happen if nop is > > executed and then the processor is interrupted (by say pressing a > > keystroke on the keyboard) then after tha

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-07 Thread Martin Husemann
On Tue, Apr 08, 2025 at 10:45:23AM +1000, Nat Sloss wrote: > nop - f* instructions are not atomicwhat will happen if nop is executed > and then the processor is interrupted (by say pressing a keystroke on the > keyboard) then after that interrupt has run the f* instruction is executed. > >

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-07 Thread Nat Sloss
On Mon, 7 Apr 2025 17:44:09 Tetsuya Isaki wrote: > At Sat, 5 Apr 2025 22:01:37 +1100, > > Nat Sloss wrote: > > Following advice and following the spirit of my intentions adding nop in > > the switch i added nops before "rte" in locore.s in sys/mac68k as > > opposed to m68k/swicher. > > Are you su

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-07 Thread Tetsuya Isaki
At Sat, 5 Apr 2025 22:47:39 +1100, Nat Sloss wrote: > Before I placed the additional nops before rte I experienced 1 hard lockup > which I attributed to the fpu (buggy lc) > > The idea was this: It can't be certain that the behavior is related to this bug. XC68LC040 series are known for having m

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-07 Thread Tetsuya Isaki
At Sat, 5 Apr 2025 22:01:37 +1100, Nat Sloss wrote: > Following advice and following the spirit of my intentions adding nop in the > switch i added nops before "rte" in locore.s in sys/mac68k as opposed to > m68k/swicher. Are you sure? First, errata E4 said the workaround is "nop-before-f-line"

Re: CVS commit: src/sys/dev/usb

2025-04-06 Thread Hans Rosenfeld
Hi, On Tue, Mar 25, 2025 at 08:28:10PM +, Taylor R Campbell wrote: > Thanks for taking a look at this! This change is not quite enough, > though. There are two issues: > > 1. `#ifdef DIAGNOSTIC printf(...)' is almost always wrong. Generally, >either: > >(a) the condition should be

lint: constant in conditional (was: Re: CVS commit: src/sys/sys)

2025-04-05 Thread Roland Illig
Am 06.04.2025 um 03:24 schrieb Taylor R Campbell: >> Date: Sat, 5 Apr 2025 19:18:20 +0200 >> From: Roland Illig >> >> Would it be narrow enough to add /*CONSTCOND*/ to the definition of >> ALIGNED_POINTER on i386 and amd64? Or would you consider this still too >> broad? > > Might be reasonable. B

Re: CVS commit: src/sys/sys

2025-04-05 Thread Taylor R Campbell
> Date: Sat, 5 Apr 2025 19:18:20 +0200 > From: Roland Illig > > Would it be narrow enough to add /*CONSTCOND*/ to the definition of > ALIGNED_POINTER on i386 and amd64? Or would you consider this still too > broad? Might be reasonable. But then we have a lot of predicates that might be used in

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nat Sloss
On Fri, 4 Apr 2025 23:27:49 Martin Husemann wrote: > On Fri, Apr 04, 2025 at 10:48:17PM +1100, Nat Sloss wrote: > > The changes to the context switch in sys/m68k have been reverted and the > > nop insertion by gas(1) has been turned off by default. > > What does upstream gcc plan to do with the ne

CVS commit: src/sys/sys

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 29 15:48:26 UTC 2025 Modified Files: src/sys/sys: cdefs.h Log Message: __predict_true/false: Make these work with C++ too. Should fix build after recent assert.h change. error: no match for `operator!=' (operand types

CVS commit: src/sys

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:45:35 UTC 2025 Modified Files: src/sys/arch/mips/ralink: ralink_ehci.c src/sys/dev/cardbus: ehci_cardbus.c src/sys/dev/pci: ehci_pci.c usb_pci.c Log Message: ehci(4): Sprinkle KERNEL_LOCKED_P and K

CVS commit: src/sys/arch/vax

2025-04-05 Thread Hans Rosenfeld
Module Name:src Committed By: hans Date: Sat Mar 22 10:37:19 UTC 2025 Modified Files: src/sys/arch/vax/include: db_machdep.h src/sys/arch/vax/vax: db_disasm.c db_machdep.c trap.c Log Message: vax/ddb(4): clean up machine dependent code and improve usability First,

CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Sun Mar 30 04:44:26 UTC 2025 Modified Files: src/sys/arch/m68k/m68k: switch_subr.s Log Message: Sprinkle nop. This is the kernel part of addressing the issue with fpu emulation on lc040 cpus. The idea is that we might be switch fro

CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Mon Mar 31 13:03:23 UTC 2025 Modified Files: src/sys/arch/m68k/m68k: switch_subr.s Log Message: Wrap up lc040 compatability nops in a macro. Also add a comment describing why they are there so they wont be accidently removed in the

CVS commit: src/sys/arch/evbarm/conf

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Mar 27 12:23:19 UTC 2025 Modified Files: src/sys/arch/evbarm/conf: GENERIC64 Log Message: evbarm/GENERIC64: Enable vio9p(4). Tested under qemu. PR kern/59211: vio9p(4): missing from various GENERICs and MAKEDEVs To gene

CVS commit: src/sys/arch/evbarm/conf

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Mar 27 12:23:19 UTC 2025 Modified Files: src/sys/arch/evbarm/conf: GENERIC64 Log Message: evbarm/GENERIC64: Enable vio9p(4). Tested under qemu. PR kern/59211: vio9p(4): missing from various GENERICs and MAKEDEVs To gene

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nathanial Sloss
On Mon, 31 Mar 2025 22:48:39 Tetsuya Isaki wrote: > At Sun, 30 Mar 2025 04:44:26 +, > > Nathanial Sloss wrote: > > Module Name:src > > Committed By: nat > > Date: Sun Mar 30 04:44:26 UTC 2025 > > > > Modified Files: > > src/sys/arch/m68k/m68k: switch_subr.s > >

CVS commit: src/sys/dev/usb

2025-04-05 Thread Hans Rosenfeld
Module Name:src Committed By: hans Date: Sun Mar 23 12:07:24 UTC 2025 Modified Files: src/sys/dev/usb: uts.c Log Message: uts(4): make sure the device is enabled before calling uhidev_close() This check was already there, but only enabled for DIAGNOSTIC kernels. The check

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 20 15:18:43 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: And fix the formatting. /me needs to stop committing when severely sleep-deprived To generate a diff of this commit: cvs rdiff -u -r1.166 -

Re: CVS commit: src/sys/sys

2025-04-05 Thread Roland Illig
Am 05.04.2025 um 02:07 schrieb Taylor R Campbell: >> Module Name:src >> Committed By: rillig >> Date: Fri Apr 4 20:52:32 UTC 2025 >> >> Modified Files: >> src/sys/sys: cdefs.h >> >> Log Message: >> sys/cdefs.h: fix __predict_true and __predict_false for lint >> >> -#define

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 20 15:18:43 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: And fix the formatting. /me needs to stop committing when severely sleep-deprived To generate a diff of this commit: cvs rdiff -u -r1.166 -

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Tetsuya Isaki
At Tue, 1 Apr 2025 02:26:35 +1100, Nathanial Sloss wrote: > Consider the following (including my gas patch for binutils): > > movq. > nop > fnop > > Thats as it's assembled but at run time it could posslibly > run like this > > movq > nop > (switch task) > fnop > > So the nops are inser

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 20 13:24:06 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: Be consistent in formatting `module' names in diagnostic messages NFCI To generate a diff of this commit: cvs rdiff -u -r1.163 -r1.164 src/

CVS commit: src/sys/dev/wscons

2025-04-05 Thread Hans Rosenfeld
Module Name:src Committed By: hans Date: Sun Mar 23 12:09:05 UTC 2025 Modified Files: src/sys/dev/wscons: wskbd.c Log Message: wskbd(4): fix bogus DIAGNOSTIC checks Similar to uts(4) and ums(4), these checks should be done always, and the only thing DIAGNOSTIC about them

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Fri Mar 21 07:09:58 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: Consistently capitalize the beginning of a kernel message. NFCI To generate a diff of this commit: cvs rdiff -u -r1.167 -r1.168 src/sys/ker

CVS commit: src/sys/external/bsd/drm2/dist/drm/nouveau

2025-04-05 Thread Emmanuel
Module Name:src Committed By: joe Date: Sun Mar 23 17:04:10 UTC 2025 Modified Files: src/sys/external/bsd/drm2/dist/drm/nouveau: nouveau_bo.c Log Message: safety: fix memory leak in drm use error lable to free and return on error To generate a diff of this commit: cvs rd

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Martin Husemann
On Sat, Apr 05, 2025 at 10:47:39PM +1100, Nat Sloss wrote: > nop > fnop > > could be executed as > > nop > (context swtich) > (return from context swtich) > fnop > > So without these the fnop would not be coverted. Not sure what you mean here. Why would the nop before the rte make any differen

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nat Sloss
On Sat, 5 Apr 2025 22:32:10 Martin Husemann wrote: > On Sat, Apr 05, 2025 at 10:01:37PM +1100, Nat Sloss wrote: > > Following advice and following the spirit of my intentions adding nop in > > the switch i added nops before "rte" in locore.s in sys/mac68k as > > opposed to m68k/swicher. > > This m

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Martin Husemann
On Sat, Apr 05, 2025 at 10:01:37PM +1100, Nat Sloss wrote: > Following advice and following the spirit of my intentions adding nop in the > switch i added nops before "rte" in locore.s in sys/mac68k as opposed to > m68k/swicher. This makes no sense to me (but I can only guess how the exact bug w

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nat Sloss
Following advice and following the spirit of my intentions adding nop in the switch i added nops before "rte" in locore.s in sys/mac68k as opposed to m68k/swicher. Along with adding nops before fline instructions with the modified assember. I took a picture for your consideration. http://ftp.n

Re: CVS commit: src/sys/sys

2025-04-04 Thread Taylor R Campbell
> Module Name:src > Committed By: rillig > Date: Fri Apr 4 20:52:32 UTC 2025 > > Modified Files: > src/sys/sys: cdefs.h > > Log Message: > sys/cdefs.h: fix __predict_true and __predict_false for lint > > -#define __predict_true(exp) __builtin_expect((exp) ? 1 :

CVS commit: src/sys

2025-04-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:46:42 UTC 2025 Modified Files: src/sys/arch/arm/xscale: pxa2x0_ohci.c src/sys/arch/mips/ralink: ralink_ohci.c src/sys/dev/cardbus: ohci_cardbus.c src/sys/dev/pci: ohci_pci.c src/sys/

CVS commit: src/sys/arch/amd64/conf

2025-04-04 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 20 22:16:58 UTC 2025 Modified Files: src/sys/arch/amd64/conf: MODULAR Log Message: We now have COMPAT_100, so use the modular version vs built-in To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/sys/ar

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-04 Thread Nat Sloss
On Fri, 4 Apr 2025 22:37:50 Tetsuya Isaki wrote: > At Thu, 3 Apr 2025 14:00:16 +0200, > > Martin Husemann wrote: > > > So these all nops are never executed just before any of f-line > > > instructions. > > > > Can you also please explain how you got at that NOP-after-f-line > > woraround? The Mot

CVS commit: src/sys

2025-04-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:46:42 UTC 2025 Modified Files: src/sys/arch/arm/xscale: pxa2x0_ohci.c src/sys/arch/mips/ralink: ralink_ohci.c src/sys/dev/cardbus: ohci_cardbus.c src/sys/dev/pci: ohci_pci.c src/sys/

CVS commit: src/sys/arch/amd64/amd64

2025-04-04 Thread Pierre Pronchery
Module Name:src Committed By: khorben Date: Sun Mar 30 19:48:15 UTC 2025 Modified Files: src/sys/arch/amd64/amd64: locore.S Log Message: locore.S: remove duplicate comment Trivial change, tested anyway on NetBSD/amd64; NFCI. "Go go" imil@ To generate a diff of this com

CVS commit: src/sys/dev/pci

2025-04-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:48:50 UTC 2025 Modified Files: src/sys/dev/pci: ohci_pci.c Log Message: ohci@pci: Don't detach on shutdown. If there's some USB device that requires detach on shutdown (which would be surprising, because USB devi

CVS commit: src/sys

2025-04-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:45:35 UTC 2025 Modified Files: src/sys/arch/mips/ralink: ralink_ehci.c src/sys/dev/cardbus: ehci_cardbus.c src/sys/dev/pci: ehci_pci.c usb_pci.c Log Message: ehci(4): Sprinkle KERNEL_LOCKED_P and K

CVS commit: src/sys/dev/pci

2025-04-04 Thread Emmanuel
Module Name:src Committed By: joe Date: Sun Mar 23 18:38:49 UTC 2025 Modified Files: src/sys/dev/pci: if_iavf.c Log Message: avoid NULL pointer dereference on failed memory allocation for sc_ihs To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/sys/dev/pc

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-04 Thread Tetsuya Isaki
At Thu, 3 Apr 2025 14:00:16 +0200, Martin Husemann wrote: > > So these all nops are never executed just before any of f-line > > instructions. > > Can you also please explain how you got at that NOP-after-f-line woraround? > The Motorola errata text (at least the versions I found on the wayback >

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-04 Thread Martin Husemann
On Fri, Apr 04, 2025 at 10:48:17PM +1100, Nat Sloss wrote: > The changes to the context switch in sys/m68k have been reverted and the nop > insertion by gas(1) has been turned off by default. What does upstream gcc plan to do with the new option? Default on or off? I guess we can find some way t

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-03 Thread Martin Husemann
On Thu, Apr 03, 2025 at 08:55:11PM +0900, Tetsuya Isaki wrote: > So these all nops are never executed just before any of f-line > instructions. Can you also please explain how you got at that NOP-after-f-line woraround? The Motorola errata text (at least the versions I found on the wayback machine

CVS commit: src/sys/dev/usb

2025-04-01 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:45:14 UTC 2025 Modified Files: src/sys/dev/usb: usbdivar.h Log Message: usbdivar.h: Add missing usbdi.h include for usbd_status &c. Sort includes while here. Prompted by: PR port-amd64/59180: System reboots ins

CVS commit: src/sys/arch/vax/vax

2025-03-31 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Mon Mar 31 19:22:09 UTC 2025 Modified Files: src/sys/arch/vax/vax: crl.h Log Message: s/transation/transaction/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/arch/vax/vax/crl.h Please note that

CVS commit: src/sys/dev/usb

2025-03-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:45:14 UTC 2025 Modified Files: src/sys/dev/usb: usbdivar.h Log Message: usbdivar.h: Add missing usbdi.h include for usbd_status &c. Sort includes while here. Prompted by: PR port-amd64/59180: System reboots ins

CVS commit: src/sys/dev/pci

2025-03-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:48:50 UTC 2025 Modified Files: src/sys/dev/pci: ohci_pci.c Log Message: ohci@pci: Don't detach on shutdown. If there's some USB device that requires detach on shutdown (which would be surprising, because USB devi

CVS commit: src/sys

2025-03-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:45:57 UTC 2025 Modified Files: src/sys/arch/mips/ralink: ralink_ehci.c src/sys/dev/cardbus: ehci_cardbus.c src/sys/dev/pci: usb_pci.c Log Message: ehci(4): Make usb_*_rem work as noop on zero-initi

CVS commit: src/sys

2025-03-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:45:57 UTC 2025 Modified Files: src/sys/arch/mips/ralink: ralink_ehci.c src/sys/dev/cardbus: ehci_cardbus.c src/sys/dev/pci: usb_pci.c Log Message: ehci(4): Make usb_*_rem work as noop on zero-initi

Re: CVS commit: src/sys/arch/m68k/m68k

2025-03-31 Thread Tetsuya Isaki
At Sun, 30 Mar 2025 04:44:26 +, Nathanial Sloss wrote: > Module Name: src > Committed By: nat > Date: Sun Mar 30 04:44:26 UTC 2025 > > Modified Files: > src/sys/arch/m68k/m68k: switch_subr.s > > Log Message: > Sprinkle nop. > > This is the kernel part of addressing the issue w

CVS commit: src/sys/netinet6

2025-03-30 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Mon Mar 31 05:55:43 UTC 2025 Modified Files: src/sys/netinet6: nd6.c Log Message: nd6: send packets through the fast path even if DELAY and PROBE If there is a valid ND cache, we can send packets for the destination of the cache

CVS commit: src/sys/netinet6

2025-03-30 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Mon Mar 31 05:55:43 UTC 2025 Modified Files: src/sys/netinet6: nd6.c Log Message: nd6: send packets through the fast path even if DELAY and PROBE If there is a valid ND cache, we can send packets for the destination of the cache

CVS commit: src/sys/arch/amd64/amd64

2025-03-30 Thread Pierre Pronchery
Module Name:src Committed By: khorben Date: Sun Mar 30 19:48:15 UTC 2025 Modified Files: src/sys/arch/amd64/amd64: locore.S Log Message: locore.S: remove duplicate comment Trivial change, tested anyway on NetBSD/amd64; NFCI. "Go go" imil@ To generate a diff of this com

CVS commit: src/sys/arch/m68k/m68k

2025-03-29 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Sun Mar 30 04:44:26 UTC 2025 Modified Files: src/sys/arch/m68k/m68k: switch_subr.s Log Message: Sprinkle nop. This is the kernel part of addressing the issue with fpu emulation on lc040 cpus. The idea is that we might be switch fro

CVS commit: src/sys/sys

2025-03-29 Thread Robert Elz
Module Name:src Committed By: kre Date: Sat Mar 29 17:29:20 UTC 2025 Modified Files: src/sys/sys: cpu_data.h Log Message: CPU_COUNT() macro args are properly parenthesised when used. This will hopefully fix builds after recent changes to how KASSERT() uses its args. To

CVS commit: src/sys/sys

2025-03-29 Thread Robert Elz
Module Name:src Committed By: kre Date: Sat Mar 29 17:29:20 UTC 2025 Modified Files: src/sys/sys: cpu_data.h Log Message: CPU_COUNT() macro args are properly parenthesised when used. This will hopefully fix builds after recent changes to how KASSERT() uses its args. To

CVS commit: src/sys/sys

2025-03-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 29 15:48:26 UTC 2025 Modified Files: src/sys/sys: cdefs.h Log Message: __predict_true/false: Make these work with C++ too. Should fix build after recent assert.h change. error: no match for `operator!=' (operand types

CVS commit: src/sys/dev/hyperv

2025-03-29 Thread NONAKA Kimihiro
Module Name:src Committed By: nonaka Date: Sat Mar 29 10:12:14 UTC 2025 Modified Files: src/sys/dev/hyperv: vmbus.c Log Message: vmbus(4): Fix missing conversion to condvar(9). To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/dev/hyperv/vmbus.c Plea

CVS commit: src/sys/arch/vax/vax

2025-03-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 29 00:16:30 UTC 2025 Modified Files: src/sys/arch/vax/vax: trap.c Log Message: vax/trap.c: Back out revisions 1.139 and 1.141 for now. These changes served to zero registers on exec in order to avoid leaking secret reg

CVS commit: src/sys/dev/hyperv

2025-03-29 Thread NONAKA Kimihiro
Module Name:src Committed By: nonaka Date: Sat Mar 29 10:12:14 UTC 2025 Modified Files: src/sys/dev/hyperv: vmbus.c Log Message: vmbus(4): Fix missing conversion to condvar(9). To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/dev/hyperv/vmbus.c Plea

CVS commit: src/sys/arch/vax/vax

2025-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 29 00:16:30 UTC 2025 Modified Files: src/sys/arch/vax/vax: trap.c Log Message: vax/trap.c: Back out revisions 1.139 and 1.141 for now. These changes served to zero registers on exec in order to avoid leaking secret reg

CVS commit: src/sys/kern

2025-03-28 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Fri Mar 28 23:26:34 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: Cleanup a couple more debug messages To generate a diff of this commit: cvs rdiff -u -r1.170 -r1.171 src/sys/kern/kern_module.c Please note

CVS commit: src/sys/kern

2025-03-28 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Fri Mar 28 23:26:34 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: Cleanup a couple more debug messages To generate a diff of this commit: cvs rdiff -u -r1.170 -r1.171 src/sys/kern/kern_module.c Please note

CVS commit: src/sys/fs/udf

2025-03-28 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Fri Mar 28 19:34:36 UTC 2025 Modified Files: src/sys/fs/udf: udf_subr.c Log Message: s/beyong/beyond/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.176 -r1.177 src/sys/fs/udf/udf_subr.c Please note that diffs

CVS commit: src/sys/fs/udf

2025-03-28 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Fri Mar 28 19:34:36 UTC 2025 Modified Files: src/sys/fs/udf: udf_subr.c Log Message: s/beyong/beyond/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.176 -r1.177 src/sys/fs/udf/udf_subr.c Please note that diffs

CVS commit: src/sys/arch

2025-03-27 Thread Emile iMil Heitor
Module Name:src Committed By: imil Date: Fri Mar 28 05:54:49 UTC 2025 Modified Files: src/sys/arch/amd64/conf: MICROVM src/sys/arch/i386/conf: MICROVM Added Files: src/sys/arch/x86/conf: MICROVM.common Log Message: x86: consolidate MICROVM kernel configurat

CVS commit: src/sys/arch

2025-03-27 Thread Emile iMil Heitor
Module Name:src Committed By: imil Date: Fri Mar 28 05:54:49 UTC 2025 Modified Files: src/sys/arch/amd64/conf: MICROVM src/sys/arch/i386/conf: MICROVM Added Files: src/sys/arch/x86/conf: MICROVM.common Log Message: x86: consolidate MICROVM kernel configurat

  1   2   3   4   5   6   7   8   9   10   >