Module Name: src Committed By: riastradh Date: Mon Mar 31 14:48:50 UTC 2025
Modified Files: src/sys/dev/pci: ohci_pci.c Log Message: ohci@pci: Don't detach on shutdown. If there's some USB device that requires detach on shutdown (which would be surprising, because USB devices should generally be safe to yank at any time, and _storage_ drivers such as ld(4) or sd(4) should already be synced at shutdown some other way) then that driver should have DVF_DETACH_SHUTDOWN -- not the entire HCI. PR port-amd64/59180: System reboots instead of shutting down PR kern/59179: DVF_DETACH_SHUTDOWN: audit drivers for unnecessary use To generate a diff of this commit: cvs rdiff -u -r1.60 -r1.61 src/sys/dev/pci/ohci_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/dev/pci/ohci_pci.c diff -u src/sys/dev/pci/ohci_pci.c:1.60 src/sys/dev/pci/ohci_pci.c:1.61 --- src/sys/dev/pci/ohci_pci.c:1.60 Mon Mar 31 14:46:42 2025 +++ src/sys/dev/pci/ohci_pci.c Mon Mar 31 14:48:50 2025 @@ -1,4 +1,4 @@ -/* $NetBSD: ohci_pci.c,v 1.60 2025/03/31 14:46:42 riastradh Exp $ */ +/* $NetBSD: ohci_pci.c,v 1.61 2025/03/31 14:48:50 riastradh Exp $ */ /* * Copyright (c) 1998 The NetBSD Foundation, Inc. @@ -31,7 +31,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: ohci_pci.c,v 1.60 2025/03/31 14:46:42 riastradh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: ohci_pci.c,v 1.61 2025/03/31 14:48:50 riastradh Exp $"); #include "ehci.h" @@ -244,4 +244,4 @@ ohci_pci_detach(device_t self, int flags CFATTACH_DECL3_NEW(ohci_pci, sizeof(struct ohci_pci_softc), ohci_pci_match, ohci_pci_attach, ohci_pci_detach, ohci_activate, NULL, - ohci_childdet, DVF_DETACH_SHUTDOWN); + ohci_childdet, 0);