On Wed, 21 Aug 2024 13:42:18 GMT, Joakim Nordström
wrote:
>> Can I get a review of this documentation update to clarify the usage of
>> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and
>> GetProcessCpuLoad.
>>
>> Calling either of these methods in quick succession can lead to
>> u
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> Main changes:
> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
> changes in this PR are protected by this flag. The purpose of the flag is to
> provide a fallback, in case that users unexp
On Thu, 22 Aug 2024 00:30:07 GMT, Jiangli Zhou wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also update build to link properly
>
> I compared the extracted changes in this PR with the related parts in
> h
On Wed, 21 Aug 2024 14:54:40 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Thu, 22 Aug 2024 02:46:34 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also update build to link properly
>
> Sorry but I don't understand the point of changing build-time constructs
On Thu, 22 Aug 2024 08:00:54 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> Main changes:
>> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
>> changes in this PR are protected by this flag. The purpose of t
On Tue, 13 Aug 2024 15:07:17 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
> enabling support for timestamp expansion in filenames specified in
> `-XX:HeapDumpPath` using `%t`.
>
> As mentioned in this comments for t
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> Main changes:
> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
> changes in this PR are protected by this flag. The purpose of the flag is to
> provide a fallback, in case that users unexp
On Thu, 22 Aug 2024 10:30:00 GMT, Magnus Ihse Bursie wrote:
> @rkennke Note that the Skara bot removed the RFR label when you changed the
> title to no longer match a JBS issue. This means that no emails will be sent
> to the corresponding lists. I am not sure if this was intentional on your
>
On Tue, 20 Aug 2024 10:07:26 GMT, Roman Kennke wrote:
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> Main changes:
> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
> changes in this PR are protected by this flag. The purpose of the fl
On Thu, 22 Aug 2024 11:05:18 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> Main changes:
>> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
>> changes in this PR are protected by this flag. The purpose of t
This is the main body of the JEP 450: Compact Object Headers (Experimental).
It is also a follow-up to #20640, which now also includes (and supersedes)
#20603 and #20605, plus the Tiny Class-Pointers parts that have been previously
missing.
Main changes:
- Introduction of the (experimental) fl
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 22 Aug 2024 08:47:32 GMT, Thomas Stuefe wrote:
> > I think `test/jdk/sun/tools/jcmd/TestJcmdPIDSubstitution.java` should be
> > updated to allow System.dump_map on Windows, not just linux.
> > [6733b89](https://github.com/openjdk/jdk/commit/6733b89de1ed9ebcc1e8a8271970048ad0f0aac3)
>
>
On Tue, 20 Aug 2024 07:14:18 GMT, Thomas Stuefe wrote:
>> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>>
>>> 96: buffer[idx++] = 'n';
>>> 97: } else if (prot != 0) {
>>> 98: snprintf(buffer, bufsiz, "(0x%x)", prot);
>>
>> This could truncate for the
On Wed, 21 Aug 2024 12:32:00 GMT, Simon Tooke wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 1207:
>>
>>> 1205: const char* absname = os::Posix::realpath(name, tmp, sizeof(tmp));
>>> 1206: name = absname != nullptr ? absname : name;
>>> 1207: #endif
>>
>> I wince a bit
On Tue, 20 Aug 2024 07:05:54 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix test failure
>> - enabled TestJcmdPIDSubstitution.java test for Windows
>
> src/hotspot/os/windows/memMapPrinter
On Thu, 22 Aug 2024 10:59:58 GMT, Kevin Walls wrote:
> which says "%t => -MM-DD_HH-MM-SS" so maybe we could follow that pattern
Another vote for the above time stamp pattern.
-
PR Comment: https://git.openjdk.org/jdk/pull/20568#issuecomment-2305273185
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 22 Aug 2024 16:26:12 GMT, Simon Tooke wrote:
>> I agree, and was surprised this wasn't originally implemented. I'll prepare
>> a second PR.
>
> I have filed issue [#8338851](https://bugs.openjdk.org/browse/JDK-8338851)
> "Hoist os::Posix::realpath() to os::realpath() and implement on W
On Tue, 13 Aug 2024 15:07:17 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
> enabling support for timestamp expansion in filenames specified in
> `-XX:HeapDumpPath` using `%t`.
>
> As mentioned in this comments for t
On Thu, 22 Aug 2024 18:18:01 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Windows SA agent gets a class vtable from symbols, exported from jvm.dll (it
exports symbols like "??_7" + type + "@@6B@").
But symbol lookup function first requests WinDbg about the symbol.
Sometimes WinDbg routine IDebugSymbols::GetOffsetByName() returns offset for
both class and class point
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 22 Aug 2024 18:18:01 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 22 Aug 2024 16:23:48 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 22 Aug 2024 08:54:56 GMT, Magnus Ihse Bursie wrote:
>> Sorry but I don't understand the point of changing build-time constructs
>> using `ifdef STATIC_BUILD` into what appear to be runtime checks, but the
>> result of which is already determined at build time. These are not really
>> r
On Wed, 21 Aug 2024 09:54:08 GMT, Thomas Stuefe wrote:
>> Hi all,
>>
>> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
>> enabling support for timestamp expansion in filenames specified in
>> `-XX:HeapDumpPath` using `%t`.
>>
>> As mentioned in this comments for th
31 matches
Mail list logo
