On Thu, 22 Aug 2024 00:30:07 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Also update build to link properly
>
> I compared the extracted changes in this PR with the related parts in 
> https://github.com/openjdk/jdk/pull/19478. They look ok. My concern (as 
> discussed in 
> https://github.com/openjdk/jdk/pull/19478#issuecomment-2278421931) is  that 
> these runtime changes for static JDK can't be tested even they are relatively 
> simple, without the the actual linking change. Any timeline for the static 
> linking changes?

@jianglizhou 

> [...] these runtime changes for static JDK can't be tested [...]

Yes, they can. This is just a pure refactoring of existing code. I have 
deliberately kept out addition of the new places where static linking 
exceptions are needed in the code.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20666#issuecomment-2304110701

Reply via email to