On Tue, 18 Apr 2023 16:59:29 GMT, Markus Grönlund wrote:
> Greetings,
>
> For most platforms, os::dll_address_to_library_name() only sets offset = -1
> in case of errors. If there is an error, the function returns false. This is
> fine.
>
> On AIX, the offset, being optional, is invariantly s
On Tue, 18 Apr 2023 20:20:09 GMT, Daniel D. Daugherty
wrote:
>> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
>> expectedSystemTrace.
>> Tested on my local machine.
>
> We currently have a total of 20 sightings of this failure in both CI and Adhoc
> jobs and it's ha
> - The `throw()` (i.e., no throw) specifications are removed from the
> instances of `operator new` where _do not_ return `nullptr`.
>
> - The `-fcheck-new` is removed from the gcc compile flags.
>
> - The `operator new` and `operator delete` are deleted from `StackObj`.
>
> - The `GrowableArr
On Tue, 18 Apr 2023 18:29:13 GMT, Kim Barrett wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8305590: Remove nothrow exception specifications from operator new
>
> src/hotspot/share/memory/allocation.hpp line 289
On Tue, 18 Apr 2023 18:59:31 GMT, Kim Barrett wrote:
>> src/hotspot/share/runtime/thread.hpp line 203:
>>
>>> 201: static bool is_JavaThread_protected_by_TLH(const JavaThread* target);
>>> 202:
>>> 203: void operator delete(void* p);
>>
>> Should you have removed delete and Thread::alloca
On Tue, 18 Apr 2023 20:16:06 GMT, Ioi Lam wrote:
>> This PR combines the "open" and "closed" regions of the CDS archive heap
>> into a single region. This significantly simplifies the implementation,
>> making it more compatible with non-G1 collectors. There's a net removal of
>> ~1000 lines i
Hi! The patch fixes image/symbol lookup by jhsdb on alanysis Windows coredump.
It uses executableName as a hint prepending image path with
`;\server`
and symbol path with
`srv*https://msdl.microsoft.com/download/symbols;;\server`
where the first bit points to Windows symbols located on remote
On Tue, 18 Apr 2023 17:15:46 GMT, Serguei Spitsyn wrote:
>> Greetings,
>>
>> For most platforms, os::dll_address_to_library_name() only sets offset = -1
>> in case of errors. If there is an error, the function returns false. This is
>> fine.
>>
>> On AIX, the offset, being optional, is invari
On Tue, 18 Apr 2023 16:59:29 GMT, Markus Grönlund wrote:
> Greetings,
>
> For most platforms, os::dll_address_to_library_name() only sets offset = -1
> in case of errors. If there is an error, the function returns false. This is
> fine.
>
> On AIX, the offset, being optional, is invariantly s
On Mon, 17 Apr 2023 16:56:31 GMT, Jiangli Zhou wrote:
> - Make functions 'static' when feasible:
> - throwByName() in
> src/java.security.jgss/share/native/libj2gss/NativeUtil.c.
> - throwByName(), throwIOException() and throwNullPointerException() in
> src/java.smartcardio/unix/native/libj
On Wed, 19 Apr 2023 02:22:38 GMT, David Holmes wrote:
> @mgronlun I agree this does not look good. I'm not sure this was the right
> way to conditionalize the new code, rather than ensuring the callsites were
> conditionalized on INCLUDE_JVMTI.
It follows the same pattern as for other jvmti*.c
On Wed, 19 Apr 2023 10:25:49 GMT, Afshin Zafari wrote:
>> - The `throw()` (i.e., no throw) specifications are removed from the
>> instances of `operator new` where _do not_ return `nullptr`.
>>
>> - The `-fcheck-new` is removed from the gcc compile flags.
>>
>> - The `operator new` and `operat
> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
> expectedSystemTrace.
> Tested on my local machine.
Fredrik Bredberg has updated the pull request incrementally with two additional
commits since the last revision:
- Updated after review
- Added java.util.concurren
On Wed, 19 Apr 2023 10:25:49 GMT, Afshin Zafari wrote:
>> - The `throw()` (i.e., no throw) specifications are removed from the
>> instances of `operator new` where _do not_ return `nullptr`.
>>
>> - The `-fcheck-new` is removed from the gcc compile flags.
>>
>> - The `operator new` and `operat
On Wed, 19 Apr 2023 11:30:42 GMT, Fredrik Bredberg wrote:
>> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
>> expectedSystemTrace.
>> Tested on my local machine.
>
> Fredrik Bredberg has updated the pull request incrementally with two
> additional commits since the
On Wed, 19 Apr 2023 11:30:42 GMT, Fredrik Bredberg wrote:
>> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
>> expectedSystemTrace.
>> Tested on my local machine.
>
> Fredrik Bredberg has updated the pull request incrementally with two
> additional commits since the
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 18 Apr 2023 17:11:25 GMT, Coleen Phillimore wrote:
> Please review this patch to move the writeable Klass AccessFlags to
> InstanceKlassFlags.
> Tested with tier1-4.
Nice clean up.
Looks good to me.
-
Marked as reviewed by fparain (Reviewer).
PR Review: https://git.openjd
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Thu, 13 Apr 2023 14:49:58 GMT, Leonid Mesnik wrote:
> Could you please review following trivial fix which correct jvm options order
> in TestScaffold.
> TestScaffold combines test optionos and jtreg vm options. Before
> [JDK-8304834](https://bugs.openjdk.org/browse/JDK-8304834) it passed tes
On Tue, 18 Apr 2023 17:11:25 GMT, Coleen Phillimore wrote:
> Please review this patch to move the writeable Klass AccessFlags to
> InstanceKlassFlags.
> Tested with tier1-4.
Thanks Ioi and Fred.
-
PR Comment: https://git.openjdk.org/jdk/pull/13515#issuecomment-1514794910
On Tue, 18 Apr 2023 17:11:25 GMT, Coleen Phillimore wrote:
> Please review this patch to move the writeable Klass AccessFlags to
> InstanceKlassFlags.
> Tested with tier1-4.
This pull request has now been integrated.
Changeset: ddb86469
Author:Coleen Phillimore
URL:
https://git.ope
On Wed, 19 Apr 2023 11:30:42 GMT, Fredrik Bredberg wrote:
>> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
>> expectedSystemTrace.
>> Tested on my local machine.
>
> Fredrik Bredberg has updated the pull request incrementally with two
> additional commits since the
On Wed, 19 Apr 2023 11:00:32 GMT, Kim Barrett wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8305590: Remove nothrow exception specifications from operator new
>
> src/hotspot/share/prims/jvmtiRawMonitor.hpp line
On Fri, 14 Apr 2023 13:27:37 GMT, Fredrik Bredberg wrote:
> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to
> expectedSystemTrace.
> Tested on my local machine.
This pull request has now been integrated.
Changeset: a31a11f4
Author:Fredrik Bredberg
Committer: Ala
On Wed, 19 Apr 2023 11:01:07 GMT, Jaikiran Pai wrote:
> Even if it doesn't get enrolled in the pre-submit testing, I think the fact
> that there will be a build within the JDK which can catch these issues is a
> good thing. It might catch the issue(s) after the integration, but I think
> it's
On Wed, 19 Apr 2023 13:22:54 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'master' into 8304915-arch-enum
>> - ArchTest on Debian RISC-V 64 confirmed by
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Wed, 19 Apr 2023 10:39:40 GMT, Alexey Pavlyutkin wrote:
> Hi! The patch fixes image/symbol lookup by jhsdb on alanysis Windows
> coredump. It uses executableName as a hint prepending image path with
>
> `;\server`
>
> and symbol path with
>
> `srv*https://msdl.microsoft.com/download/symbol
> This refactoring to separate ThreadStart/ThreadEnd events posting code in the
> JVMTI VTMS transitions is needed for future work on JVMTI scalability and
> performance improvements. It is to easier put this code on slow path.
>
> Testing: mach5 tiers 1-6 were successful.
Serguei Spitsyn has u
Moved three read-only InstanceKlass flags out of AccessFlags to
InstanceKlassFlags, and removed unused and unneeded SA code.
Tested with tier1-4.
-
Commit messages:
- 8306474: Move InstanceKlass read-only flags
Changes: https://git.openjdk.org/jdk/pull/13545/files
Webrev: https://
This enhancement adds support of virtual threads to the JVMTI `StopThread`
function.
In preview releases before this enhancement the StopThread returned the
JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
The `StopThread` supports sending an asynchronous exception to a virtual
On Wed, 19 Apr 2023 22:46:55 GMT, Coleen Phillimore wrote:
> Moved three read-only InstanceKlass flags out of AccessFlags to
> InstanceKlassFlags, and removed unused and unneeded SA code.
> Tested with tier1-4.
Reviewed. I like to see access flags being slowly emptied out. It was a
not-so-go
On Wed, 19 Apr 2023 23:27:10 GMT, John R Rose wrote:
>> Moved three read-only InstanceKlass flags out of AccessFlags to
>> InstanceKlassFlags, and removed unused and unneeded SA code.
>> Tested with tier1-4.
>
> src/hotspot/share/oops/instanceKlassFlags.hpp line 52:
>
>> 50: flag(is_shared_
On Wed, 19 Apr 2023 22:54:35 GMT, Serguei Spitsyn wrote:
> The JDB test `vmTestbase/nsk/jdb/kill/kill001/kill001.java` has been
> problem-listed and will be fixed by the corresponding debugger enhancement
> which is going to adopt JDWP/JDI specs to new behavior of the JVMTI
> `StopThread` rela
On Wed, 19 Apr 2023 23:51:53 GMT, Chris Plummer wrote:
> I'll be fixing this using
> [JDK-8306467](https://bugs.openjdk.org/browse/JDK-8306467),
> which will be done after the JDWP/JDI spec/impl update, which is being
> handled by
> [JDK-8306471](https://bugs.openjdk.org/browse/JDK-8306471).
T
On Wed, 19 Apr 2023 23:36:45 GMT, John R Rose wrote:
>> src/hotspot/share/oops/instanceKlassFlags.hpp line 52:
>>
>>> 50: flag(is_shared_app_class, 1 << 9) /* defining class
>>> loader is app class loader */ \
>>> 51: flag(has_contended_annotations , 1 << 10) /*
> Moved three read-only InstanceKlass flags out of AccessFlags to
> InstanceKlassFlags, and removed unused and unneeded SA code.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
John's suggestion
-
Please review this small change to remove Method AccessFlags that are unused.
These flags were moved to ConstMethod a long time ago.
Tested with tier1-4, SA tests locally
-
Commit messages:
- 8306482: Remove unused Method AccessFlags
Changes: https://git.openjdk.org/jdk/pull/13549
On Thu, 20 Apr 2023 00:27:20 GMT, Coleen Phillimore wrote:
>> Moved three read-only InstanceKlass flags out of AccessFlags to
>> InstanceKlassFlags, and removed unused and unneeded SA code.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one
> addit
On Thu, 20 Apr 2023 00:35:06 GMT, Coleen Phillimore wrote:
> Please review this small change to remove Method AccessFlags that are unused.
> These flags were moved to ConstMethod a long time ago.
> Tested with tier1-4, SA tests locally
Seems okay. Thanks.
-
Marked as reviewed by
On Wed, 19 Apr 2023 22:54:35 GMT, Serguei Spitsyn wrote:
> This enhancement adds support of virtual threads to the JVMTI `StopThread`
> function.
> In preview releases before this enhancement the StopThread returned the
> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>
> Th
On Wed, 19 Apr 2023 11:09:02 GMT, Markus Grönlund wrote:
> It follows the same pattern as for other jvmti*.cpp files also excluded via
> make/hotspot/lib/jvmFeatures.gmk. For example, jvmtiExport.cpp.
Okay , yes I see that now - I was thrown by the fact that the original versions
of these func
On Wed, 19 Apr 2023 10:39:40 GMT, Alexey Pavlyutkin wrote:
> Hi! The patch fixes image/symbol lookup by jhsdb on alanysis Windows
> coredump. It uses executableName as a hint prepending image path with
>
> `;\server`
>
> and symbol path with
>
> `srv*https://msdl.microsoft.com/download/symbol
On Wed, 19 Apr 2023 14:46:48 GMT, Afshin Zafari wrote:
>> src/hotspot/share/prims/jvmtiRawMonitor.hpp line 114:
>>
>>> 112:
>>> 113: // Non-aborting operator new
>>> 114: void* operator new(size_t size, const std::nothrow_t&
>>> nothrow_constant) throw() {
>>
>> Hm, now I'm wondering why
46 matches
Mail list logo
