On Wed, 19 Apr 2023 23:27:10 GMT, John R Rose <jr...@openjdk.org> wrote:
>> Moved three read-only InstanceKlass flags out of AccessFlags to >> InstanceKlassFlags, and removed unused and unneeded SA code. >> Tested with tier1-4. > > src/hotspot/share/oops/instanceKlassFlags.hpp line 52: > >> 50: flag(is_shared_app_class , 1 << 9) /* defining class >> loader is app class loader */ \ >> 51: flag(has_contended_annotations , 1 << 10) /* has @Contended >> annotation */ \ >> 52: flag(has_localvariable_table , 1 << 11) /* has >> localvariable information */ > > I suggest, as a matter of course, keeping the final `<newline>` at the end of > the list, and then adding something like `/*end of list*/` at the end. This > helps prevent churn on the final line, in such lists. That should be `<backslash><newline>`, in case it didn’t come through markdown. Removing the final backslash, like removing the final comma of an `enum`, causes churn. Adding a final comment also makes it easy to visually locate the end of the sequence; it is much clearer than the blank line required by the cpp macro mechanism. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13545#discussion_r1171944831
