On Wed, 19 Apr 2023 22:46:55 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> Moved three read-only InstanceKlass flags out of AccessFlags to > InstanceKlassFlags, and removed unused and unneeded SA code. > Tested with tier1-4. Reviewed. I like to see access flags being slowly emptied out. It was a not-so-good idea (in hindsight) to overload them. src/hotspot/share/oops/instanceKlassFlags.hpp line 52: > 50: flag(is_shared_app_class , 1 << 9) /* defining class > loader is app class loader */ \ > 51: flag(has_contended_annotations , 1 << 10) /* has @Contended > annotation */ \ > 52: flag(has_localvariable_table , 1 << 11) /* has > localvariable information */ I suggest, as a matter of course, keeping the final `<newline>` at the end of the list, and then adding something like `/*end of list*/` at the end. This helps prevent churn on the final line, in such lists. ------------- Marked as reviewed by jrose (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13545#pullrequestreview-1393009587 PR Review Comment: https://git.openjdk.org/jdk/pull/13545#discussion_r1171940561
