On Tue, 18 Apr 2023 16:59:29 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
> Greetings, > > For most platforms, os::dll_address_to_library_name() only sets offset = -1 > in case of errors. If there is an error, the function returns false. This is > fine. > > On AIX, the offset, being optional, is invariantly set to -1, even in the > case of non-errors. > > Easiest to remove the assertion for a positive offset. > > Thanks > Markus Thanks, looks good to me. One of my colleague has an idea to improve os::dll_address_to_library_name on AIX to support the offsets but this is something for the future so still good to have your fix. ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13513#pullrequestreview-1391391403
