On Thu, 3 Jul 2025 17:08:44 GMT, Calvin Cheung wrote:
>> src/hotspot/share/cds/classListParser.cpp line 33:
>>
>>> 31: #include "cds/metaspaceShared.hpp"
>>> 32: #include "cds/unregisteredClasses.hpp"
>>> 33: #include "classfile/classLoader.hpp"
>>
>> Nit: I wonder if the line #33 is really nee
On Thu, 3 Jul 2025 17:26:43 GMT, Coleen Phillimore wrote:
>>> It looks good to me. I like this simplification. But I'm curious what was
>>> the original reason to have the `classLoaderExt`?
>>
>> I think it was created during the first revision of AppCDS back in JDK 8u.
>
>> It looks good to me
On Thu, 3 Jul 2025 17:10:03 GMT, Calvin Cheung wrote:
> It looks good to me. I like this simplification. But I'm curious what was the
> original reason to have the classLoaderExt?
I think it was from before we settled on the Shared suffix for CDS methods.
-
PR Comment: https://git
On Thu, 3 Jul 2025 17:12:55 GMT, Calvin Cheung wrote:
>> After the refactoring work done via
>> [JDK-8280682](https://bugs.openjdk.org/browse/JDK-8280682), there are only
>> three functions remaining in the ClassLoaderExt class. This RFE is to move
>> those remaining functions into other class
> After the refactoring work done via
> [JDK-8280682](https://bugs.openjdk.org/browse/JDK-8280682), there are only
> three functions remaining in the ClassLoaderExt class. This RFE is to move
> those remaining functions into other classes so that the ClassLoaderExt class
> can be eliminated.
>
On Thu, 3 Jul 2025 15:10:12 GMT, Serguei Spitsyn wrote:
> It looks good to me. I like this simplification. But I'm curious what was the
> original reason to have the `classLoaderExt`?
I think it was created during the first revision of AppCDS back in JDK 8u.
> src/hotspot/share/cds/classListPa
On Thu, 3 Jul 2025 12:56:44 GMT, Coleen Phillimore wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @coleenp comment
>
> src/hotspot/share/classfile/modules.cpp line 671:
>
>> 669: // list[3] = ""
>> 670: // l
On Thu, 3 Jul 2025 05:16:54 GMT, Calvin Cheung wrote:
> After the refactoring work done via
> [JDK-8280682](https://bugs.openjdk.org/browse/JDK-8280682), there are only
> three functions remaining in the ClassLoaderExt class. This RFE is to move
> those remaining functions into other classes s
On Thu, 3 Jul 2025 05:16:54 GMT, Calvin Cheung wrote:
> After the refactoring work done via
> [JDK-8280682](https://bugs.openjdk.org/browse/JDK-8280682), there are only
> three functions remaining in the ClassLoaderExt class. This RFE is to move
> those remaining functions into other classes s
