On Mon, 13 Jan 2025 15:49:15 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>
On Mon, 13 Jan 2025 15:49:15 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>
On Mon, 13 Jan 2025 15:49:15 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>
On Mon, 13 Jan 2025 15:49:15 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> should backport fine. This was mostly done with a sed script p
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
On Sat, 4 Jan 2025 09:41:29 GMT, Kim Barrett wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix %Ix to %zx.
>
> src/hotspot/share/oops/klass.cpp line 1308:
>
>> 1306: if (secondary_supers() != nullptr) {
>
On Thu, 9 Jan 2025 21:47:47 GMT, Matias Saavedra Silva
wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore copyright and macro.
>
> src/hotspot/share/runtime/objectMonitor.cpp line 2500:
>
>> 2498: //
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
On Tue, 7 Jan 2025 08:32:27 GMT, Kim Barrett wrote:
>> This is a relic and not the legal copyright that got updated since nobody
>> noticed. Until you did. Removed.
>
> Not sure we're allowed to remove a copyright statement, even if not in the
> usual place.
put copyright back.
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> should backport fine. This was mostly done with a sed script p
On Tue, 7 Jan 2025 08:48:08 GMT, Kim Barrett wrote:
>> I don't think we should be mixing uintx types and UINTPTR_FORMAT like that.
>> As I said earlier, this is one that
>> I think probably ought not be changed at all. I think some of the FORMAT
>> macros are useful to avoid inline
>> format
On Tue, 7 Jan 2025 08:50:04 GMT, Kim Barrett wrote:
>> I'd forgotten about that format option too, which is why I'm not enamored of
>> it. Also, written that way the
>> prefix gets included in the width when dealing with field width, which might
>> not be great either.
>
> The problem of accou
On Tue, 7 Jan 2025 08:31:13 GMT, Kim Barrett wrote:
>> I fixed this. This seems ok. I didn't know about this format option tbh
>> but if it's standard, why not?
>
> I'd forgotten about that format option too, which is why I'm not enamored of
> it. Also, written that way the
> prefix gets inc
On Tue, 7 Jan 2025 08:28:32 GMT, Kim Barrett wrote:
>> @theRealAph added this with the secondary super cache work, but I think it
>> may have also been meant to be zx because of the leading 0x. So
>> INTPTR_FORMAT would also work.
>
> I don't think we should be mixing uintx types and UINTPTR_F
On Mon, 6 Jan 2025 15:04:19 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/gc/shared/ageTable.cpp line 38:
>>
>>> 36: #include "logging/logStream.hpp"
>>> 37:
>>> 38: /* Copyright (c) 1992, 2025, Oracle and/or its affiliates, and Stanford
>>> University.
>>
>> Well this is weird. An atyp
On Mon, 6 Jan 2025 15:21:14 GMT, Coleen Phillimore wrote:
>> I have to confess that I have no idea what this is trying to show. I'd
>> rather have all the UINTX_FORMAT purged and not leave a remnant for these
>> two special cases. A function whose name describes what this is trying to
>> sho
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> should backport fine. This was mostly done with a sed script p
On Sat, 4 Jan 2025 09:52:00 GMT, Kim Barrett wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix %Ix to %zx.
>
> test/hotspot/gtest/utilities/test_globalDefinitions.cpp line 281:
>
>> 279:
>> 280: check_fo
On Mon, 6 Jan 2025 15:03:34 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/instanceKlass.cpp line 3695:
>>
>>> 3693:
>>> 3694: st->print(BULLET"hash_slot: %d", hash_slot()); st->cr();
>>> 3695: st->print(BULLET"secondary bitmap: " LP64_ONLY("0x%016zu")
>>> NOT_LP64("0x%08z
On Sat, 4 Jan 2025 09:02:34 GMT, Kim Barrett wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix %Ix to %zx.
>
> src/hotspot/os/linux/os_linux.cpp line 1370:
>
>> 1368:
>> 1369: #define _UFM "%zu"
>> 1370: #
On Fri, 3 Jan 2025 16:23:31 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> should backport fine. This was mostly done with a sed script p
On Fri, 3 Jan 2025 16:23:31 GMT, Coleen Phillimore wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>>
On Fri, 3 Jan 2025 14:32:39 GMT, Coleen Phillimore wrote:
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> sho
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> should backport fine. This was mostly done with a sed script p
On Fri, 3 Jan 2025 14:32:39 GMT, Coleen Phillimore wrote:
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> sho
31 matches
Mail list logo
