On Mon, 6 Jan 2025 15:04:19 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> src/hotspot/share/gc/shared/ageTable.cpp line 38:
>>
>>> 36: #include "logging/logStream.hpp"
>>> 37:
>>> 38: /* Copyright (c) 1992, 2025, Oracle and/or its affiliates, and Stanford
>>> University.
>>
>> Well this is weird. An atypical copyright down inside the file?
>
> This is a relic and not the legal copyright that got updated since nobody
> noticed. Until you did. Removed.
Not sure we're allowed to remove a copyright statement, even if not in the
usual place.
>> test/hotspot/gtest/utilities/test_globalDefinitions.cpp line 281:
>>
>>> 279:
>>> 280: check_format("%zd", (intx)123, "123");
>>> 281: check_format("0x%zx", (intx)0x123, "0x123");
>>
>> Could be "%#zx".
>
> I fixed this. This seems ok. I didn't know about this format option tbh but
> if it's standard, why not?
I'd forgotten about that format option too, which is why I'm not enamored of
it. Also, written that way the
prefix gets included in the width when dealing with field width, which might
not be great either.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22916#discussion_r1905081061
PR Review Comment: https://git.openjdk.org/jdk/pull/22916#discussion_r1905079637
