On Tue, 7 Jan 2025 12:51:33 GMT, Coleen Phillimore <[email protected]> wrote:
>> There are a lot of format modifiers that are noisy and unnecessary in the
>> code. This change removes the INTX variants. It's not that disruptive even
>> for backporting because %z modifier has been available for a long time so
>> should backport fine. This was mostly done with a sed script plus some hand
>> fixups.
>>
>> Testing mach5 and other platform cross compilations in progress. Opening
>> this for GHA testing.
>
> Coleen Phillimore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restore copyright and macro.
Looks good! I saw the discussion on `UINTPTR_FORMAT_X_0` so I left it alone.
src/hotspot/share/runtime/objectMonitor.cpp line 2500:
> 2498: // The minimal things to print for markWord printing, more can be
> added for debugging and logging.
> 2499: st->print("{contentions=0x%08x,waiters=0x%08x"
> 2500: ",recursions=%zd,owner=" INT64_FORMAT "}",
Is `INT64_FORMAT` different from `INTX_FORMAT`?
-------------
Marked as reviewed by matsaave (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22916#pullrequestreview-2540981143
PR Review Comment: https://git.openjdk.org/jdk/pull/22916#discussion_r1909469703
