On Thu, 20 Mar 2025 12:38:37 GMT, Magnus Ihse Bursie wrote:
> Is there any gain then in changing away from -lpthread? That is clearly
> defined, link with libpthread, with no side effects. "If it ain't broke..."
True - what we have works and using `-pthread` might subtly change things.
---
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote:
>> @magicus why can't we just use `-pthread` everywhere? My recollection is
>> that `-pthread` both sets compiler directives needed for pthread programming
>> and links to libpthread, so it seems to be what we should be using. ??
>
>> Anothe
On Mon, 17 Mar 2025 10:44:30 GMT, snake66 wrote:
>>> Another follow-up is if it would hurt to include $LIBPTHREAD for _all_
>>> Hotspot tests, to avoid the huge list. @dholmes-ora Do you have anything
>>> coming to mind directly that would make that infeasible, or is it just a
>>> matter of te
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote:
>> @magicus why can't we just use `-pthread` everywhere? My recollection is
>> that `-pthread` both sets compiler directives needed for pthread programming
>> and links to libpthread, so it seems to be what we should be using. ??
>
>> Anothe
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote:
>>> What is the intended way of using this? Do you run make with
>>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the
>>> specific way of linking to pthread?
>>
>> This is in preparation of the upcoming BSD port, which use
On Thu, 6 Mar 2025 12:46:25 GMT, David Holmes wrote:
> Abstracting this out seems reasonable to me, though I should say I thought we
> already used `-pthread` rather than `-lpthread`.
I noticed there were a few places that used `-pthread` by default. I left these
alone in this PR.
---
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote:
>>> What is the intended way of using this? Do you run make with
>>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the
>>> specific way of linking to pthread?
>>
>> This is in preparation of the upcoming BSD port, which use
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
On Thu, 6 Mar 2025 13:27:15 GMT, snake66 wrote:
>> Abstracting this out seems reasonable to me, though I should say I thought
>> we already used `-pthread` rather than `-lpthread`.
>>
>> Needs build team approval before integrating.
>
>> Abstracting this out seems reasonable to me, though I sho
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in [1], but
> generalized for the full JDK, and set
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote:
>>> What is the intended way of using this? Do you run make with
>>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the
>>> specific way of linking to pthread?
>>
>> This is in preparation of the upcoming BSD port, which use
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
On Thu, 6 Mar 2025 15:47:58 GMT, Magnus Ihse Bursie wrote:
>> What is the intended way of using this? Do you run make with
>> `LIBPTHREAD=-pthread` or do you apply a patch on `libraries.m4` for the
>> specific way of linking to pthread?
>
>> What is the intended way of using this? Do you run ma
On Thu, 6 Mar 2025 15:56:43 GMT, Magnus Ihse Bursie wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done
On Thu, 6 Mar 2025 17:28:10 GMT, snake66 wrote:
>> make/autoconf/libraries.m4 line 142:
>>
>>> 140: # Threading library
>>> 141: if test "x$OPENJDK_TARGET_OS" = xlinux || test "x$OPENJDK_TARGET_OS"
>>> = xaix; then
>>> 142: BASIC_JVM_LIBS="$BASIC_JVM_LIBS $(LIBPTHREAD)"
>>
>> If you sp
On Thu, 6 Mar 2025 14:15:38 GMT, Erik Joelsson wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Gr
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Thu, 6 Mar 2025 14:21:08 GMT, Erik Joelsson wrote:
> What is the intended way of using this? Do you run make with
> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the specific
> way of linking to pthread?
This is in preparation of the upcoming BSD port, which uses `-pthread
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
possible to parameterize this for platforms that use different flags for
enabling posix threads.
This work is a continuation of the work done by Greg Lewis in [1], but
generalized for the full JDK, and set at the conf
25 matches
Mail list logo
