On Thu, 6 Mar 2025 15:56:43 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lewis in [1], but >> generalized for the full JDK, and set at the configure stage. >> >> Sponsored by: The FreeBSD Foundation >> Co-authored-by: Greg Lewis <gle...@eyesbeyond.com> >> >> [1]: >> https://github.com/battleblow/jdk23u/commit/dbd90aa8ab0b7f5e4865864a7c63d975daacabf4 > > make/Hsdis.gmk line 131: > >> 129: HSDIS_TOOLCHAIN_LIBS := $(MINGW_DLLCRT) -lmingw32 -lgcc -lgcc_eh >> -lmoldname \ >> 130: -lmingwex -lmsvcrt $(LIBPTHREAD) -ladvapi32 -lshell32 -luser32 >> -lkernel32 >> 131: else > > The hsdis build is very weird and outside the normal integrated JDK build. I > recommend you leave this instance alone. If you want to port hsdis to BSD you > are likely to have to rewrite large parts of the compilation logic here > anyway. Ack, I'll drop that one from the patch. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23930#discussion_r1983780437
