On Sat, 7 Sep 2024 01:48:39 GMT, Yasumasa Suenaga wrote:
>> This PR is successor of #20789 . I got some comments in there, then I needed
>> to fix in many pooints. And also I have to fix branch name to kick GHA
>> automatically (#20789 is named with `pr/`, it meets the condition to skip
>> GHA
On Sat, 7 Sep 2024 01:04:14 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update test/hotspot/jtreg/serviceability/sa/libupcall.c
>>
>>Co-authored-by: Jorn Vernee
>> - Update
>
> This PR is successor of #20789 . I got some comments in there, then I needed
> to fix in many pooints. And also I have to fix branch name to kick GHA
> automatically (#20789 is named with `pr/`, it meets the condition to skip
> GHA). Hence I've opened another PR for this JBS issue.
>
> This P
On Fri, 6 Sep 2024 15:29:18 GMT, Jorn Vernee wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove blank lines
>
> Looks great! Thanks for implementing the JFA-based stack walking.
>
> Please wait for another
On Sat, 7 Sep 2024 00:07:27 GMT, Yasumasa Suenaga wrote:
>> This PR is successor of #20789 . I got some comments in there, then I needed
>> to fix in many pooints. And also I have to fix branch name to kick GHA
>> automatically (#20789 is named with `pr/`, it meets the condition to skip
>> GHA
> This PR is successor of #20789 . I got some comments in there, then I needed
> to fix in many pooints. And also I have to fix branch name to kick GHA
> automatically (#20789 is named with `pr/`, it meets the condition to skip
> GHA). Hence I've opened another PR for this JBS issue.
>
> This P
On Fri, 6 Sep 2024 09:31:45 GMT, Yasumasa Suenaga wrote:
> This PR is successor of #20789 . I got some comments in there, then I needed
> to fix in many pooints. And also I have to fix branch name to kick GHA
> automatically (#20789 is named with `pr/`, it meets the condition to skip
> GHA). H
On Mon, 2 Sep 2024 10:29:40 GMT, Yasumasa Suenaga wrote:
>> I attempted to check stack trace in the core generated by [SEGV example in
>> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativeseg
This PR is successor of #20789 . I got some comments in there, then I needed to
fix in many pooints. And also I have to fix branch name to kick GHA
automatically (#20789 is named with `pr/`, it meets the condition to skip GHA).
Hence I've opened another PR for this JBS issue.
This PR has been u
On Wed, 4 Sep 2024 00:33:06 GMT, Yasumasa Suenaga wrote:
>> test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackUpcall.java line 57:
>>
>>> 55:
>>> 56: private static void runJstackInLoop(LingeredApp app) throws
>>> Exception {
>>> 57: for (int i = 0; i < MAX_ITERATIONS; i++) {
>>
On Mon, 2 Sep 2024 15:13:44 GMT, Jorn Vernee wrote:
>>> I understand that adding the UpcallStub type to the SA agent code makes the
>>> WrongTypeException go away, and then we run into an assertion failure
>>> because the frame size is zero?
>>
>> Yes.
>>
>>> Note how there is also special ha
On Tue, 3 Sep 2024 19:39:59 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update test/hotspot/jtreg/serviceability/sa/LingeredAppWithFFMUpcall.java
>>
>>Co-authored-by: Andrey T
On Mon, 2 Sep 2024 10:29:40 GMT, Yasumasa Suenaga wrote:
>> I attempted to check stack trace in the core generated by [SEGV example in
>> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativeseg
On Mon, 2 Sep 2024 14:50:10 GMT, Yasumasa Suenaga wrote:
> > Note how there is also special handling for (JNI) entry frames in the SA.
>
> Do you mean `JavaCallWrapper` (`X86Frame::senderForEntryFrame` in SA) ?
Yes. Internally it loads the fields of `JavaFrameAnchor`, which points at the
previ
On Mon, 2 Sep 2024 11:59:01 GMT, Jorn Vernee wrote:
> I understand that adding the UpcallStub type to the SA agent code makes the
> WrongTypeException go away, and then we run into an assertion failure because
> the frame size is zero?
Yes.
> Note how there is also special handling for (JNI)
On Mon, 2 Sep 2024 10:29:40 GMT, Yasumasa Suenaga wrote:
>> I attempted to check stack trace in the core generated by [SEGV example in
>> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativeseg
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv/upcall/Main.java)
> with `jhsdb jstack`, however it failed
On Sat, 31 Aug 2024 09:34:09 GMT, Yasumasa Suenaga wrote:
>> I attempted to check stack trace in the core generated by [SEGV example in
>> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativese
On Sat, 31 Aug 2024 12:25:49 GMT, Yasumasa Suenaga wrote:
>> src/hotspot/cpu/x86/upcallLinker_x86_64.cpp line 397:
>>
>>> 395: * and also should include both saved FP and
>>> return address
>>> 396: */
>>> 397: (frame_
On Sat, 31 Aug 2024 06:52:56 GMT, Fei Yang wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add testcase
>> - Remove unnecessary comment from UpcallStub
>
> src/hotspot/cpu/x86/upcallLinker_x86_64.cpp line 39
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv/upcall/Main.java)
> with `jhsdb jstack`, however it failed
On Sat, 31 Aug 2024 04:21:17 GMT, Yasumasa Suenaga wrote:
>> I attempted to check stack trace in the core generated by [SEGV example in
>> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativese
On Fri, 30 Aug 2024 20:28:11 GMT, Chris Plummer wrote:
> Thanks for fixing this. The SA changes look fine. You'll need an FFM expert
> for the hotspot changes.
Thank you!
> Is it possible to provide a test case? Maybe make a call into some blocking
> native API and then run jstack on the proc
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv/upcall/Main.java)
> with `jhsdb jstack`, however it failed
On Fri, 30 Aug 2024 09:14:11 GMT, Yasumasa Suenaga wrote:
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv
On Fri, 30 Aug 2024 09:14:11 GMT, Yasumasa Suenaga wrote:
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv
On Fri, 30 Aug 2024 09:14:11 GMT, Yasumasa Suenaga wrote:
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv
I attempted to check stack trace in the core generated by [SEGV example in
upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv/upcall/Main.java)
with `jhsdb jstack`, however it failed with
28 matches
Mail list logo
