Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v3]

2024-11-11 Thread Y . Srinivas Ramakrishna
On Tue, 22 Oct 2024 17:12:38 GMT, Zhengyu Gu wrote: >> Congratulations! Good to see the great progress. I just built this PR for >> some testing and found something unexpected. I ran the genshen VS >> shenandoah(default) with jbb2015 on aarch64 N2 with 8 cores and Xmx8g. The >> critical-jOPS o

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v3]

2024-10-22 Thread Zhengyu Gu
On Wed, 9 Oct 2024 03:26:30 GMT, Liang Mao wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-redux

Re: RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v3]

2024-10-22 Thread William Kemper
On Wed, 9 Oct 2024 03:26:30 GMT, Liang Mao wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-redux

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-17 Thread William Kemper
On Fri, 11 Oct 2024 21:21:57 GMT, William Kemper wrote: >> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 396: >> >>> 394: } >>> 395: >>> 396: inline bool ShenandoahHeap::is_old(oop obj) const { >> >> What is the difference between this method and the above is_in_old()? Why >>

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-15 Thread William Kemper
On Fri, 11 Oct 2024 13:43:46 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-15 Thread William Kemper
On Fri, 11 Oct 2024 22:12:25 GMT, Y. Srinivas Ramakrishna wrote: >> src/hotspot/share/gc/shenandoah/shenandoahCardStats.hpp line 40: >> >>> 38: DIRTY_SCAN_OBJS = 6, >>> 39: ALTERNATIONS= 7, >>> 40: MAX_CARD_STAT_TYPE = 8 >> >> Are the numerical values relevant or what is the

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-15 Thread William Kemper
On Thu, 10 Oct 2024 12:58:56 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-14 Thread Roman Kennke
On Fri, 11 Oct 2024 22:00:55 GMT, William Kemper wrote: >> src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp line 75: >> >>> 73: >>> 74: // Create a mask to test if the marking bit is set. >>> 75: // TODO: can we directly test if bit is set? >> >> That comment here is quite jus

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Thu, 10 Oct 2024 18:47:38 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread Y . Srinivas Ramakrishna
On Thu, 10 Oct 2024 18:07:27 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Thu, 10 Oct 2024 12:48:05 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Fri, 11 Oct 2024 21:20:55 GMT, William Kemper wrote: >> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 535: >> >>> 533: ShenandoahPacer* pacer() const { return >>> _pacer; } >>> 534: >>> 535: ShenandoahPhaseTimings* phase_timings() const

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Thu, 10 Oct 2024 17:44:03 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Fri, 11 Oct 2024 11:01:54 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Fri, 11 Oct 2024 10:14:31 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Thu, 10 Oct 2024 13:14:15 GMT, Roman Kennke wrote: >> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp line 79: >> >>> 77: >>> 78: protected: >>> 79: static const uint Moving_Average_Samples = 10; // Number of samples >>> to store in moving averages >> >> I've never se

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread William Kemper
On Fri, 11 Oct 2024 15:13:07 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread Roman Kennke
On Tue, 8 Oct 2024 17:20:31 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull request

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-11 Thread Roman Kennke
On Tue, 8 Oct 2024 17:20:31 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull request

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-10 Thread Roman Kennke
On Tue, 8 Oct 2024 17:20:31 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull request

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-10 Thread Roman Kennke
On Thu, 10 Oct 2024 13:13:14 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-10 Thread Roman Kennke
On Tue, 8 Oct 2024 17:20:31 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull request

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-08 Thread Liang Mao
On Tue, 8 Oct 2024 17:20:31 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull request

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-08 Thread William Kemper
> This PR merges JEP 404, a generational mode for the Shenandoah garbage > collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would > like to target JDK24 with this PR. William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull r