On Tue, 17 Jan 2023 08:57:35 GMT, Fredrik Bredberg wrote:
> Hi @bulasevich, can you verify that this PR works on Arm32?
ARM32 part LGTM. Test results are fine.
Thanks!
-
PR: https://git.openjdk.org/jdk/pull/11902
On Tue, 17 Jan 2023 17:34:53 GMT, Andrew Haley wrote:
>> Fredrik Bredberg has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> com
On Thu, 19 Jan 2023 09:13:42 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Thu, 19 Jan 2023 09:13:42 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 17 Jan 2023 13:33:34 GMT, Martin Doerr wrote:
>>> Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>> > Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>
On Tue, 17 Jan 2023 13:33:34 GMT, Martin Doerr wrote:
>>> Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>> > Works on PPC64. Thanks! Tests have passed on other platforms as well.
>>
>> Does "other platforms" include S390?
>
>
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on supported platforms. The rest was sanity tested using
> Q
On Wed, 18 Jan 2023 15:46:22 GMT, Fredrik Bredberg wrote:
>> The code uses &sp()[R12_scratch2]. I think your comment is confusing. Please
>> remove it or write something comprehensive. E.g. save R18_locals in
>> compressed format relative to the new top frame's FP (= current SP).
>
> See what y
On Wed, 18 Jan 2023 05:07:38 GMT, Martin Doerr wrote:
>> My intention was to show how the contents of R18_locals (the absolute
>> address to locals) can be recreated by using R12_scratch2 as an index from
>> the frame pointer. Before we stored R18_locals in the stackframe, now we
>> store R12_
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 17 Jan 2023 17:34:53 GMT, Andrew Haley wrote:
> > Implementation of relativized locals in interpreter frames for x86. x64,
> > arm, aarch64, ppc64le and riscv. Not relativized locals on zero and s390
> > but done some changes to cope with the changed generic code. Tested
> > tier1-tier
On Tue, 17 Jan 2023 17:02:04 GMT, Fredrik Bredberg wrote:
>> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 1035:
>>
>>> 1033: __ sub(R12_scratch2, R18_locals, R1_SP);
>>> 1034: __ srdi(R12_scratch2, R12_scratch2,
>>> Interpreter::logStackElementSize);
>>> 1035: // Now &fp(
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 17 Jan 2023 13:32:47 GMT, Martin Doerr wrote:
>> Fredrik Bredberg has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> com
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 17 Jan 2023 08:40:18 GMT, Fredrik Bredberg wrote:
> > Works on PPC64. Thanks! Tests have passed on other platforms as well.
>
> Does "other platforms" include S390?
No, @backwaterred you may want to check.
-
PR: https://git.openjdk.org/jdk/pull/11902
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 10 Jan 2023 15:14:34 GMT, Martin Doerr wrote:
> Works on PPC64. Thanks! Tests have passed on other platforms as well.
Does "other platforms" include S390?
-
PR: https://git.openjdk.org/jdk/pull/11902
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on supported platforms. The rest was sanity tested using
> Q
On Fri, 13 Jan 2023 16:47:59 GMT, Coleen Phillimore wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated some copyright dates.
>
> src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp line 306:
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on supported platforms. The rest was sanity tested using
> Q
On Wed, 11 Jan 2023 09:22:03 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Wed, 11 Jan 2023 09:22:03 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 10 Jan 2023 14:47:45 GMT, Fredrik Bredberg wrote:
>> src/hotspot/cpu/aarch64/continuationHelper_aarch64.inline.hpp line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
>>
>> Note, you changed the initial year. Should be:
>>
>> - * Copyri
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on supported platforms. The rest was sanity tested using
> Q
On Mon, 9 Jan 2023 10:30:06 GMT, Fredrik Bredberg wrote:
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on
On Tue, 10 Jan 2023 14:38:32 GMT, Axel Boldt-Christmas
wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tie
On Mon, 9 Jan 2023 10:30:06 GMT, Fredrik Bredberg wrote:
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on
Implementation of relativized locals in interpreter frames for x86. x64,
aarch64, ppc64le, riscv.
Not relativized zero and s390 but done some changes to cope with the changed
generic code.
Tested tier1-tier8 on supported platforms. The rest was sanity tested using
Qemu.
-
Commit me
31 matches
Mail list logo
