On Fri, 25 Oct 2024 06:49:48 GMT, Stefan Karlsson wrote:
>> When testing Lilliput we found a failure in
>> `serviceability/sa/ClhsdbJstackWithConcurrentLock.java` test when running
>> with C1-only.
>>
>> The test uses the SA's thread printing feature to print the threads *and*
>> the "concurr
> When testing Lilliput we found a failure in
> `serviceability/sa/ClhsdbJstackWithConcurrentLock.java` test when running
> with C1-only.
>
> The test uses the SA's thread printing feature to print the threads *and* the
> "concurrent locks" / AbstractOwnableSynchronizers. It then verifies that
On Thu, 24 Oct 2024 19:09:42 GMT, Stefan Karlsson wrote:
>> When testing Lilliput we found a failure in
>> `serviceability/sa/ClhsdbJstackWithConcurrentLock.java` test when running
>> with C1-only.
>>
>> The test uses the SA's thread printing feature to print the threads *and*
>> the "concurr
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 18:58:03 GMT, Hamlin Li wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Conditionalize platform specific parts of
>> CompressedClassPointersEncodingScheme test
>
> test/hotspot/jtreg/runtime/Co
On Thu, 24 Oct 2024 17:27:33 GMT, Alexey Ivanov wrote:
> > I think we have finally decided that jtreg tag will come after copyright
> > and before imports...Applicable for all modified javax_swing tests in this
> > PR...
>
> Did we agree on that?
Atleast client-dev team did..
See this initial
On Thu, 24 Oct 2024 21:08:26 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 24 Oct 2024 06:18:10 GMT, David Holmes wrote:
>> So the value stored in _owner has to be ANONYMOUS_OWNER. We cannot store the
>> BasicLock* in there as before since it can clash with some other thread's
>> tid. We store it in the new field _stack_locker instead.
>
> Right I understand w
> When testing Lilliput we found a failure in
> `serviceability/sa/ClhsdbJstackWithConcurrentLock.java` test when running
> with C1-only.
>
> The test uses the SA's thread printing feature to print the threads *and* the
> "concurrent locks" / AbstractOwnableSynchronizers. It then verifies that
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
On Thu, 24 Oct 2024 21:08:26 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 18:58:26 GMT, Alex Menkov wrote:
>> The fix improves Attch API protocol and implements updated protocol on
>> windows; shared code is ready to implement updated protocol support on other
>> platforms.
>> More detailed explanations on the 1st comment.
>>
>> Testing: tier1,ti
On Thu, 24 Oct 2024 18:58:26 GMT, Alex Menkov wrote:
>> The fix improves Attch API protocol and implements updated protocol on
>> windows; shared code is ready to implement updated protocol support on other
>> platforms.
>> More detailed explanations on the 1st comment.
>>
>> Testing: tier1,ti
On Thu, 24 Oct 2024 14:52:27 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Thu, 24 Oct 2024 02:55:18 GMT, David Holmes wrote:
>>> Also JavaThread::_lock_id in the VM means "the java.lang.Thread thread-id
>>> to use for locking" - correct?
>>>
>> Yes.
>
> I guess I don't understand where this piece code fits in the overall
> transition of the virtual thread to being
On Thu, 24 Oct 2024 16:11:18 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 16:35:44 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 08:26:12 GMT, Alan Bateman wrote:
>> So really UNBLOCKED is UNBLOCKING and mirrors BLOCKING , so we have:
>>
>> RUNNING -> BLOCKING -> BLOCKED
>> BLOCKED -> UNBLOCKING -> RUNNABLE
>>
>> I'm just trying to get a better sense of what we can infer if we see these
>> "transitio
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Thu, 24 Oct 2024 05:10:56 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix comment in objectMonitor.hpp and javaThread.hpp
>> - Skip printing tid when not available
>
> src/hots
On Thu, 24 Oct 2024 02:57:18 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/Virt
> The fix improves Attch API protocol and implements updated protocol on
> windows; shared code is ready to implement updated protocol support on other
> platforms.
> More detailed explanations on the 1st comment.
>
> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
> manually tested backward com
On Thu, 24 Oct 2024 20:23:26 GMT, Alexey Ivanov wrote:
>> @aivanov-jdk
>> It was missed when -Djava.security.manager=allow was removed.
>> Out of curiosity: does it have any impact on the performance of CI testing
>> if tests are run in `/othervm` mode when it is not needed?
>
>> It was missed
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 18:09:04 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>>
>>> 711: * {@code Info.plist}.
>>> 712: *
>>> 713: * @param printFileHandler handler
>>
>> Suggestion:
>>
>> * @param printFileHandler handler
>>
On Thu, 24 Oct 2024 17:58:55 GMT, Harshitha Onkar wrote:
> It was missed when `-Djava.security.manager=allow` was removed.
It wasn't intentional then, was it?
> Out of curiosity: does it have any impact on the performance of CI testing if
> tests are run in /othervm mode when it is not needed?
On Thu, 24 Oct 2024 18:14:25 GMT, Chris Plummer wrote:
>> `getSizet()` seems to be a function in `Flags`, so I don't see a direct way
>> to use it. I could probably use the `sizetType` instead of
>> `db.lookupType("size_t")`, however when I tested the tests failed because
>> sizetType had not
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 12:37:24 GMT, Kevin Walls wrote:
>> Alex Menkov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - updated comment
>> - feedback
>
> src/hotspot/share/services/attachListener.cpp line 406:
>
>> 404: { "printflag",
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Wed, 23 Oct 2024 17:26:15 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 03:38:21 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 11:58:26 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/invoke/RevealDirectTest.java line 33:
>>
>>> 31: * @test
>>> 32: * @summary verify Lookup.revealDirect on a variety of input handles,
>>> with security manager
>>> 33: * @run
>>> main/othervm/policy=jtreg.security.p
On Wed, 23 Oct 2024 02:56:30 GMT, Prasanta Sadhukhan
wrote:
>> Agreed. This is not a "clean up / update tests" task.
>> If it is a change on some lines of code that are updated by the SM changes,
>> then that's fair game, but otherwise only the SM behaviour is part of this
>> task.
>> Anything
On Wed, 23 Oct 2024 04:46:51 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Thu, 24 Oct 2024 07:11:16 GMT, David Holmes wrote:
> > the way I did it I'd have to force push
>
> That should not be the case. You can just anti-delta changes.
I did it in a really inefficient way, by checking out all files except for the
files that I wanted to stay. I could not figure out
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unused warnings and addressed all of them by commenting out th
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
On Tue, 15 Oct 2024 22:31:46 GMT, Alex Menkov wrote:
>> The fix improves Attch API protocol and implements updated protocol on
>> windows; shared code is ready to implement updated protocol support on other
>> platforms.
>> More detailed explanations on the 1st comment.
>>
>> Testing: tier1,ti
On Tue, 15 Oct 2024 22:31:46 GMT, Alex Menkov wrote:
>> The fix improves Attch API protocol and implements updated protocol on
>> windows; shared code is ready to implement updated protocol support on other
>> platforms.
>> More detailed explanations on the 1st comment.
>>
>> Testing: tier1,ti
On Thu, 24 Oct 2024 11:39:33 GMT, Jaikiran Pai wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix copyright header
>
> src/java.xml/share/classes/javax/xml/validation/SchemaFactoryConfigurationError.java
> li
On Wed, 23 Oct 2024 19:48:13 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "Remove redundant db.lookupType"
>>
>> This reverts commit e8ec2957d43730560c73e2ea9b3ec7a91fc25535.
>
> Please review a doc-only change to fix the order of javadoc @param tags in in
> various OpenJDK modules. This is the third and last PR to fix the order of
> @param tags in OpenJDK libraries.
>
> We are working on a javadoc feature to add an opt-in doclint warning for
> @param tags that don't
On Tue, 22 Oct 2024 13:36:43 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc @param tags in in
> various OpenJDK modules. This is the third and last PR to fix the order of
> @param tags in OpenJDK libraries.
>
> We are working on a javadoc feature to
On Tue, 22 Oct 2024 16:22:20 GMT, Roman Kennke wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright
>> - Avoid assert/endless-loop in JFR code
>
> @egahlin / @mgronlun could you please review the JFR
On Thu, 24 Oct 2024 07:15:53 GMT, Alan Bateman wrote:
>> but you won't see access_controller_klass or priviledged_action_klass
>> frames, so no need to skip them? Not sure why you'd want to skip class
>> loader frames here.
>
> Right, although you might have to wait until there is more cleanup
On Thu, 24 Oct 2024 03:38:21 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 09:54:05 GMT, Martin Doerr wrote:
> As I understand the comment, it says alignment <= cache line size. But the
> implementation makes alignment >= cache line size. "hyper alignment" means
> alignment > cache line size?
Correct. since encoding range must cover the full klass
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 09:28:13 GMT, Amit Kumar wrote:
>>> But then, what exactly is the error? If it's just the test assuming that
>>> cache line size is log 6, then the test should be fixed for ppc, not
>>> hotspot.
>>
>> that is the problem, test assumes log2 of 6 for chacheline size
>
> PPC l
On Thu, 24 Oct 2024 09:22:34 GMT, Thomas Stuefe wrote:
>>> This code causes test errors in
>>> `CompressedClassPointersEncodingScheme.java` on s390 and PPC64. It forces
>>> the shift to `log_cacheline` which is 7 on PPC64 and 9 on s390. The test
>>> passes when we remove "s > log_cacheline &&
On Thu, 24 Oct 2024 09:12:34 GMT, Thomas Stuefe wrote:
> But then, what exactly is the error? If it's just the test assuming that
> cache line size is log 6, then the test should be fixed for ppc, not hotspot.
that is the problem, test assumes log2 of 6 for chacheline size
-
PR Re
On Wed, 23 Oct 2024 18:14:50 GMT, Martin Doerr wrote:
> This code causes test errors in `CompressedClassPointersEncodingScheme.java`
> on s390 and PPC64. It forces the shift to `log_cacheline` which is 7 on PPC64
> and 9 on s390. The test passes when we remove "s > log_cacheline && " from
> th
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
> When testing Lilliput we found a failure in
> `serviceability/sa/ClhsdbJstackWithConcurrentLock.java` test when running
> with C1-only.
>
> The test uses the SA's thread printing feature to print the threads *and* the
> "concurrent locks" / AbstractOwnableSynchronizers. It then verifies that
On Thu, 24 Oct 2024 03:38:21 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 05:54:11 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix comment in objectMonitor.hpp and javaThread.hpp
>> - Skip printing tid when not available
>
> src/hots
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Wed, 23 Oct 2024 19:15:01 GMT, Coleen Phillimore wrote:
>> This tracing skips ClassLoader frames, you'll continue to see these when
>> using Class.forName.
>
> but you won't see access_controller_klass or priviledged_action_klass frames,
> so no need to skip them? Not sure why you'd want to
On Wed, 23 Oct 2024 20:36:23 GMT, Patricio Chilano Mateo
wrote:
>> Sorry, I should add context on why this is needed. The problem is that
>> inside this temporal transition we could try to acquire some monitor. If the
>> monitor is not inflated we will try to use the LockStack, but the LockSta
On Wed, 23 Oct 2024 17:32:45 GMT, Patricio Chilano Mateo
wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 111:
>>
>>> 109: * BLOCKING -> BLOCKED// blocked on monitor enter
>>> 110: * BLOCKED -> UNBLOCKED // unblocked, may be scheduled to
>>> con
On Thu, 24 Oct 2024 03:33:51 GMT, Julian Waters wrote:
> the way I did it I'd have to force push
That should not be the case. You can just anti-delta changes.
-
PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecomment-2434475849
On Wed, 23 Oct 2024 16:51:23 GMT, Chris Plummer wrote:
>> I wasn't sure whether the global memHandle not being used was a bug, so I
>> commented out the local one. I missed the line 88 one because it wasn't
>> flagged. If it really isn't needed I'll remove that one instead
>
> I'm not sure what
On Thu, 24 Oct 2024 02:42:35 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/Thre
This is a port of #16301 to macOS.
System.map and System.dump_map are implemented using the macOS API and provide
roughly the same information in the same format. Most of the heavy lifting was
implemented by @tstuefe in https://github.com/openjdk/jdk/pull/16301 - this PR
adds the macOS impleme
72 matches
Mail list logo
