On Wed, 23 Oct 2024 19:48:13 GMT, Chris Plummer <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "Remove redundant db.lookupType"
>>
>> This reverts commit e8ec2957d43730560c73e2ea9b3ec7a91fc25535.
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java line 443:
>
>> 441:
>> 442: Type collectedHeap = db.lookupType("CollectedHeap");
>> 443: CIntegerType sizeType = (CIntegerType) db.lookupType("size_t");
>
> I think you can use getSizet() here.
`getSizet()` seems to be a function in `Flags`, so I don't see a direct way to
use it. I could probably use the `sizetType` instead of
`db.lookupType("size_t")`, however when I tested the tests failed because
sizetType had not been initialized yet.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21662#discussion_r1814862338
