On Thu, 24 Oct 2024 02:57:18 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/VirtualThread.java line 631:
>
>> 629: // Object.wait
>> 630: if (s == WAITING || s == TIMED_WAITING) {
>> 631: byte nonce;
>
> Suggestion:
>
> byte seqNo;
Changed to seqNo.
> src/java.base/share/classes/java/lang/VirtualThread.java line 948:
>
>> 946: * This method does nothing if the thread has been woken by notify
>> or interrupt.
>> 947: */
>> 948: private void waitTimeoutExpired(byte nounce) {
>
> I assume you meant `nonce` here, but please change to `seqNo`.
Changed.
> src/java.base/share/classes/java/lang/VirtualThread.java line 1397:
>
>> 1395:
>> 1396: /**
>> 1397: * Returns a lock object to coordinating timed-wait setup and
>> timeout handling.
>
> Suggestion:
>
> * Returns a lock object for coordinating timed-wait setup and timeout
> handling.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1815699934
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1815700133
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1815700312
