On Tue, 15 Oct 2024 22:31:46 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The fix improves Attch API protocol and implements updated protocol on >> windows; shared code is ready to implement updated protocol support on other >> platforms. >> More detailed explanations on the 1st comment. >> >> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc >> manually tested backward compatibility (old tools can attach to current >> VMs, current tools can attach to older VMs) on Windows with jdk21u and jdk8u. > > Alex Menkov has updated the pull request incrementally with two additional > commits since the last revision: > > - updated comment > - feedback src/hotspot/share/services/attachListener.hpp line 65: > 63: /* > 64: Version 1 (since jdk6): attach operations always have 3 > (AttachOparation::arg_count_max) > 65: arguments, each up to 1024 (AttachOparation::arg_length_max) symbols. "AttachOparation" typo and also "symbols" is clarified to mean characters in a review comment, so should probably change that here and also in attachListener.cpp 626, 627. CompatTest.java says "1024 symbols" ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1814869880
