On Tue, 4 Apr 2023 14:41:13 GMT, Markus Grönlund wrote:
>> src/hotspot/share/prims/agent.hpp line 1:
>>
>>> 1: /*
>>
>> The name for class and file is too general.
>> I'm thinking if renaming the files to jvmtiAgent and the class to JvmtiAgent
>> would work.
>> In general, there exists a conve
On Wed, 5 Apr 2023 06:30:51 GMT, Adam Sotona wrote:
>> CommandProcessor command "dumpclass" produces classes with invalid field
>> descriptors.
>>
>> Proposed patch fixes
>> `sun.jvm.hotspot.oops.InstanceKlass::getFieldSignatureIndex` to return
>> correct `getSignatureIndex` instead of inval
> CommandProcessor command "dumpclass" produces classes with invalid field
> descriptors.
>
> Proposed patch fixes
> `sun.jvm.hotspot.oops.InstanceKlass::getFieldSignatureIndex` to return
> correct `getSignatureIndex` instead of invalid `getGenericSignatureIndex`.
>
> Added condition to `Clh
On Tue, 4 Apr 2023 20:33:46 GMT, Serguei Spitsyn wrote:
> This is a follow-up to
> [JDK-8302615](https://bugs.openjdk.org/browse/JDK-8302615) where
> GetCurrentThreadCpuTime and GetThreadCpuTime were changed from being not
> supported to optional, when called from/with a virtual thread. There
On Tue, 4 Apr 2023 20:50:21 GMT, Leonid Mesnik wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor comment fix
>
> test/jdk/com/sun/jdi/TestScaffold.java line 721:
>
>> 719: throw new RuntimeExcepti
On Tue, 4 Apr 2023 20:33:46 GMT, Serguei Spitsyn wrote:
> This is a follow-up to
> [JDK-8302615](https://bugs.openjdk.org/browse/JDK-8302615) where
> GetCurrentThreadCpuTime and GetThreadCpuTime were changed from being not
> supported to optional, when called from/with a virtual thread. There
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Tue, 4 Apr 2023 23:52:45 GMT, Leonid Mesnik wrote:
>> test/jdk/com/sun/jdi/VMConnection.java line 54:
>>
>>> 52: // When we run under jtreg, test.classes contains the pathname
>>> of
>>> 53: // the dir in which the .class files will be placed.
>>> 54: // When we run j
On Tue, 4 Apr 2023 22:12:03 GMT, David Holmes wrote:
>>> Given the owner could release the monitor the moment after we check I don't
>>> see how false results are an issue here. The existing code should be safe
>>> when not executed at a safepoint..
>>
>> I checked again. It looks like the Dea
On Tue, 4 Apr 2023 19:09:31 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 4 Apr 2023 23:08:06 GMT, Serguei Spitsyn wrote:
>> Currently, VMConnection run debugee using "test.classes" as a classpath. It
>> cause test failures when virtual thread factory (wrapper) is enabled and
>> test is not located the same directory as TestScaffold.
>
> test/jdk/com/sun/jdi/
On Tue, 4 Apr 2023 20:42:34 GMT, Leonid Mesnik wrote:
> Currently, VMConnection run debugee using "test.classes" as a classpath. It
> cause test failures when virtual thread factory (wrapper) is enabled and test
> is not located the same directory as TestScaffold.
test/jdk/com/sun/jdi/VMConnec
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote:
> Some tests set debugee name which is set by startUp() method.
>
> The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set
> classpath which is not required.
Looks good.
Good to know this about `TestScaffold` framework.
Tha
On Tue, 4 Apr 2023 20:53:18 GMT, Leonid Mesnik wrote:
>> I did a lot of testing on all platforms, including with product builds, but
>> yes, it is possible that on some some platforms with some flags it might not
>> be enough. I guess more testing will tell. Adjustments might be necessary.
>>
On Fri, 31 Mar 2023 08:24:19 GMT, Kevin Walls wrote:
> The Permissions in DCmds relate to remote usage over JMX.
> "monitor" is generally for reading information, and "control" is generally
> for making changes.
> The DCmds for changing compiler directives should have "control" as the
> requir
On Fri, 31 Mar 2023 08:24:19 GMT, Kevin Walls wrote:
> The Permissions in DCmds relate to remote usage over JMX.
> "monitor" is generally for reading information, and "control" is generally
> for making changes.
> The DCmds for changing compiler directives should have "control" as the
> requir
On Tue, 4 Apr 2023 19:04:03 GMT, Roman Kennke wrote:
>>> Not at all clear to me how this fits here. ??
>>
>> This block checks whether the monitor is in waiting state. When it is
>> anonymously locked it must be waiting. I added a comment.
>
>> Given the owner could release the monitor the mome
On Tue, 4 Apr 2023 12:57:38 GMT, Thomas Stuefe wrote:
>> Thanks @tstuefe . I see at that level if the object doesn't match the top of
>> the lock-stack then we take the slow path. But then I'm lost - AFAICS the
>> slow path is `InterpreterRuntime::monitorexit` and that doesn't have any
>> fast
This PR combines the "open" and "closed" regions of the CDS archive heap into a
single region. This significantly simplifies the implementation, making it more
compatible with non-G1 collectors. There's a net removal of ~1000 lines in src
code and another ~1200 lines of tests.
**Notes for revie
On Tue, 4 Apr 2023 20:42:34 GMT, Leonid Mesnik wrote:
> Currently, VMConnection run debugee using "test.classes" as a classpath. It
> cause test failures when virtual thread factory (wrapper) is enabled and test
> is not located the same directory as TestScaffold.
Might be always use use to s
Currently, VMConnection run debugee using "test.classes" as a classpath. It
cause test failures when virtual thread factory (wrapper) is enabled and test
is not located the same directory as TestScaffold.
-
Commit messages:
- more tests are added
- updated vmconnection
Changes: h
On Tue, 4 Apr 2023 18:51:21 GMT, Chris Plummer wrote:
>> The real purpose of this PR is to add virtual thread support to
>> ThreadMemoryLeakTest.java, but this exposed bugs in both the debug agent and
>> in TestScaffold, so those are being fixed also (and the debug agent bug is
>> the CR being
On Tue, 4 Apr 2023 18:42:57 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 74:
>>
>>> 72: // that get queued up, so we need to slow
>>> it down a bit more
>>> 73: // than we do for platform threads to avoi
This is a follow-up to
[JDK-8302615](https://bugs.openjdk.org/browse/JDK-8302615) where
GetCurrentThreadCpuTime and GetThreadCpuTime were changed from being not
supported to optional, when called from/with a virtual thread. There are two
additional sentences that need adjustment to avoid creati
Some tests set debugee name which is set by startUp() method.
The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set
classpath which is not required.
-
Commit messages:
- fixed tests
Changes: https://git.openjdk.org/jdk/pull/13337/files
Webrev: https://webrevs.op
On Tue, 4 Apr 2023 19:01:44 GMT, Roman Kennke wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaVFrame.java
>> line 85:
>>
>>> 83: ( // we have marked ourself as pending on this monitor
>>> 84: mark.monitor().equals(thread.getCurrentPendingMonitor()) ||
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Tue, 4 Apr 2023 12:57:38 GMT, Thomas Stuefe wrote:
>> Thanks @tstuefe . I see at that level if the object doesn't match the top of
>> the lock-stack then we take the slow path. But then I'm lost - AFAICS the
>> slow path is `InterpreterRuntime::monitorexit` and that doesn't have any
>> fast
On Tue, 4 Apr 2023 06:46:02 GMT, David Holmes wrote:
> One thing I can't quite get clear in my head is whether the small window
> where an object's monitor is inflated and the object is still in the thread's
> lock-stack, could cause an issue for any external observers trying to
> determine th
On Tue, 4 Apr 2023 08:27:53 GMT, Serguei Spitsyn wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor comment fix
>
> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 74:
>
>> 72:
> The real purpose of this PR is to add virtual thread support to
> ThreadMemoryLeakTest.java, but this exposed bugs in both the debug agent and
> in TestScaffold, so those are being fixed also (and the debug agent bug is
> the CR being used).
>
> The debug agent bug is due to a race condition
On Tue, 4 Apr 2023 07:44:40 GMT, Adam Sotona wrote:
> CommandProcessor command "dumpclass" produces classes with invalid field
> descriptors.
>
> Proposed patch fixes
> `sun.jvm.hotspot.oops.InstanceKlass::getFieldSignatureIndex` to return
> correct `getSignatureIndex` instead of invalid `ge
On Tue, 4 Apr 2023 07:44:40 GMT, Adam Sotona wrote:
> CommandProcessor command "dumpclass" produces classes with invalid field
> descriptors.
>
> Proposed patch fixes
> `sun.jvm.hotspot.oops.InstanceKlass::getFieldSignatureIndex` to return
> correct `getSignatureIndex` instead of invalid `ge
On Tue, 4 Apr 2023 03:18:37 GMT, Leonid Mesnik wrote:
> Test com/sun/jdi/PopAndInvokeTest.java has
> @ignore 6951287
> bug 6951287 is closed as a dup for 6417053 which is closed as not reproduced.
This pull request has now been integrated.
Changeset: c5941192
Author:Leonid Mesnik
URL:
On Sat, 1 Apr 2023 03:31:48 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixes
>
> src/hotspot/share/prims/agent.hpp line 1:
>
>> 1: /*
>
> The name for class and file is too general.
>
> Greetings,
>
> We are adding support to let JFR report on Agents.
>
> Design
>
> An Agent is a library that uses any instrumentation or profiling APIs. Most
> agents are started and initialized on the command line, but agents can also
> be loaded dynamically during runtime. Because comm
On Mon, 3 Apr 2023 11:05:41 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 4 Apr 2023 12:25:19 GMT, David Holmes wrote:
>> That is done one layer up in InterpreterMacroAssembler::unlock_object.
>
> Thanks @tstuefe . I see at that level if the object doesn't match the top of
> the lock-stack then we take the slow path. But then I'm lost - AFAICS the
> slow path
On Mon, 3 Apr 2023 08:29:55 GMT, Johannes Bechberger
wrote:
>> Fixes the issue by disabling PCDesc cache modifications when in ASGCT.
>>
>> Tested on my M1 mac.
>
> Johannes Bechberger has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Fix
On Tue, 4 Apr 2023 08:17:14 GMT, Thomas Stuefe wrote:
>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 9739:
>>
>>> 9737: get_thread(thread);
>>> 9738: #endif
>>> 9739: subl(Address(thread, JavaThread::lock_stack_top_offset()), oopSize);
>>
>> Is this code used for monitorexit or only ret
On Thu, 30 Mar 2023 16:03:05 GMT, Chris Plummer wrote:
> The real purpose of this PR is to add virtual thread support to
> ThreadMemoryLeakTest.java, but this exposed bugs in both the debug agent and
> in TestScaffold, so those are being fixed also (and the debug agent bug is
> the CR being us
On Thu, 30 Mar 2023 16:03:05 GMT, Chris Plummer wrote:
> The real purpose of this PR is to add virtual thread support to
> ThreadMemoryLeakTest.java, but this exposed bugs in both the debug agent and
> in TestScaffold, so those are being fixed also (and the debug agent bug is
> the CR being us
On Tue, 4 Apr 2023 05:54:09 GMT, David Holmes wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 9739:
>
>> 9737: get_thread(thread);
>> 9738: #endif
>>
On Tue, 4 Apr 2023 03:18:37 GMT, Leonid Mesnik wrote:
> Test com/sun/jdi/PopAndInvokeTest.java has
> @ignore 6951287
> bug 6951287 is closed as a dup for 6417053 which is closed as not reproduced.
Marked as reviewed by sspitsyn (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/
CommandProcessor command "dumpclass" produces classes with invalid field
descriptors.
Proposed patch fixes
`sun.jvm.hotspot.oops.InstanceKlass::getFieldSignatureIndex` to return correct
`getSignatureIndex` instead of invalid `getGenericSignatureIndex`.
Added condition to `ClhsdbDumpclass` te
On Fri, 31 Mar 2023 08:24:19 GMT, Kevin Walls wrote:
> The Permissions in DCmds relate to remote usage over JMX.
> "monitor" is generally for reading information, and "control" is generally
> for making changes.
> The DCmds for changing compiler directives should have "control" as the
> requir
On Tue, 4 Apr 2023 06:09:02 GMT, Jie Fu wrote:
> Add `-XX:+UnlockDiagnosticVMOptions` to fix the failure with release VMs.
> Thanks.
This pull request has now been integrated.
Changeset: a663d5d6
Author:Jie Fu
URL:
https://git.openjdk.org/jdk/commit/a663d5d69486447d80cab040830abf0b1
On Tue, 4 Apr 2023 07:20:11 GMT, Serguei Spitsyn wrote:
> Looks good and trivial. Thank you for taking care about it. -Serguei
Thanks @sspitsyn for your review.
-
PR Comment: https://git.openjdk.org/jdk/pull/13318#issuecomment-1495485094
On Mon, 3 Apr 2023 08:29:55 GMT, Johannes Bechberger
wrote:
>> Fixes the issue by disabling PCDesc cache modifications when in ASGCT.
>>
>> Tested on my M1 mac.
>
> Johannes Bechberger has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Fix
On Mon, 3 Apr 2023 08:29:55 GMT, Johannes Bechberger
wrote:
>> Fixes the issue by disabling PCDesc cache modifications when in ASGCT.
>>
>> Tested on my M1 mac.
>
> Johannes Bechberger has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Fix
On Tue, 4 Apr 2023 06:09:02 GMT, Jie Fu wrote:
> Add `-XX:+UnlockDiagnosticVMOptions` to fix the failure with release VMs.
> Thanks.
Looks good and trivial.
Thank you for taking care about it.
-Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org
51 matches
Mail list logo
