On Tue, 4 Apr 2023 20:53:18 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> I did a lot of testing on all platforms, including with product builds, but >> yes, it is possible that on some some platforms with some flags it might not >> be enough. I guess more testing will tell. Adjustments might be necessary. >> It is important not too slow things down too much, or it's possible that if >> there is a memory leak, the test won't catch it because the leak is not fast >> enough. With the current sleep values, throughput for virtual threads is >> still about 2x what it is for platform threads, so right now I'm not worried >> about it having been slowed down too much. > > small nit. shorter to use: > long timeToSleep = "Virtual".equals(mainWrapper) ? 100 : 50; Okay. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13246#discussion_r1157832902
