On Tue, 4 Apr 2023 20:50:21 GMT, Leonid Mesnik <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor comment fix
>
> test/jdk/com/sun/jdi/TestScaffold.java line 721:
>
>> 719: throw new RuntimeException(e);
>> 720: }
>> 721: if (p.isAlive()) {
>
> It think it is better to just use watiFor(). If debugee hangs it would be
> better to times out and give timeout handler a chance to dump all stack
> traces.
Ok. I hadn't thought about the timeout handler.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13246#discussion_r1158037262
