On Mon, 3 Apr 2023 08:29:55 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> Fixes the issue by disabling PCDesc cache modifications when in ASGCT. >> >> Tested on my M1 mac. > > Johannes Bechberger has updated the pull request incrementally with two > additional commits since the last revision: > > - Fix fix > - Fix minor issues Can I just clarify the new approach please. IIUC if we update the PcDesc cache whilst within ASGCT then we hit code that needs WXWrite mode. So the fix is to just skip updating the cache if ASGCT is active. I have no idea what the PcDesc cache is but I presume if it is really a cache then not updating it only potentially affects lookup performance - right? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13144#issuecomment-1495349989
