On Wed, 4 Jan 2023 15:30:10 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
On Thu, 5 Jan 2023 04:59:51 GMT, Serguei Spitsyn wrote:
>> src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java line
>> 130:
>>
>>> 128: @Override
>>> 129: protected int read(long fd, byte[] bs, int off, int len)
>>> throws IOException {
>>> 130:
On Thu, 5 Jan 2023 04:31:16 GMT, David Holmes wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add doc; readImpl/closeImpl to read/close
>
> src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java line
>
On Thu, 5 Jan 2023 03:32:21 GMT, Yi Yang wrote:
>> harmless refactor to share code across different platforms of
>> VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command
>> execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang h
On Thu, 5 Jan 2023 02:37:45 GMT, David Holmes wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add doc; readImpl/closeImpl to read/close
>
> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line
On Thu, 5 Jan 2023 03:06:20 GMT, David Holmes wrote:
>> All Posix OS platforms call the same VirtualMachineImpl.read/write/etc, but
>> Windows is an unusual guy, it calls VirtualMachineImpl.readPipe/writePipe/etc
>
> That is a shame, though perhaps we could just rename those methods on Windows?
> harmless refactor to share code across different platforms of
> VirtualMachineImpl:
> 1. Shared code to process command response after requesting a command
> execution
> 2. Read functionality in SocketInputStream can be reused
Yi Yang has updated the pull request incrementally with one additio
On Thu, 5 Jan 2023 02:50:49 GMT, Yi Yang wrote:
>> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java
>> line 425:
>>
>>> 423:
>>> 424: protected abstract int readImpl(long fd, byte[] bs, int off,
>>> int len) throws IOException;
>>> 425: protected abstra
On Thu, 5 Jan 2023 02:44:48 GMT, Yi Yang wrote:
>> In that case the `int pid` determined by the superclass should be made
>> available to the subclasses so they can use it and not need to re-parse the
>> `vmid`.
>
>> In that case the `int pid` determined by the superclass should be made
>> ava
On Wed, 4 Jan 2023 09:22:40 GMT, Yi Yang wrote:
>> harmless refactor to share code across different platforms of
>> VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command
>> execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang h
On Thu, 5 Jan 2023 02:40:22 GMT, David Holmes wrote:
>> src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java line
>> 195:
>>
>>> 193: * InputStream for the socket connection to get target VM
>>> 194: */
>>> 195: private static class SocketInputStreamImpl extends
On Thu, 5 Jan 2023 02:36:59 GMT, David Holmes wrote:
>> Yi Yang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains two
>> new commits si
On Wed, 4 Jan 2023 04:20:11 GMT, David Holmes wrote:
> In that case the `int pid` determined by the superclass should be made
> available to the subclasses so they can use it and not need to re-parse the
> `vmid`.
Hi @dholmes-ora, this is feasible, but in fact, the super class of
VirtualMachi
On Thu, 5 Jan 2023 02:35:54 GMT, David Holmes wrote:
>> Yi Yang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains two
>> new commits si
On Wed, 4 Jan 2023 09:22:40 GMT, Yi Yang wrote:
>> harmless refactor to share code across different platforms of
>> VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command
>> execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang h
On Wed, 4 Jan 2023 15:30:10 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
On Wed, 4 Jan 2023 01:19:52 GMT, Jaikiran Pai wrote:
>> Michael Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge ../jdk-openjdk into typos-typos
>> - Reinstate typos in Apache code that is copie
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8299563: Fix typos
This pull request has now been integrated.
Changeset: 7dcc6899
Author:Michael Ernst
Committer: Alexey Ivanov
URL:
https://git.openjdk.org/jdk/commit/7dcc689932ea276586282e0917f2efc10a598eb7
Stats: 5 lin
On Wed, 4 Jan 2023 16:35:41 GMT, Michael Ernst wrote:
>> 8299563: Fix typos
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains ten commits:
>
> - Address review feedback
> - Merge ../jdk-openjdk into typos-typos
>
On Wed, 4 Jan 2023 16:35:41 GMT, Michael Ernst wrote:
>> 8299563: Fix typos
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains ten commits:
>
> - Address review feedback
> - Merge ../jdk-openjdk into typos-typos
>
> 8299563: Fix typos
Michael Ernst has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains ten commits:
- Address review feedback
- Merge ../jdk-openjdk into typos-typos
- Merge ../jdk-openjdk into typos-typos
- Reinstate typos in Apache
On Wed, 4 Jan 2023 14:25:12 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 20 -> JDK 21
This pull request has now been integrated.
Changeset: df1caf90
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/df1caf90818558b897a6b8ab80757f2a03398c55
Stats: 299 lines i
> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
> This leads to a somewhat misleading message
> `[debugd] Argument is expected for 'rmiport' `
> (we set an argument [-1] but probably this is not what
On Wed, 4 Jan 2023 14:56:54 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
On Wed, 4 Jan 2023 14:39:14 GMT, Kevin Walls wrote:
> SADebugDTest is only one test, so seems OK to have it fail as soon as we
> realise we need a port, and it has a value of -1.
>
> I would do it in this change as they are so connected, but really whichever
> works best for you. (I don't see
> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
> This leads to a somewhat misleading message
> `[debugd] Argument is expected for 'rmiport' `
> (we set an argument [-1] but probably this is not what
On Wed, 4 Jan 2023 12:56:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes the remaining uses of non-reentrant
> `getprotobyname` function.
>
> While the protocol number for TCP could theoretically be modified to
> something other than the default `IPPROTO_TCP`, that scena
On Wed, 4 Jan 2023 13:04:10 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
Please review this patch that removes the remaining uses of non-reentrant
`getprotobyname` function.
While the protocol number for TCP could theoretically be modified to something
other than the default `IPPROTO_TCP`, that scenario would likely not work, and
is not something that we are willing
Forwardport JDK 20 -> JDK 21
-
Commit messages:
- Merge remote-tracking branch 'jdk20/master' into Merge_jdk20
- 8299476: PPC64 Zero build fails after JDK-8286302
- 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException:
assertTrue: expected true, was false"
- 829
On Wed, 4 Jan 2023 14:19:18 GMT, Kevin Walls wrote:
> In the "if (useRmiPort) {" block, we should be failing the test if rmiPort is
> -1, saying something like "cannot find an rmiPort, findUnreservedFreePort
> returns -1"
>
> A similar abort if setting registryPort gets -1 might also be good?
On Wed, 4 Jan 2023 13:04:10 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
On Wed, 4 Jan 2023 13:04:10 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
> This leads to a somewhat misleading message
> `[debugd] Argument is expected for 'rmiport' `
> (we set an argument [-1] but probably this is not what
On Wed, 4 Jan 2023 12:10:11 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
> This leads to a somewhat misleading message
> `[debugd] Argument is expected for 'rmiport' `
> (we set an argument [-1] but probably this is not what
On Mon, 2 Jan 2023 14:31:14 GMT, Matthias Baesken wrote:
> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
> This leads to a somewhat misleading message
> `[debugd] Argument is expected for 'rmiport'
> harmless refactor to share code across different platforms of
> VirtualMachineImpl:
> 1. Shared code to process command response after requesting a command
> execution
> 2. Read functionality in SocketInputStream can be reused
Yi Yang has refreshed the contents of this pull request, and previo
38 matches
Mail list logo
