On Thu, 5 Jan 2023 02:40:22 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java line >> 195: >> >>> 193: * InputStream for the socket connection to get target VM >>> 194: */ >>> 195: private static class SocketInputStreamImpl extends >>> SocketInputStream { >> >> Can this class definition also be shared by making it a protected nested >> class in the superclass? > > Sorry I see it already is, but I think we can do better. This(`SocketInputStreamImpl`) is implementation-specific, it calls platform-dependent VirtualMachine.xxx. ------------- PR: https://git.openjdk.org/jdk/pull/11823