On Wed, 4 Jan 2023 14:56:54 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some >> circumstances a negative rmiport (--rmiport -1) to SALauncher.java. >> This leads to a somewhat misleading message >> `[debugd] Argument is expected for 'rmiport' ` >> (we set an argument [-1] but probably this is not what is really expected) >> and additionally the real exception is not shown. >> Probably also a warning in case of negative rmiport values should be printed >> because they seem to lead to errors. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Adjust SADebugDTest in case we get port -1 Looks good! Rereading the change, occured should be "occurred" (we do have a lot of "occured" in the JDK, but many more "occurred") On the line after that, I don't think we should introduce the stacktrace. The user is getting a more readable error message already... In SAGetopt.java you single-quote the 'opt' value, but could we do the same to the _argv[_optind] value. Then can you could make it "a registryPort" rather than "an", and I think I'm done with comments. Thanks! ------------- PR: https://git.openjdk.org/jdk/pull/11811
