On Thu, 5 Jan 2023 02:44:48 GMT, Yi Yang <yy...@openjdk.org> wrote: >> In that case the `int pid` determined by the superclass should be made >> available to the subclasses so they can use it and not need to re-parse the >> `vmid`. > >> In that case the `int pid` determined by the superclass should be made >> available to the subclasses so they can use it and not need to re-parse the >> `vmid`. > > Hi @dholmes-ora, this is feasible, but in fact, the super class of > VirtualMachine has already saved an unresolved pid(String) and corresponding > getter method, so if we want to avoid re-parsing pid, we should save this > parsed result in the parent class of the parent class of VirtualMachineImpl, > and then modify the corresponding method, which seems to be beyond the scope > of simple refactoring, so I hope avoiding re-parsing can be done by another PR
It is well within scope of improving code sharing in this arera, but I'm okay with leaving that for a next step. ------------- PR: https://git.openjdk.org/jdk/pull/11823
