On Fri, 19 Jul 2024 20:32:23 GMT, Bradford Wetmore wrote:
> Is it slow enough these days that we couldn't remove the `/manual`? How long
> is the test taking?
@bradfordwetmore It does not take much time, average ~12 seconds
-
PR Comment: https://git.openjdk.org/jdk/pull/20135#issu
On Fri, 19 Jul 2024 20:32:23 GMT, Bradford Wetmore wrote:
> I understand that the main purpose is to provide performance numbers and no
> one will be watching it, but if it's not taking too much time, it's nice to
> have the additional test for ensuring nothing went wrong when exercising the
>
DES/ECB/NoPadding 1024100 66
> DES/ECB/NoPadding 10241000 50
> DES/ECB/NoPadding 8192100 70
> DES/ECB/NoPadding 8192 1000 70
> Average:64
Fernando Guallini
DES/ECB/NoPadding 1024100 66
> DES/ECB/NoPadding 10241000 50
> DES/ECB/NoPadding 8192100 70
> DES/ECB/NoPadding 8192 1000 70
> Average:64
Fernando Guallini h
On Thu, 11 Jul 2024 09:51:10 GMT, Fernando Guallini
wrote:
> The manual test Cipher/DES/PerformanceTest.java fails with
> ArithmeticException due to potential division by zero. The issue arises when
> calculating the elapsed time using end - start, which could result in zero
>
The test: **com/sun/security/auth/callback/TextCallbackHandler/Password.java**
would benefit from detailed manual steps to ensure it runs correctly. It was
added to the problem list because it was not executed properly and failed.
Providing these steps will help prevent such issues in the future
There are 3 manual GSS-API/Kerberos tests that require a manual setup and were
added to the problem list years ago:
- com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and
server have completed the authentication process.
- com/sun/security/sasl/gsskerb/**NoSecurityLayer** -
On Mon, 29 Jul 2024 12:43:04 GMT, Fernando Guallini
wrote:
> The test:
> **com/sun/security/auth/callback/TextCallbackHandler/Password.java** would
> benefit from detailed manual steps to ensure it runs correctly. It was added
> to the problem list because it was not executed
In order to improve performance when instantiating NativePRNG, a dummy
constructor was added in the PR: https://github.com/openjdk/jdk/pull/17560
which takes and ignores a `java.security.SecureRandomParameters`, throwing an
exception if any parameter is passed.
This PR adds test coverage for th
The test sun/security/validator/samedn.sh failed once due to the following
reason:
`Caused by: java.security.cert.CertificateNotYetValidException: NotBefore: Tue
Aug 06 14:41:13 GMT 2024`
This test generates several certificates using the keytool as a precondition,
and then validates their cer
On Mon, 5 Aug 2024 10:46:32 GMT, Fernando Guallini
wrote:
> There are 3 manual GSS-API/Kerberos tests that require a manual setup and
> were added to the problem list years ago:
>
> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and
> server
principal names, generates krb5.conf and
> keytab files, and setup a JAAS login config file.
>
> I've enhanced SaslBasic to include additional wrap/unwrap checks with and
> without a security layer. As a result, the 3 manual tests and their
> associated files are now redundand
The test javax/net/ssl/DTLS/DTLSRehandshakeTest.java runs multiple scenarios,
generating a large amount of logging as a result. Since Jtreg truncates the
output when it becomes too large, the logs are often not useful for debugging
in case of failure.
This PR updates the test to also write the
On Thu, 15 Aug 2024 09:29:00 GMT, Fernando Guallini
wrote:
> In order to improve performance when instantiating NativePRNG, a dummy
> constructor was added in the PR: https://github.com/openjdk/jdk/pull/17560
> which takes and ignores a `java.security.SecureRandomParameters`, th
On Tue, 27 Aug 2024 14:49:40 GMT, Fernando Guallini
wrote:
> The test sun/security/validator/samedn.sh failed once due to the following
> reason:
>
> `Caused by: java.security.cert.CertificateNotYetValidException: NotBefore:
> Tue Aug 06 14:41:13 GMT 2024`
>
> This t
R updates the DTLS maxOutputSize for the test directory, including
> DTLSRehandshakeTest.java. Incrementing the maxOutputSize results in more
> logs, with an approximate size increase of 0.6MB when compressed.
Fernando Guallini has updated the pull request with a new target base due to a
On Thu, 5 Sep 2024 09:59:51 GMT, Jaikiran Pai wrote:
> Hello Fernando, I'm not familiar with this test or the area, but if this
> change is just to make available jtreg logs (in a separate file) to allow for
> debugging a currently intermittent test failure, then there are ways to
> change the
On Thu, 15 Aug 2024 09:29:00 GMT, Fernando Guallini
wrote:
> In order to improve performance when instantiating NativePRNG, a dummy
> constructor was added in the PR: https://github.com/openjdk/jdk/pull/17560
> which takes and ignores a `java.security.SecureRandomParameters`, th
During the code review of
[JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several
non-critical comments were raised but not addressed due to time constraints.
This PR includes the following changes:
1. Symantec and Entrust tests now reuse common code. The Distrust.java class
contai
As highlighted in the bug description, The test
**security/Security/SynchronizedAccess.java** have some issues:
1. it needs to implement the sigalg, otherwise it throws
java.security.NoSuchAlgorithmException . Even though it does not fail as it
catches the exception, it never reaches the remove
n to
> the local providers, which it is not the test intent.
> 3. Adding othervm flag to run in isolation.
>
> Test runs in tier2
Fernando Guallini has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
b
On Thu, 6 Jun 2024 11:25:39 GMT, Matthew Donovan wrote:
>> Fernando Guallini has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
n to
> the local providers, which it is not the test intent.
> 3. Adding othervm flag to run in isolation.
>
> Test runs in tier2
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
added brackets, and refa
n to
> the local providers, which it is not the test intent.
> 3. Adding othervm flag to run in isolation.
>
> Test runs in tier2
Fernando Guallini has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains two commits:
- added
Since HttpsURLConnectionTest attempts to reach external servers, it can fail if
run on hosts without outbound traffic allowed. Therefore, it should not be
executed in CI pipelines but rather manually on a host with no firewall rules
preventing egress traffic.
-
Commit messages:
-
On Mon, 17 Jun 2024 09:16:45 GMT, Fernando Guallini
wrote:
> Since HttpsURLConnectionTest attempts to reach external servers, it can fail
> if run on hosts without outbound traffic allowed. Therefore, it should not be
> executed in CI pipelines but rather manually on a host with no
The following test:
**com/sun/security/auth/callback/TextCallbackHandler/Default.java** is
currently marked to be run manually because user inputs are required in the
console, but instead it can be automated by providing a custom inputStream to
System.in in the actual test to simulate sequentia
On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini
wrote:
>> As highlighted in the bug description, The test
>> **security/Security/SynchronizedAccess.java** have some issues:
>>
>> 1. it needs to implement the sigalg, otherwise it throws
>> java.security.N
On Wed, 19 Jun 2024 12:47:33 GMT, Fernando Guallini
wrote:
> The following test:
> **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is
> currently marked to be run manually because user inputs are required in the
> console, but instead it can be automated by
On Wed, 26 Jun 2024 16:11:52 GMT, Weijun Wang wrote:
>> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Default.java
>> line 80:
>>
>>> 78: pipedOut.write("-1\n".getBytes());
>>> 79: pipedOut.flush();
>>> 80: textHandler.handle(new Callback[]{callback});
>>
actual test to simulate sequential user input.
>
> In addition, this patch is removing the test from the problemList as it
> passes, and from manual test list.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
move HumanInputSt
On Thu, 27 Jun 2024 12:48:00 GMT, Weijun Wang wrote:
>> @wangweij
>> I was handling the callback in 2 separate calls because it was blocking and
>> timing out while waiting for input. Now, using _HumanInputStream_ allows
>> handling it in a single call. Unfortunately this class is not visible
On Wed, 19 Jun 2024 12:47:33 GMT, Fernando Guallini
wrote:
> The following test:
> **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is
> currently marked to be run manually because user inputs are required in the
> console, but instead it can be automated by
There is a compilation issue in the test
**test/jdk/sun/security/tools/keytool/NssTest.java** because the
[HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputStream.java)
class was moved from keytool/KeyToolTest.java to a library class in th
to a library class in this
> [PR](https://github.com/openjdk/jdk/pull/19790) for reusability. NssTest
> depends on KeyToolTest.java, therefore it will also need to import
> HumanInputStream from the test library.
Fernando Guallini has updated the pull request incrementally with one
additi
On Fri, 28 Jun 2024 16:11:02 GMT, Fernando Guallini
wrote:
> There is a compilation issue in the test
> **test/jdk/sun/security/tools/keytool/NssTest.java** because the
> [HumanInputStream](https://github.com/openjdk/jdk/blob/master/test/jdk/java/security/testlibrary/HumanInputSt
The manual test Cipher/DES/PerformanceTest.java fails with ArithmeticException
due to potential division by zero. The issue arises when calculating the
elapsed time using end - start, which could result in zero milliseconds if
start and end are identical due to the high speed of execution. This
On Mon, 15 Jul 2024 08:07:21 GMT, Rajan Halade wrote:
>> The manual test Cipher/DES/PerformanceTest.java fails with
>> ArithmeticException due to potential division by zero. The issue arises when
>> calculating the elapsed time using end - start, which could result in zero
>> milliseconds if s
On Tue, 16 Jul 2024 00:37:17 GMT, Bradford Wetmore wrote:
>> Fernando Guallini has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
re
> System.currentTimeMillis() has low precision, such as many versions of
> Windows, end and start can be equal when obtaining System.currentTimeMillis()
> if the test runs very quickly.
>
> The fix is to provide a default value in case _end_ is not higher than
> _s
On Mon, 15 Jul 2024 09:36:28 GMT, Fernando Guallini
wrote:
>> test/jdk/com/sun/crypto/provider/Cipher/DES/PerformanceTest.java line 186:
>>
>>> 184: end = System.currentTimeMillis();
>>> 185:
>>> 186: // To avoid diving by zero
n to
> the local providers, which it is not the test intent.
> 3. Adding othervm flag to run in isolation.
>
> Test runs in tier2
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
applied suggested patch
-
Ch
DES/ECB/NoPadding 1024100 66
> DES/ECB/NoPadding 10241000 50
> DES/ECB/NoPadding 8192100 70
> DES/ECB/NoPadding 8192 1000 70
> Average:64
Fernando Guallini h
On Thu, 30 May 2024 14:01:20 GMT, Fernando Guallini
wrote:
> As highlighted in the bug description, The test
> **security/Security/SynchronizedAccess.java** have some issues:
>
> 1. it needs to implement the sigalg, otherwise it throws
> java.security.NoSuchAlgorithmExceptio
DES/ECB/NoPadding 1024100 66
> DES/ECB/NoPadding 10241000 50
> DES/ECB/NoPadding 8192100 70
> DES/ECB/NoPadding 8192 1000 70
> Average:64
Fernando Guallini h
On Fri, 19 Jul 2024 09:32:20 GMT, Fernando Guallini
wrote:
>> The manual test Cipher/DES/PerformanceTest.java fails with
>> ArithmeticException due to potential division by zero. The issue arises when
>> calculating the elapsed time using end - start, which co
On Mon, 21 Oct 2024 13:08:09 GMT, Weijun Wang wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Convert bits to bytes when necessary
>
> Have you timed the differences? I remember
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a modulus with
> 2048-bit, base 2 and certificates with key size 20
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
Convert bits to bytes when necessary
-
Ch
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
Fix algo mistake in SignatureKeyInfo
-
Ch
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a modulus with
> 2048-bit, base 2 and certificates with key size 20
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
Using SecurityUtils to define the
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
Updated tests that were already using 2048 to use
Several tests currently use weak key and salt sizes. If the purpose of the
tests is not to evaluate weak keys, they should be updated to use stronger
keys. This PR does not intend to update the tests to use stronger algorithms.
There is no significant increase in tests run time, those still run
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a modulus with
> 2048-bit, base 2 and certificates with key size 20
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
KeyToolTest.java will be updated in another PR
-
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the m
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a modulus with
> 2048-bit, base 2 and certificates with key size 20
On Wed, 23 Oct 2024 19:50:19 GMT, Rajan Halade wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reusing Utils.CopyFiles
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java lin
On Wed, 23 Oct 2024 19:43:33 GMT, Matthew Donovan wrote:
>> Fernando Guallini has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Tue, 1 Oct 2024 08:51:29 GMT, Fernando Guallini
wrote:
> The test
> **sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java** may
> fail with the following exception:
>
>
> test PreserveRawManifestEntryAndDigest.testNameImmediatelyCo
> Several tests are identified to use weak/legacy algorithms. As these tests
> purpose is not to exercise weak algorithms, these are updated in this PR to
> use stronger algorithms. If the test uses a weak key, it is updated as well.
Fernando Guallini has updated the pull request incr
Several tests are identified to use weak/legacy algorithms. As these tests
purpose is not to exercise weak algorithms, these are updated in this PR to use
stronger algorithms. If the test uses a weak key, it is updated as well.
-
Commit messages:
- Merge branch 'master' into 834218
On Wed, 23 Oct 2024 19:37:50 GMT, Matthew Donovan wrote:
>> Several tests are identified to use weak/legacy algorithms. As these tests
>> purpose is not to exercise weak algorithms, these are updated in this PR to
>> use stronger algorithms. If the test uses a weak key, it is updated as well.
>
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 13 commits:
- Merge branch 'master&#
On Thu, 31 Oct 2024 16:58:36 GMT, Sean Mullan wrote:
> LGTM.
Thanks for the review!
-
PR Comment: https://git.openjdk.org/jdk/pull/21280#issuecomment-2450494653
On Thu, 17 Oct 2024 13:44:19 GMT, Fernando Guallini
wrote:
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a mod
> Several tests are identified to use weak/legacy algorithms. As these tests
> purpose is not to exercise weak algorithms, these are updated in this PR to
> use stronger algorithms. If the test uses a weak key, it is updated as well.
Fernando Guallini has updated the pull request w
On Wed, 30 Oct 2024 23:27:12 GMT, Anthony Scarpino
wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add more algos to TestExplicitKeyLength.java
>
> test/jdk/com/su
On Wed, 30 Oct 2024 23:35:19 GMT, Anthony Scarpino
wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add more algos to TestExplicitKeyLength.java
>
> test/jdk/java/security/Sign
On Tue, 1 Oct 2024 08:51:29 GMT, Fernando Guallini
wrote:
> The test
> **sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java** may
> fail with the following exception:
>
>
> test PreserveRawManifestEntryAndDigest.testNameImmediatelyCo
On Fri, 18 Oct 2024 08:33:36 GMT, Fernando Guallini
wrote:
> Several tests are identified to use weak/legacy algorithms. As these tests
> purpose is not to exercise weak algorithms, these are updated in this PR to
> use stronger algorithms. If the test uses a weak key, it is update
> Several tests are identified to use weak/legacy algorithms. As these tests
> purpose is not to exercise weak algorithms, these are updated in this PR to
> use stronger algorithms. If the test uses a weak key, it is updated as well.
Fernando Guallini has updated the pull request w
> Several tests are identified to use weak/legacy algorithms. As these tests
> purpose is not to exercise weak algorithms, these are updated in this PR to
> use stronger algorithms. If the test uses a weak key, it is updated as well.
Fernando Guallini has updated the pull request incr
On Wed, 16 Oct 2024 12:34:32 GMT, Fernando Guallini
wrote:
> Several tests currently use weak key and salt sizes. Since the purpose of
> these tests is not to evaluate weak keys, they can be updated to use stronger
> keys length (2048-bits) and stronger Salt (16 bytes). This PR
The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends
sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider configured
with NSS config files located in the source tree directory
(sun/security/pkcs11/nss) for the dependent tests to run properly. This test
currently f
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a modulus with
> 2048-bit, base 2 and certificates with key size 20
On Tue, 24 Sep 2024 15:57:28 GMT, Sean Mullan wrote:
>> During the code review of
>> [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several
>> non-critical comments were raised but not addressed due to time constraints.
>> This PR includes the following changes:
>>
>> 1. Symantec
On Wed, 11 Sep 2024 09:07:15 GMT, Fernando Guallini
wrote:
> During the code review of
> [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several
> non-critical comments were raised but not addressed due to time constraints.
> This PR includes the following cha
On Tue, 3 Sep 2024 13:07:47 GMT, Fernando Guallini
wrote:
> The test javax/net/ssl/DTLS/DTLSRehandshakeTest.java runs multiple scenarios,
> generating a large amount of logging as a result. Since Jtreg truncates the
> output when it becomes too large, the logs are often not u
his PR updates the maxOutputSize for the DTLS test directory, including
> DTLSRehandshakeTest.java. Incrementing the maxOutputSize results in more
> logs, with an approximate size increase of ~0.6MB when compressed.
Fernando Guallini has updated the pull request incrementally with one
addition
The test
**sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java** may
fail with the following exception:
test PreserveRawManifestEntryAndDigest.testNameImmediatelyContinued(): failure
java.lang.AssertionError: "s k 300 Tue Jun 25 10:20:16 GMT+07:00 2024
META-INF/MANIFEST.MF" sho
The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** relies
on the `certutil.exe` tool to import and delete certificates from a keystore.
It was annotated with `@ignore` due to the uncertainty of `certutil.exe` being
available on the instance where the test is executed.
Rath
On Tue, 3 Sep 2024 07:57:47 GMT, Fernando Guallini
wrote:
>> There are 3 manual GSS-API/Kerberos tests that require a manual setup and
>> were added to the problem list years ago:
>>
>> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and
&
On Wed, 23 Oct 2024 19:51:24 GMT, Rajan Halade wrote:
>> The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends
>> sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider
>> configured with NSS config files located in the source tree directory
>> (sun/security/pkcs11/
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a modulus with
> 2048-bit, base 2 and certificates with key size 20
onfig files to the Jtreg
> scratch directory and configures the provider to use those files instead.
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
Reusing Utils.CopyFiles
-
Changes:
- all: https://git.openjdk.org/j
r algorithms.
>
> There is no significant increase in tests run time, those still complete
> consistently fast (few seconds).
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last revision:
simplified getTestKeySize
-
Ch
Several tests are identified to use weak key parameters (prime modulus,
private/public values) and certs with weak keys. As these tests purpose is not
to exercise weak keys, these are updated in this PR to use a modulus with
2048-bit, base 2 and certificates with key size 2048
-
Co
On Wed, 23 Oct 2024 14:46:37 GMT, Fernando Guallini
wrote:
> The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends
> sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider
> configured with NSS config files located in the source tree directory
> (
On Wed, 4 Dec 2024 14:44:22 GMT, SendaoYan wrote:
> Hi, this test has been marked as manual test by
> [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441). After this PR,
> should we mark this test as automatic test.
Hi,
This test should remain manual, as it still depends on multiple ext
The following tests in CAInterop.java for Google test domain are currently
failing:
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1
security/infra/ja
On Thu, 5 Dec 2024 18:12:56 GMT, Rajan Halade wrote:
> LGTM. Can you target this fix to https://github.com/openjdk/jdk/tree/jdk24
> instead?
Done
-
PR Comment: https://git.openjdk.org/jdk/pull/22542#issuecomment-2522683745
On Wed, 2 Oct 2024 13:24:00 GMT, Fernando Guallini
wrote:
> The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java**
> relies on the `certutil.exe` tool to import and delete certificates from a
> keystore. It was annotated with `@ignore` due to the uncer
On Wed, 5 Feb 2025 12:53:09 GMT, Fernando Guallini
wrote:
> When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java
>
>
> Two warning are shown:
>
>
> test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape]
> possible 'th
On Wed, 5 Feb 2025 22:45:36 GMT, Hai-May Chao wrote:
> Nit: copyright update
updated to 2025 now 👍
-
PR Comment: https://git.openjdk.org/jdk/pull/21305#issuecomment-2639325902
the test is executed.
>
> Rather than ignoring the test entirely, this PR updates the logic to throw a
> `SkippedException` if the tool is not found, ensuring the test runs when
> possible, and gracefully skipped otherwise.
Fernando Guallini has updated the pull request incrementally wit
On Wed, 5 Feb 2025 12:53:09 GMT, Fernando Guallini
wrote:
> When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java
>
>
> Two warning are shown:
>
>
> test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape]
> possible 'th
On Thu, 6 Feb 2025 18:11:30 GMT, Mikhail Yankelevich wrote:
>> * ./util/Pem/encoding.sh is now a java test
>> * also added the validations for the test results, not only an error check
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last
On Thu, 6 Feb 2025 12:12:35 GMT, Mikhail Yankelevich wrote:
> * ./util/Pem/encoding.sh is now a java test
> * also added the validations for the test results, not only an error check
test/jdk/sun/security/util/Pem/PemEncoding.java line 47:
> 45: File.separator,
> 46:
1 - 100 of 153 matches
Mail list logo
