On Wed, 5 Feb 2025 12:53:09 GMT, Fernando Guallini <fguall...@openjdk.org> 
wrote:

> When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java
> 
> 
> Two warning are shown: 
> 
> 
> test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape] 
> possible 'this' escape before subclass is fully initialized
>             setHandler(handler);
> 
> - setHandler is called in the constructor and a subclass may override it. It 
> is fixed by making the method 'final'
> 
> 
> test/lib/security/timestamp/TsaServer.java:42: warning: [try] auto-closeable 
> resource TsaServer has a member method close() that could throw 
> InterruptedException
> 
> - Remove `throws Exception` from TsaServer.close()

Thanks for reviews 👍

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23463#issuecomment-2639312183

Reply via email to