On Mon, 21 Oct 2024 13:08:09 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Convert bits to bytes when necessary > > Have you timed the differences? I remember we've deliberately used small key > sizes for RSA and DSA in some tests because large sizes could be very slow. @wangweij Yes, test execution time was taken into consideration. A few tests were generating keys in a loop, which significantly increased their execution time; so those tests were not included in this PR. Only tests that did not have a significant impact on execution time, only a for few seconds, were included. None of these test run for longer than 30 seconds, and the **total** execution time for the group has only increased by 10-30 seconds depending on the platform ------------- PR Comment: https://git.openjdk.org/jdk/pull/21537#issuecomment-2426983627
