Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v7]

2023-05-31 Thread Hai-May Chao
On Tue, 30 May 2023 16:47:03 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Sean's additional comments take 2 test/micro/org/openjdk/bench/java/securit

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v7]

2023-05-30 Thread Sean Mullan
On Tue, 30 May 2023 16:47:03 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Sean's additional comments take 2 Marked as reviewed by mullan (Reviewer).

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v7]

2023-05-30 Thread Hai-May Chao
On Tue, 30 May 2023 16:47:03 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Sean's additional comments take 2 test/jdk/sun/security/tools/jarsigner/Ver

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v6]

2023-05-30 Thread Mark Powers
On Tue, 30 May 2023 15:09:59 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean's additional comments > > I don't see my comments resolved in the latest commit. Did you not push them > yet? @sea

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v7]

2023-05-30 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Sean's additional comments take 2 - Changes: - all: https://git.openjdk.org/jdk/pull/13940/files - new: https://git.openjdk

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v6]

2023-05-30 Thread Sean Mullan
On Fri, 26 May 2023 23:24:38 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Sean's additional comments I don't see my comments resolved in the latest c

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v6]

2023-05-26 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Sean's additional comments - Changes: - all: https://git.openjdk.org/jdk/pull/13940/files - new: https://git.openjdk.org/jd

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

2023-05-26 Thread Mark Powers
On Tue, 23 May 2023 19:07:45 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change class names and fix nit > > test/jdk/sun/security/provider/hss/TestHSSLMS.java line 26: > >> 24: /* >> 25: * @te

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

2023-05-23 Thread Hai-May Chao
On Tue, 23 May 2023 17:14:42 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > change class names and fix nit Test VerifyHSSLMSSignedJar.java looks good.

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

2023-05-23 Thread Sean Mullan
On Tue, 23 May 2023 17:14:42 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > change class names and fix nit test/jdk/sun/security/provider/hss/TestHSSLM

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

2023-05-23 Thread Sean Mullan
On Tue, 23 May 2023 17:14:42 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > change class names and fix nit test/micro/org/openjdk/bench/java/security/H

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v3]

2023-05-23 Thread Mark Powers
On Tue, 23 May 2023 10:49:17 GMT, Ferenc Rakoczi wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ferenc: comments 1 and 2 > > test/jdk/sun/security/provider/lms/TestLMS.java line 59: > >> 57: for (TestCase

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

2023-05-23 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: change class names and fix nit - Changes: - all: https://git.openjdk.org/jdk/pull/13940/files - new: https://git.openjdk.or

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v4]

2023-05-23 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Ferenc: comment 3 - Changes: - all: https://git.openjdk.org/jdk/pull/13940/files - new: https://git.openjdk.org/jdk/pull/13

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v3]

2023-05-23 Thread Ferenc Rakoczi
On Tue, 23 May 2023 00:36:26 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Ferenc: comments 1 and 2 The code looks good to me now. I still suggest to

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v3]

2023-05-22 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Ferenc: comments 1 and 2 - Changes: - all: https://git.openjdk.org/jdk/pull/13940/files - new: https://git.openjdk.org/jdk/

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Mark Powers
On Fri, 19 May 2023 19:58:10 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Ferenc: comments 2 and 4 >> - oops >> - Sean's comments >> - added @run > > test/jdk/sun/security/tools/jarsigner/V

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Mark Powers
On Fri, 19 May 2023 20:51:31 GMT, Weijun Wang wrote: >> test/jdk/sun/security/provider/lms/TestLMS.java line 30: >> >>> 28: * @summary tests for HSS/LMS provider >>> 29: * @modules java.base/sun.security.util >>> 30: * @run testng/othervm TestLMS >> >> Why is the test run with `testng`, can

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Weijun Wang
On Fri, 19 May 2023 20:08:08 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Ferenc: comments 2 and 4 >> - oops >> - Sean's comments >> - added @run > > test/jdk/sun/security/provider/lms/Test

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Sean Mullan
On Fri, 19 May 2023 16:59:58 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with four additional > commits since the last revision: > > - Ferenc: comments 2 and 4 > - oops > - Sean's comments > - added @run

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

2023-05-19 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8307794 Mark Powers has updated the pull request incrementally with four additional commits since the last revision: - Ferenc: comments 2 and 4 - oops - Sean's comments - added @run - Changes: - all: https://git.openjdk.org/jdk/pull/13940

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification

2023-05-18 Thread Mark Powers
On Thu, 18 May 2023 13:18:12 GMT, Sean Mullan wrote: >> https://bugs.openjdk.org/browse/JDK-8307794 > > test/jdk/sun/security/tools/jarsigner/DisableLMS.java line 26: > >> 24: /* >> 25: * @test >> 26: * @bug JDK-8307794 > > I think the bug here should be what it is testing, which is the HSS/L

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification

2023-05-18 Thread Sean Mullan
On Thu, 11 May 2023 19:06:59 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8307794 test/jdk/sun/security/tools/jarsigner/DisableLMS.java line 26: > 24: /* > 25: * @test > 26: * @bug JDK-8307794 I think the bug here should be what it is testing, which is the HSS/LMS implement

Re: RFR: JDK-8307794 Test for HSS/LMS Signature Verification

2023-05-18 Thread Ferenc Rakoczi
On Thu, 11 May 2023 19:06:59 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8307794 I suggest the following: 1. Separate the data from the code and put the data to the end of the files (e.g. create a " TestCase[] testCases;" array and let the TestCase class handle the creation