On Mon, 12 May 2025 10:17:46 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with two additional
> commits since the last revisi
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote:
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 314:
> 312: *
> 313: * WARNING
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote:
> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and
> its implementation (FilePermCompat.java) used by the test is moved to java.io
> FilePermission where cross package access is not needed.
&
On Mon, 14 Apr 2025 16:14:03 GMT, Roger Riggs wrote:
>> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and
>> its implementation (FilePermCompat.java) used by the test is moved to
>> java.io FilePermission where cross package access is not ne
the internal
> implementation in FilePermission.
> Modernized the initialization from the system property
> `jdk.io.permissionsUseCanonicalPath`.
> The remaining support will be removed when FilePermission is removed.
Roger Riggs has updated the pull request incrementally with one addi
On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote:
>> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10
>> anonymous classes, which slows down the startup. This PR is to improve
>> KnownOIDs and eliminate unnecessary embedded classes.
>>
>>
>> Here's how to reproduce this:
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote:
> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and
> its implementation (FilePermCompat.java) used by the test is moved to java.io
> FilePermission where cross package access is not needed.
&
The JavaIOFilePermissionAccess interface is removed from SharedSecrets and its
implementation (FilePermCompat.java) used by the test is moved to java.io
FilePermission where cross package access is not needed.
The test FilePermissionCollectionMerge is updated to access the internal
implementati
mePermission,
> and SerializablePermission
>
> @Deprecated(forRemoval = true, since="25")
> Is added to each class and the existing @apiNote is converted to @deprected
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental web
On Tue, 8 Apr 2025 06:41:41 GMT, Alan Bateman wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 addi
On Fri, 4 Apr 2025 12:37:32 GMT, Roger Riggs wrote:
> Now that the Security Manager is permanently disabled, the following
> permission classes in the core libraries area can be deprecated for removal
> as they are no longer useful: FilePermission, LinkPermission,
> Loggi
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote:
>> Please review this change to terminally deprecate the following security
>> related permission classes: `java.security.UnresolvedPermission`,
>> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
>> `javax.security.auth.P
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote:
>> Please review this change to terminally deprecate the following security
>> related permission classes: `java.security.UnresolvedPermission`,
>> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
>> `javax.security.auth.P
mePermission,
> and SerializablePermission
>
> @Deprecated(forRemoval = true, since="25")
> Is added to each class and the existing @apiNote is converted to @deprected
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
mePermission,
> and SerializablePermission
>
> @Deprecated(forRemoval = true, since="25")
> Is added to each class and the existing @apiNote is converted to @deprected
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
R
mePermission,
> and SerializablePermission
>
> @Deprecated(forRemoval = true, since="25")
> Is added to each class and the existing @apiNote is converted to @deprected
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
U
mePermission,
> and SerializablePermission
>
> @Deprecated(forRemoval = true, since="25")
> Is added to each class and the existing @apiNote is converted to @deprected
Roger Riggs has updated the pull request incrementally with one additional
commit since the last re
On Fri, 4 Apr 2025 18:04:39 GMT, Sean Mullan wrote:
>> Please review this change to terminally deprecate the following security
>> related permission classes: `java.security.UnresolvedPermission`,
>> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
>> `javax.security.auth.P
mePermission,
> and SerializablePermission
>
> @Deprecated(forRemoval = true, since="25")
> Is added to each class and the existing @apiNote is converted to @deprected
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
mePermission,
> and SerializablePermission
>
> @Deprecated(forRemoval = true, since="25")
> Is added to each class and the existing @apiNote is converted to @deprected
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Now that the Security Manager is permanently disabled, the following permission
classes in the core libraries area can be deprecated for removal as they are no
longer useful: FilePermission, LinkPermission, LoggingPermission,
PropertyPermission, ReflectPermission, RuntimePermission, and
Seriali
On Tue, 11 Mar 2025 15:15:39 GMT, Mikhail Yankelevich
wrote:
> 8351566: Consolidate third party artifacts used in tests
test/jdk/sun/security/pkcs11/PKCS11Test.java line 45:
> 43: import java.security.spec.ECGenParameterSpec;
> 44: import java.security.spec.ECParameterSpec;
> 45: import java.u
On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote:
> Cleanup the single use of JavaLangAccess.exit() it is no longer necessary;
> System.exit() can be called directly.
This pull request has now been integrated.
Changeset: 19154f7a
Author: Roger Riggs
URL:
https://git.openj
On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote:
> Cleanup the single use of JavaLangAccess.exit() it is no longer necessary;
> System.exit() can be called directly.
There are other non-recoverable errors that occur in the runtime that throw
InternalError or AssertionError inst
Cleanup the single use of JavaLangAccess.exit() it is no longer necessary;
System.exit() can be called directly.
-
Commit messages:
- 8351970: Retire JavaLangAccess::exit
Changes: https://git.openjdk.org/jdk/pull/24066/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24066&
On Sat, 8 Feb 2025 08:44:04 GMT, Shaojin Wen wrote:
>> You could define the static field on another class, like SecurityConstants,
>> and then use it in the enum constructor.
>
> Creating a new empty string array every time is the original behavior, which
> has nothing to do with the purpose of
On Sun, 2 Feb 2025 19:35:03 GMT, Shaojin Wen wrote:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
On Tue, 14 Jan 2025 13:15:58 GMT, Sean Mullan wrote:
>> Some additional removal of calls to SM APIs from security library tests. One
>> test is removed since it is no longer an issue.
>
> Sean Mullan has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
On Wed, 18 Dec 2024 15:00:13 GMT, Roger Riggs wrote:
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
This pull request has now been integra
On Mon, 13 Jan 2025 13:36:53 GMT, Sean Mullan wrote:
> Some additional removal of calls to SM APIs from security library tests. One
> test is removed since it is no longer an issue.
Good cleanup.
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pu
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roge
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
On Wed, 18 Dec 2024 17:27:24 GMT, Weijun Wang wrote:
> Will this ever happen?
>
> https://github.com/openjdk/jdk/blob/020255a72dc374ba0bdd44772047f14a8bfe69a9/test/lib/jdk/test/lib/jfr/TestClassLoader.java#L63
Yes, (my first pass removed the exception handling and tests failed).
A SecurityExcep
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
SM Cleanup of common test library test/lib/...:
Remove unnecessary catches of SecurityException
Remove AccessController and doPrivileged from SimpleSSLContext and ProcessTools.
-
Commit messages:
- 8346468: SM cleanup of common test library
Changes: https://git.openjdk.org/jdk/pull
On Mon, 9 Dec 2024 15:45:42 GMT, Magnus Ihse Bursie wrote:
>> That git query isn't correct for all the files in the repo. In particular,
>> the copyrights on third party files are NOT updated uniformly when new
>> versions are applied. In particular, XML files are NOT updated.
>
>> That git que
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
This pull request has now been integrated.
Changeset: fcf185c8
Author: Roger Riggs
URL:
https://git.openjdk.org/j
On Tue, 3 Dec 2024 14:53:41 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove an obsolete comment related to long ago removed useNewThrowable
>
> src/jav
On Tue, 3 Dec 2024 09:40:39 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into 8345325-sm-remove-getpropert
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove an obsolete comment related to long ago removed useNew
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 15 commits:
- Merge branch 'master' into 8345325-sm-remov
On Mon, 2 Dec 2024 20:59:53 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security` and `sun.security`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>>
>> This should cover most of the remaining cl
On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security` and `sun.security`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>>
>> This should cover most of the remaining cl
On Mon, 2 Dec 2024 20:40:23 GMT, Eirik Bjørsnøs wrote:
>> Yes, with Sean's changes in #22418, GetPropertyAction et.al. is deleted.
>
> @RogerRiggs Alan may have referred to the import of `java.util.Properties`.
Right, thanks
-
PR Review Comment: https://git.openjdk.org/jdk/pull/224
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with two additional
commits since the last revision:
- Remove unused import of Properties
- Update copyrights
Remove jdk/sun/securi
On Mon, 2 Dec 2024 20:19:23 GMT, Alan Bateman wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line
> 710:
>
>> 708:
>> 709: static {
>> 710: Properties p
Remove sun/security/action/GetPropertyAction.java and all uses.
Dependent on PR#22418
-
Depends on: https://git.openjdk.org/jdk/pull/22418
Commit messages:
- 8345325: SM cleanup of GetPropertyAction in java.base
Changes: https://git.openjdk.org/jdk/pull/22497/files
Webrev: https
On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security` and `sun.security`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>>
>> This should cover most of the remaining c
On Mon, 25 Nov 2024 21:22:10 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, `java.security.cert` API and impl
> dependencies on `AccessController.doPrivileged` can be removed.
Looks good, very direct refactoring.
-
Marked as reviewed by rriggs (Reviewer).
PR Rev
On Mon, 25 Nov 2024 20:33:49 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, the `javax.security` package
>> implementation dependencies on `System.getSecurityManager`,
>> `AccessController.doPrivileged` and `AccessControlContext` can be removed.
>>
>> Most of the changes are
On Mon, 25 Nov 2024 17:40:12 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, the `javax.security` package
> implementation dependencies on `System.getSecurityManager`,
> `AccessController.doPrivileged` and `AccessControlContext` can be removed.
>
> Most of the changes are strai
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote:
> This PR proposes to use `StaticProperty.javaHome()` instead of
> `System.getPropoerty("java.home")` in some internal classes.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22214#pullreq
On Tue, 19 Nov 2024 16:53:27 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
Looks good
src/java.base/share/classes/java/io/FilePermission.java line 184:
> 182: DefaultFileSystemProvider.theFileSys
On Thu, 14 Nov 2024 20:28:31 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 19:53:42 GMT, Sean Mullan wrote:
>> Now that JEP 486 is integrated, the jdk.crypto.mscapi module implementation
>> dependencies on System.getSecurityManager and AccessController.doPrivileged
>> can be removed.
>
> Sean Mullan has updated the pull request incrementally with o
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Wed, 13 Nov 2024 20:27:01 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>
> Sean Mullan has updated the pull request incrementally
On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
On Wed, 13 Nov 2024 22:03:37 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, java.security.sasl implementation
> dependencies on AccessController.doPrivileged can be removed.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pu
On Wed, 13 Nov 2024 14:44:06 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki`
> implementation dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged` can be removed.
LGTM
src/jdk.crypto.cryptoki/share/classes/sun/security/pkc
On Tue, 12 Nov 2024 18:47:46 GMT, Alan Bateman wrote:
>> Removes the SecurityManager usage from Thread + friends.
>>
>> In Thread, the getContextClassLoader method is no longer caller-sensitive
>> method.
>>
>> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
>> longer
On Tue, 12 Nov 2024 18:47:46 GMT, Alan Bateman wrote:
>> Removes the SecurityManager usage from Thread + friends.
>>
>> In Thread, the getContextClassLoader method is no longer caller-sensitive
>> method.
>>
>> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
>> longer
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 12 Nov 2024 13:01:33 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 4 Nov 2024 15:04:55 GMT, Weijun Wang wrote:
>> test/jdk/sun/security/provider/acvp/Launcher.java line 34:
>>
>>> 32: * @bug 8342442
>>> 33: * @library /test/lib
>>> 34: */
>>
>> This seems more like an '@driver' type of test than the implied `@run` test.
>
> But this is the only main
On Mon, 4 Nov 2024 16:03:26 GMT, Weijun Wang wrote:
>> Here we have a launcher and several algorithm-specific tests. Users can
>> populate "internalProjection.json" files generated by NIST's ACVP Server
>> into the `data` directory and test them with the launcher.
>>
>> Currently, only SHA2, S
On Fri, 1 Nov 2024 18:32:53 GMT, Weijun Wang wrote:
>> Here we have a launcher and several algorithm-specific tests. Users can
>> populate "internalProjection.json" files generated by NIST's ACVP Server
>> into the `data` directory and test them with the launcher.
>>
>> Currently, only SHA2, S
On Fri, 1 Nov 2024 16:25:25 GMT, Weijun Wang wrote:
>> Here we have a launcher and several algorithm-specific tests. Users can
>> populate "internalProjection.json" files generated by NIST's ACVP Server
>> into the `data` directory and test them with the launcher.
>>
>> Currently, only SHA2, S
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 29 Oct 2024 12:40:59 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 28 Oct 2024 12:29:07 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 28 Oct 2024 12:29:07 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 21:54:25 GMT, Sean Mullan wrote:
>> test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java line 241:
>>
>>> 239: Properties props = System.getProperties();
>>> 240: props.setProperty(JDK_LANG_PROCESS_ALLOW_AMBIGUOUS_COMMANDS,
>>> "");
>>> 241: System.s
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote:
>> Please review this PR which removes occurrences of 'applet' within the
>> corelibs specification. Applet has been deprecated since JDK9, and may be a
>> confusing term for new Java developers, so it should be removed from the
>> documentati
On Tue, 23 Jul 2024 04:10:38 GMT, Chen Liang wrote:
> Removed redundant APIs in `JavaLangReflectAccess` and added general warning
> against using `SharedSecrets`.
src/java.base/share/classes/java/lang/reflect/Constructor.java line 168:
> 166: }
> 167:
> 168: /** Creates a new root con
On Tue, 23 Jul 2024 04:10:38 GMT, Chen Liang wrote:
> Removed redundant APIs in `JavaLangReflectAccess` and added general warning
> against using `SharedSecrets`.
The description should include a summary of the changes and the rationale.
The Jira description is a bit better and could also be mo
On Sat, 6 Jul 2024 00:15:04 GMT, Shaojin Wen wrote:
>> String.format is widely used, and improving its performance is very
>> meaningful. This PR can significantly improve the performance of
>> String.format. Sorry, there are many changes, which will take a lot of time.
>> I hope you can revie
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Wed, 24 Jan 2024 17:57:38 GMT, Oli Gillespie wrote:
>> src/java.base/share/classes/java/security/Provider.java line 1560:
>>
>>> 1558: final boolean supportsParameter;
>>> 1559: final String constructorParameterClassName;
>>> 1560: private volatile Class constructorPar
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Small space optimization.
Thanks for the updates. LG
On Wed, 10 Jan 2024 17:41:41 GMT, Raffaello Giulietti
wrote:
>> The spec is silent about methods being 'native'; it would generally be
>> impractical to implement native methods for these purposes, but a native
>> method can implement the behavior.
>
> @RogerRiggs The checks are agnostic about
On Tue, 19 Dec 2023 15:58:10 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 185:
>>
>>> 183: commitEvent(PRIV_METH_NON_STATIC,
>>> 184: m + " must be non-static to be effective");
>>> 185:
On Wed, 10 Jan 2024 15:43:46 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Changes according to reviewers feedback.
src/java.bas
On Tue, 9 Jan 2024 10:41:31 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 53:
>>
>>> 51: private static final Class[] READ_OBJECT_NO_DATA_PARAM_TYPES =
>>> {};
>>> 52: private static final Class[] WRITE_REPLACE_P
On Wed, 10 Jan 2024 14:58:37 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/math/BigInteger.java line 3998:
>>
>>> 3996: int i = ArraysSupport.mismatch(m1, m2, len1);
>>> 3997: if (i != -1)
>>> 3998: return Integer.compareUnsigned(m1[i], m2[i]) <
On Wed, 10 Jan 2024 11:27:53 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-ye
On Tue, 2 Jan 2024 14:37:27 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-yet
On Mon, 8 Jan 2024 13:48:06 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
On Thu, 21 Dec 2023 09:53:10 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Corrected @Label of event and of field.
src/java.base
1 - 100 of 179 matches
Mail list logo
