On Wed, 13 Nov 2024 14:44:06 GMT, Sean Mullan <mul...@openjdk.org> wrote:
> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki`
> implementation dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged` can be removed.
LGTM
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java line 72:
> 70: }
> 71: osName = System.getProperty("os.name");
> 72: osArch = System.getProperty("os.arch");
osName and osArch seem to be unused; they could be removed but might be out of
scope for this PR.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22077#pullrequestreview-2433552784
PR Review Comment: https://git.openjdk.org/jdk/pull/22077#discussion_r1840546297
