On Tue, 23 Jul 2024 04:10:38 GMT, Chen Liang <li...@openjdk.org> wrote:
> Removed redundant APIs in `JavaLangReflectAccess` and added general warning > against using `SharedSecrets`. src/java.base/share/classes/java/lang/reflect/Constructor.java line 168: > 166: } > 167: > 168: /** Creates a new root constructor with a custom accessor for > serialization hooks. */ Preserve "/**" comments for generated javadoc, a "//" comment would be more appropriate for a 1-liner. src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java line 53: > 51: //</editor-fold> > 52: > 53: //<editor-fold defaultstate="collapsed" desc="AccessibleObject > Copying"> Personal editor comments should not be included. src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java line 68: > 66: > 67: //</editor-fold> > 68: Remove ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20290#discussion_r1692174982 PR Review Comment: https://git.openjdk.org/jdk/pull/20290#discussion_r1692164266 PR Review Comment: https://git.openjdk.org/jdk/pull/20290#discussion_r1692165039
