On Sat, 8 Feb 2025 08:44:04 GMT, Shaojin Wen <s...@openjdk.org> wrote:

>> You could define the static field on another class, like SecurityConstants, 
>> and then use it in the enum constructor.
>
> Creating a new empty string array every time is the original behavior, which 
> has nothing to do with the purpose of this PR. Should we follow the principle 
> of minimal changes? If we want to change it, we should submit another PR

Fine either way, its a fuzzy cutoff between an incidental improvement (also 
perf related) with the same reviewers or a new PR with a new set of emails and 
reviewers.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23411#discussion_r1949275626

Reply via email to