On Thu, 29 May 2025 16:50:49 GMT, Sean Mullan wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional sentence to the apiNote
>
> src/java.base/share/classes/java/net/URLClassLoader.java line 87:
>
>> 85:
> Can I please get a review of this doc-only change which proposes to add an
> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` to
> explain the current implementation of these constructors? This addresses
> https://bugs.openjdk.org/browse/JDK-8228773?
>
> As noted in
On Thu, 29 May 2025 16:43:46 GMT, Alan Bateman wrote:
>>> something like "See Run-time Built-in Class Loaders for information on the
>>> system class loader other and the other built-in class loaders". I think
>>> that might work.
>>
>> Done. Updated the PR with this text.
>
> Ah, I see I said
On Thu, 29 May 2025 17:48:18 GMT, Nibedita Jena wrote:
>> Generate intermediate/temporary files into the work directory, not in the
>> test source directory.
>
> Nibedita Jena has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Streamline of c
On Fri, 6 Dec 2024 19:36:09 GMT, Francisco Ferrari Bihurriet
wrote:
> Hi, this pull request implements the fixes for bugs and inconsistencies
> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix
> bugs and inconsistencies in the Provider services map").
>
> New s
On Fri, 30 May 2025 01:13:48 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is complete/approved.
>>
>> Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK
>> API (jck:api/java_secu
On Thu, 29 May 2025 20:35:33 GMT, Artur Barashev wrote:
>> The stateless session ticket is included in the ClientHello message, either
>> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key
>> extension (TLS1.3). With the current construction, the ticket is often the
>> la
On Thu, 29 May 2025 14:42:00 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Remove TlsExporterKeyingMaterial for now.
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
> respectively.
>
> CSR is complete/approved.
>
> Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK
> API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net
> jck:api/javax_securi
On Thu, 29 May 2025 23:32:59 GMT, Weijun Wang wrote:
>> I need a code review to throw `InvalidKeySpecException` when null is passed
>> with `generatePublic()` and `generatePrivate()`. This change takes the
>> opportunity to modernize the KeyFactory code by using `switch` syntax for
>> `instan
On Thu, 29 May 2025 00:54:37 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is complete/approved.
>>
>> Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK
>> API (jck:api/java_secu
On Thu, 29 May 2025 22:38:41 GMT, Anthony Scarpino
wrote:
> I need a code review to throw `InvalidKeySpecException` when null is passed
> with `generatePublic()` and `generatePrivate()`. This change takes the
> opportunity to modernize the KeyFactory code by using `switch` syntax for
> `inst
I need a code review to throw `InvalidKeySpecException` when null is passed
with `generatePublic()` and `generatePrivate()`. This change takes the
opportunity to modernize the KeyFactory code by using `switch` syntax for
`instanceof` checking, as well as, keeping the previous design of the
imp
On Thu, 29 May 2025 19:06:15 GMT, Sean Coffey wrote:
> Removal of the `+thread` and `+timestamp` options that were used to control
> the logging behavior of output from the `java.security.debug` system property.
>
>
> To enhance the security debug logs, the thread and timestamp data should
>
On Thu, 29 May 2025 14:22:16 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Remove TlsExporterKeyingMaterial for now.
On Thu, 29 May 2025 11:17:50 GMT, Hai-May Chao wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Remove TlsExporterKeyingMaterial for now.
On Thu, 29 May 2025 19:06:15 GMT, Sean Coffey wrote:
> Removal of the `+thread` and `+timestamp` options that were used to control
> the logging behavior of output from the `java.security.debug` system property.
>
>
> To enhance the security debug logs, the thread and timestamp data should
>
On Thu, 29 May 2025 14:12:47 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Remove TlsExporterKeyingMaterial for now.
> The stateless session ticket is included in the ClientHello message, either
> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key
> extension (TLS1.3). With the current construction, the ticket is often the
> largest contributor to the ClientHello message size. For example
On Thu, 29 May 2025 14:09:38 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Remove TlsExporterKeyingMaterial for now.
> The stateless session ticket is included in the ClientHello message, either
> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key
> extension (TLS1.3). With the current construction, the ticket is often the
> largest contributor to the ClientHello message size. For example
On Thu, 29 May 2025 14:08:10 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Remove TlsExporterKeyingMaterial for now.
On Sun, 2 Feb 2025 19:35:03 GMT, Shaojin Wen wrote:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
On Tue, 27 May 2025 23:37:45 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 36 commits:
>>
>> - Remove TlsExporterKeyingMaterial for now. Can add later if needed.
>> - Merge branc
Removal of the `+thread` and `+timestamp` options that were used to control the
logging behavior of output from the `java.security.debug` system property.
To enhance the security debug logs, the thread and timestamp data should always
be present. This brings it to a par with another important s
On Mon, 26 May 2025 08:20:19 GMT, Magnus Ihse Bursie wrote:
>> I found a few other places in the code that can be cleaned up after the
>> conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Restore
On Thu, 29 May 2025 17:48:18 GMT, Nibedita Jena wrote:
>> Generate intermediate/temporary files into the work directory, not in the
>> test source directory.
>
> Nibedita Jena has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Streamline of c
> Generate intermediate/temporary files into the work directory, not in the
> test source directory.
Nibedita Jena has updated the pull request incrementally with one additional
commit since the last revision:
Streamline of code
-
Changes:
- all: https://git.openjdk.org/jdk/pu
On Thu, 29 May 2025 14:35:11 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Thu, 29 May 2025 14:19:08 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to add an
>> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader`
>> to explain the current implementation of these constructors? This addresses
>> ht
On Thu, 29 May 2025 14:16:36 GMT, Jaikiran Pai wrote:
>>> Should we use this?
>>
>> I missed Alan's suggestion to add a separate sentence linking to the
>> ClassLoader section. I will update this PR accordingly.
>
>> something like "See Run-time Built-in Class Loaders for information on the
>>
Hi Sebastian.
> On May 24, 2025, at 05:40, Sebastian Stenzel
> wrote:
>
> Hi all,
>
> For the past few months I have been in contact with one of the authors of two
> spec drafts for future JOSE encryption standards [1] [2] with the latter of
> them relying on X-Wing.
>
> As the X-Wing spec
On Thu, 29 May 2025 14:26:06 GMT, Artur Barashev wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 326:
>>
>>> 324: }
>>> 325:
>>> 326: this.useExtendedMasterSecret = false;
>>
>> This is probably not needed, but ok to stay.
>>
>> If you
On Thu, 29 May 2025 14:19:08 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to add an
>> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader`
>> to explain the current implementation of these constructors? This addresses
>> ht
On Thu, 29 May 2025 00:54:37 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is complete/approved.
>>
>> Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK
>> API (jck:api/java_secu
On Tue, 27 May 2025 20:51:51 GMT, Bradford Wetmore wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comments. Optimize imports.
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 289:
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Wed, 28 May 2025 21:42:07 GMT, Bradford Wetmore wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comments. Optimize imports.
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 326:
On Thu, 29 May 2025 00:39:53 GMT, Bradford Wetmore wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comments. Optimize imports.
>
> test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java line 177:
> Can I please get a review of this doc-only change which proposes to add an
> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` to
> explain the current implementation of these constructors? This addresses
> https://bugs.openjdk.org/browse/JDK-8228773?
>
> As noted in
On Thu, 29 May 2025 14:01:16 GMT, Jaikiran Pai wrote:
>>> Should we add a link to {@linkplain ClassLoader##builtinLoaders ...}
>>> somewhere in this API note?
>>
>> I think we can add that as a link for "bootstrap class loader". Something
>> like:
>>
>>
>> * @apiNote If the {@code parent} i
On Thu, 29 May 2025 03:06:25 GMT, Bradford Wetmore wrote:
>> Could you please post a link to the guide where it says so? I've found a
>> couple of Oracle examples and both use different switch/case levels:
>>
>> 1. https://docs.oracle.com/javase/tutorial/java/nutsandbolts/switch.html
>> 2.
>>
On Thu, 29 May 2025 13:45:02 GMT, Jaikiran Pai wrote:
> Should we use this?
I missed Alan's suggestion to add a separate sentence linking to the
ClassLoader section. I will update this PR accordingly.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25517#discussion_r21140452
On Thu, 29 May 2025 13:40:10 GMT, Alan Bateman wrote:
there is no guarantee that all platform classes are visible
>>>
>>> sounds (to me) like the behaviour is undefined (which is not the case). A
>>> link to the place where the various class loaders are discussed might
>>> clarify that.
On Thu, 29 May 2025 13:20:28 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/net/URLClassLoader.java line 82:
>>
>>> 80: * @apiNote If the {@code parent} is specified as {@code null} (for
>>> the
>>> 81: * bootstrap class loader) then there is no guarantee that all
>>> p
On Thu, 29 May 2025 08:00:40 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's suggestion - replace default delegation class loader with system
>> class loader
>
> src/java.base/share/classe
> Can I please get a review of this doc-only change which proposes to add an
> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` to
> explain the current implementation of these constructors? This addresses
> https://bugs.openjdk.org/browse/JDK-8228773?
>
> As noted in
On Thu, 29 May 2025 08:28:12 GMT, Daniel Fuchs wrote:
>> there is no guarantee that all platform classes are visible
>
> sounds (to me) like the behaviour is undefined (which is not the case). A
> link to the place where the various class loaders are discussed might clarify
> that.
Alan's su
On Thu, 29 May 2025 05:26:07 GMT, Nibedita Jena wrote:
>> Generate intermediate/temporary files into the work directory, not in the
>> test source directory.
>
> Nibedita Jena has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed test bu
On Thu, 1 May 2025 13:01:38 GMT, Weijun Wang wrote:
>> The private key encoding formats of ML-KEM and ML-DSA are updated to match
>> the latest IETF drafts at:
>> https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-08
>> and
>> https://datatracker.ietf.org/doc/html/d
On Thu, 29 May 2025 00:54:37 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is complete/approved.
>>
>> Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK
>> API (jck:api/java_secu
On Wed, 28 May 2025 15:25:27 GMT, Weijun Wang wrote:
>> src/java.security.jgss/share/classes/sun/security/krb5/Config.java line 774:
>>
>>> 772: result.add(previous);
>>> 773: unwritten.forEach(result::add);
>>> 774: unwritten.clear();
On Mon, 26 May 2025 20:39:51 GMT, Mark Sheppard wrote:
> You could take a slightly more radical approach, and rather than applying a
> filter explicitly on the exception message, adopt a builder pattern for the
> creation of the filter exceptions, for example
>
> FilteredExceptionBuilder / Enh
On Wed, 28 May 2025 23:13:21 GMT, Mark Sheppard wrote:
> here are a few files with IOException, UnknownHostException and
> MalformedURLException, which are worth reviewing for Exception that may have
> been missed
>
> IOEXception:
>
> open/src/java.base/share/classes/sun/net/www/protocol/http
On Thu, 29 May 2025 05:57:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which proposes to add an
> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` to
> explain the current implementation of these constructors? This addresses
> https:
On Thu, 29 May 2025 05:57:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which proposes to add an
> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` to
> explain the current implementation of these constructors? This addresses
> https:
56 matches
Mail list logo
