On Wed, 28 May 2025 21:42:07 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comments. Optimize imports. > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 326: > >> 324: } >> 325: >> 326: this.useExtendedMasterSecret = false; > > This is probably not needed, but ok to stay. > > If you like this style, then you could explicitly add the default > `this.preSharedKey = null` for the TLSv1.3+ case around line 340. It is actually needed because `useExtendedMasterSecret` is final, unlike `preSharedKey`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25310#discussion_r2114090606
