On Tue, 27 May 2025 23:37:45 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 36 commits: >> >> - Remove TlsExporterKeyingMaterial for now. Can add later if needed. >> - Merge branch 'master' into JDK-8341346 >> - Merge branch 'master' into JDK-8341346 >> - Added PKCS11 testing >> - Minor bug >> - Missed one change >> - Merge branch 'master' into JDK-8341346 >> - Private Codereview comment: Don't allow use of null keyAlgs, plus some >> minor cleanups >> - get*() no longer needed, backout error (oops!) >> - Merge branch 'master' into JDK-8341346 >> - ... and 26 more: https://git.openjdk.org/jdk/compare/66747710...67480e99 > > src/java.base/share/classes/com/sun/crypto/provider/TlsPrfGenerator.java line > 1: > >> 1: /* > > Not related to this PR, but `engineGenerateKey0` method should be `protected` I will go ahead and tweak it. Shouldn't be a problem. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24976#discussion_r2114662829
