On Thu, 29 May 2025 14:08:10 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 37 commits: >> >> - Merge branch 'master' into JDK-8341346 >> - Remove TlsExporterKeyingMaterial for now. Can add later if needed. >> - Merge branch 'master' into JDK-8341346 >> - Merge branch 'master' into JDK-8341346 >> - Added PKCS11 testing >> - Minor bug >> - Missed one change >> - Merge branch 'master' into JDK-8341346 >> - Private Codereview comment: Don't allow use of null keyAlgs, plus some >> minor cleanups >> - get*() no longer needed, backout error (oops!) >> - ... and 27 more: https://git.openjdk.org/jdk/compare/2ec6ab34...858362c8 > > src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java line 176: > >> 174: * RFC 8446 (TLSv1.3) treats a null context as non-null/empty. >> 175: * <P> >> 176: * The {@code label} {@code String} will be converted to bytes using > > Two consecutive `{@code}` look a little strange to me, visually. How about > just `{@code label} will be...`? You already use that in `@param label`. Same > as in the other method. Done. * {@code label} will be converted to bytes using * the {@link java.nio.charset.StandardCharsets#UTF_8} * character encoding. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24976#discussion_r2114679469
