Re: [sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-15 Thread Volker Braun
On Friday, August 15, 2014 8:12:40 AM UTC+1, Snark wrote: > > Trivial patches require a mail, normal patches require a ticket, big > contributions require a ticket and a branch with tidy patches -- this is > how reasonable free software projects work. PS: Somewhat negatively correlated with pro

Re: [sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-15 Thread Volker Braun
On Friday, August 15, 2014 8:12:40 AM UTC+1, Snark wrote: > > Why did I still make the effort? Because I'm not a new contributor > If you were new to Sage then I wouldn't have minded the mailed patch, but you know git so use it ;-) -- You received this message because you are subscribed to the

Re: [sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-15 Thread Julien Puydt
Le 15/08/2014 05:33, Robert Bradshaw a écrit : On Tue, Aug 12, 2014 at 11:59 AM, Julien Puydt wrote: Hi, Le 12/08/2014 20:50, Dima Pasechnik a écrit : On 2014-08-12, Julien Puydt wrote: This is a multi-part message in MIME format. --000505020108050907050407 Content-Type: tex

Re: [sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-14 Thread Robert Bradshaw
On Tue, Aug 12, 2014 at 11:59 AM, Julien Puydt wrote: > Hi, > > Le 12/08/2014 20:50, Dima Pasechnik a écrit : > >> On 2014-08-12, Julien Puydt wrote: >>> >>> This is a multi-part message in MIME format. >>> --000505020108050907050407 >>> Content-Type: text/plain; charset=UTF-8; format

[sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-12 Thread Dima Pasechnik
On 2014-08-12, Julien Puydt wrote: > Hi, > > Le 12/08/2014 20:50, Dima Pasechnik a écrit : >> On 2014-08-12, Julien Puydt wrote: >>> This is a multi-part message in MIME format. >>> --000505020108050907050407 >>> Content-Type: text/plain; charset=UTF-8; format=flowed >>> >>> Hi, >>> >

Re: [sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-12 Thread Julien Puydt
Hi, Le 12/08/2014 20:50, Dima Pasechnik a écrit : On 2014-08-12, Julien Puydt wrote: This is a multi-part message in MIME format. --000505020108050907050407 Content-Type: text/plain; charset=UTF-8; format=flowed Hi, I'm proposing the following patch to remove duplication in the s

[sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-12 Thread Dima Pasechnik
On 2014-08-12, Julien Puydt wrote: > This is a multi-part message in MIME format. > --000505020108050907050407 > Content-Type: text/plain; charset=UTF-8; format=flowed > > Hi, > > I'm proposing the following patch to remove duplication in the > src/module_list.py file ; it's so simpl

Re: [sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-12 Thread Julien Puydt
Hi Le 12/08/2014 20:25, Volker Braun a écrit : Just make a ticket... On Tuesday, August 12, 2014 6:13:46 PM UTC+1, Snark wrote: Hi, I'm proposing the following patch to remove duplication in the src/module_list.py file ; it's so simple I don't think it's worth opening a ticket... Snark on

[sage-devel] Re: [PATCH] Putting some include paths in common

2014-08-12 Thread Volker Braun
Just make a ticket... On Tuesday, August 12, 2014 6:13:46 PM UTC+1, Snark wrote: > > Hi, > > I'm proposing the following patch to remove duplication in the > src/module_list.py file ; it's so simple I don't think it's worth > opening a ticket... > > Snark on #sagemath > -- You received thi

[sage-devel] Re: Patch made from a previous version of sage

2013-01-16 Thread Keshav Kini
Kannappan Sampath writes: > Hello friends,  > > I have the following question: The patch here: > > http://trac.sagemath.org/sage_trac/ticket/10080 > > seems to come from a previous version of the file for which it > proposes some change. Now, apparently, I feel that some of the issues > have been

[sage-devel] Re: Patch for matrix_plot.py, Feature enhancement.

2012-12-20 Thread P Purkayastha
Just a follow up. Did you create a ticket on this? If so, can you mention the ticket number here? On Thursday, November 1, 2012 12:42:58 AM UTC+8, Eymen A wrote: > > > > On Monday, October 29, 2012 10:25:39 PM UTC+1, Volker Braun wrote: >> >> Great! Can you make a trac account for yourself and a

[sage-devel] Re: Patch for matrix_plot.py, Feature enhancement.

2012-10-31 Thread Eymen A
On Monday, October 29, 2012 10:25:39 PM UTC+1, Volker Braun wrote: > > Great! Can you make a trac account for yourself and a ticket with your > patch? I have just applied for an account. Let's see. -- You received this message because you are subscribed to the Google Groups "sage-devel" gr

Re: [sage-devel] Re: Patch for matrix_plot.py, Feature enhancement.

2012-10-29 Thread D. S. McNeil
Cool! On Mon, Oct 29, 2012 at 5:25 PM, Volker Braun wrote: > Great! Can you make a trac account for yourself and a ticket with your > patch? The patch needs a commit message. Also, minor nitpick: > > if len(extent_) is not 4: > raise TypeError, "extent must be a list with 4 el

[sage-devel] Re: Patch for matrix_plot.py, Feature enhancement.

2012-10-29 Thread Volker Braun
Great! Can you make a trac account for yourself and a ticket with your patch? The patch needs a commit message. Also, minor nitpick: if len(extent_) is not 4: raise TypeError, "extent must be a list with 4 elements" should raise a ValueError not a TypeError. On Monday, Oct

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-20 Thread Ben Hutz
ok, thanks. I'll see what the md5 result is. -- -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: ht

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-20 Thread Keshav Kini
Ben Hutz writes: > Yes, is was the mail program that wrapped those lines. The whole > patch is quite long, so I think a link to it is better > > http://trac.sagemath.org/sage_trac/ticket/13130 No error here when I try to apply the patch (as expected). -Keshav Join us in #sagemath on irc.f

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-20 Thread Ben Hutz
Yes, is was the mail program that wrapped those lines. The whole patch is quite long, so I think a link to it is better http://trac.sagemath.org/sage_trac/ticket/13130 As it is only this one machine that seems to be giving this error, the md5 idea is a good suggestion. -- -- To post to this

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-20 Thread Keshav Kini
Dima Pasechnik writes: > On Friday, 20 July 2012 19:24:26 UTC+8, Ben Hutz wrote: > > It was created with hg export. I just copied out the portion for > the relevant file to post (the whole patch is on trac #13120). I > thought from Volker's comment that the "diff ..." was the > met

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-20 Thread Dima Pasechnik
On Friday, 20 July 2012 19:24:26 UTC+8, Ben Hutz wrote: > > It was created with hg export. I just copied out the portion for the > relevant file to post (the whole patch is on trac #13120). I thought from > Volker's comment that the "diff ..." was the metadata. Based on your > comment, that s

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-20 Thread Ben Hutz
It was created with hg export. I just copied out the portion for the relevant file to post (the whole patch is on trac #13120). I thought from Volker's comment that the "diff ..." was the metadata. Based on your comment, that seems to not be the case. What portion of the patch is the "metadata

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-20 Thread Dima Pasechnik
On Thursday, 19 July 2012 22:27:32 UTC+8, Ben Hutz wrote: > > I don't think I'm copying or moving the file. Below is the info from the > .patch file for ell_point.py. Also, there is only one machine that is > getting this error. > > diff --git a/sage/schemes/elliptic_curves/ell_point.py > b/s

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-19 Thread Ben Hutz
I don't think I'm copying or moving the file. Below is the info from the .patch file for ell_point.py. Also, there is only one machine that is getting this error. diff --git a/sage/schemes/elliptic_curves/ell_point.py b/sage/schemes/elliptic_curves/ell_point.py --- a/sage/schemes/elliptic_curv

[sage-devel] Re: patch 'failed to synchronize metadata'

2012-07-19 Thread Volker Braun
Your patch wants to copy or move sage/schemes/elliptic_curves/ell_point.py but can't for some reason. Does the source exist and is the destination writeable? On Thursday, July 19, 2012 8:30:27 AM UTC-4, Ben Hutz wrote: > > I have someone testing one of my patches and > > hg qpush -v > > retur

Re: [sage-devel] Re: Patch review checklist

2012-01-22 Thread William Stein
Hi, I just added something to the Review Checklist wiki page about optional packages, motivated by mistakes made on ticket 6329 [1], where both the patch authors (yours truly) and review completely forgot to worry about optional doctests, causing lots of breakage... [1] http://trac.sagemath.org/

[sage-devel] Re: Patch for numerical noise in stats/hmm/chmm.pyx (#12283) needs review

2012-01-09 Thread mhampton
OK, I checked it out and have given it a positive review (see comments on the ticket). -Marshall On Jan 9, 9:05 am, Keshav Kini wrote: > A link to the trac ticket page (the above links to the raw patch file): > > http://trac.sagemath.org/sage_trac/ticket/12283 > > -Keshav > > > Join us in #

[sage-devel] Re: Patch for numerical noise in stats/hmm/chmm.pyx (#12283) needs review

2012-01-09 Thread Keshav Kini
A link to the trac ticket page (the above links to the raw patch file): http://trac.sagemath.org/sage_trac/ticket/12283 -Keshav Join us in #sagemath on irc.freenode.net ! -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email t

[sage-devel] Re: Patch review checklist

2012-01-05 Thread kcrisman
On Jan 5, 9:59 pm, Michael Orlitzky wrote: > On 01/05/2012 09:28 PM, kcrisman wrote: > > > > >> Please, add anything I've left out. Checklists won't make a review good, > >> but they can prevent it from being too bad. > > > Hmm, maybe this should be added to the developer guide?  How much of > >

Re: [sage-devel] Re: Patch review checklist

2012-01-05 Thread Michael Orlitzky
On 01/05/2012 09:28 PM, kcrisman wrote: Please, add anything I've left out. Checklists won't make a review good, but they can prevent it from being too bad. Hmm, maybe this should be added to the developer guide? How much of your checklist is in the 'reviewing patches' section, and how much c

[sage-devel] Re: Patch review checklist

2012-01-05 Thread kcrisman
On Jan 5, 8:01 pm, Michael Orlitzky wrote: > I was compiling this for myself and remembered the wiki: > >    http://wiki.sagemath.org/ReviewChecklist > > Please, add anything I've left out. Checklists won't make a review good, > but they can prevent it from being too bad. Hmm, maybe this should

[sage-devel] Re: Patch uploaded what's next?

2011-08-17 Thread Rolf
> I am not an expert in sage development, but I promise I will have a > careful look to your tickets. Hi Jose, sounds good. Looking forward to. Best regards -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubsc

[sage-devel] Re: Patch uploaded what's next?

2011-08-17 Thread Rolf
> Another trick is to review someone else's ticket and then ask them to review > yours.  e.g. kcrisman has reviewed so many of my tickets that I would be > obliged to review anything he asked me to (assuming I were competent to do so > of course).  Unfortunately, I can't help with probability di

[sage-devel] Re: Patch uploaded what's next?

2011-08-17 Thread Rolf
> In the case of this ticket, there were some disagreements as well > about how to structure things in this module. Well I'm really sorry about this 'disagreement' which I feel is rather a misunderstanding. I thought we agreed upon quick release and postponement of these structural questions. Besi

[sage-devel] Re: Patch uploaded what's next?

2011-08-17 Thread kcrisman
On Aug 17, 4:26 am, Ivan Andrus wrote: > On Aug 16, 2011, at 10:51 PM, kcrisman wrote: > > >>> If the owner forgot about the ticket (holidays and stuff), I think it > >>> is perfectly fine if the author him- or herself asks on one of the > >>> sage lists (probably sage-devel is a good choice, or

Re: [sage-devel] Re: Patch uploaded what's next?

2011-08-17 Thread Ivan Andrus
On Aug 16, 2011, at 10:51 PM, kcrisman wrote: >>> If the owner forgot about the ticket (holidays and stuff), I think it >>> is perfectly fine if the author him- or herself asks on one of the >>> sage lists (probably sage-devel is a good choice, or a specialised >>> list if that exists for the give

Re: [sage-devel] Re: Patch uploaded what's next?

2011-08-17 Thread Jose Guzman
On 16/08/11 17:01, Rolf wrote: Sorry, my mistake. It's here http://trac.sagemath.org/sage_trac/ticket/11572 I even added some notebooks to test the new capabilities. http://www.sagenb.org/home/pub/2887 http://www.sagenb.org/home/pub/2886 Waiting for further suggestions. Best On 16 Aug., 16:37,

Re: [sage-devel] Re: Patch uploaded what's next?

2011-08-17 Thread Jose Guzman
On 16/08/11 17:01, Rolf wrote: Sorry, my mistake. It's here http://trac.sagemath.org/sage_trac/ticket/11572 I even added some notebooks to test the new capabilities. http://www.sagenb.org/home/pub/2887 http://www.sagenb.org/home/pub/2886 Waiting for further suggestions. Best On 16 Aug., 16:37,

[sage-devel] Re: Patch uploaded what's next?

2011-08-16 Thread kcrisman
> > If the owner forgot about the ticket (holidays and stuff), I think it > > is perfectly fine if the author him- or herself asks on one of the > > sage lists (probably sage-devel is a good choice, or a specialised > > list if that exists for the given topic). I think that "owner" is little more

Re: [sage-devel] Re: Patch uploaded what's next?

2011-08-16 Thread William Stein
On Tue, Aug 16, 2011 at 9:31 AM, Simon King wrote: > Hi Rolf, > > first of all, I am sorry that I can not review it, myself, since > probability distributions are very far from my own field. > > More experienced developers may correct me, but I thought that one of > the responsibilities of the own

[sage-devel] Re: Patch uploaded what's next?

2011-08-16 Thread Simon King
Hi Rolf, first of all, I am sorry that I can not review it, myself, since probability distributions are very far from my own field. More experienced developers may correct me, but I thought that one of the responsibilities of the owner of a ticket is to approach potential reviewers, if it is appa

[sage-devel] Re: Patch uploaded what's next?

2011-08-16 Thread Rolf
Sorry, my mistake. It's here http://trac.sagemath.org/sage_trac/ticket/11572 I even added some notebooks to test the new capabilities. http://www.sagenb.org/home/pub/2887 http://www.sagenb.org/home/pub/2886 Waiting for further suggestions. Best On 16 Aug., 16:37, Simon King wrote: > Hi Rolf, >

[sage-devel] Re: Patch uploaded what's next?

2011-08-16 Thread Simon King
Hi Rolf, On 16 Aug., 13:56, Rolf wrote: > Hello, > some weeks ago I uploaded a patch adding new probability > distributions. I even made the recommended changes immediatly. Nothing > happend ever since. Did I miss something? Where did you upload it? I.e., what trac ticket is it? Best regards, S

[sage-devel] Re: patch ticket says it was merged, but patch doesn't appear to be merged

2011-05-31 Thread Jason Grout
On 5/31/11 3:59 AM, Jeroen Demeyer wrote: On 2011-05-30 20:54, Jason Grout wrote: I just noticed that http://trac.sagemath.org/sage_trac/ticket/7002 says it was merged a long time ago, but the help file that you get when clicking "Help" in 4.7 in the notebook, the line "Autoevaluate Cells on L

[sage-devel] Re: Patch rejected after merge

2011-05-16 Thread daveloeffler
On May 15, 11:02 pm, Robert Miller wrote: > Jeroen Demeyer wrote: > > On 2011-05-13 07:24, Tom Boothby wrote: > >> Bottom line: I think this was handled wrong.  If a ticket's been > >> merged, unless it's found to have a genuine flaw, it should supersede > >> (IMO) tickets with positive reviews

Re: [sage-devel] Re: Patch submitting procedures

2011-04-11 Thread Jeroen Demeyer
On 2011-04-11 16:03, Jason Grout wrote: > Of course, temporarily the script could see if there was a ticket number > already starting the commit message, maybe a regular expression > something like (note: I haven't tested the following; it's likely that > I'm misremembering regexp syntax): > > ^([

[sage-devel] Re: Patch submitting procedures

2011-04-11 Thread Jason Grout
On 4/11/11 8:45 AM, Jeroen Demeyer wrote: On 2011-03-29 14:26, Jason Grout wrote: If the script automatically prepended: Trac #: to the start of every commit message, then: Done for sage-4.7.alpha5 Of course you get lots of silly commit messages like Trac #11141: #11141: add PolyGUI an

Re: [sage-devel] Re: Patch submitting procedures

2011-04-11 Thread Jeroen Demeyer
On 2011-03-29 14:26, Jason Grout wrote: > If the script automatically prepended: > > Trac #: > > to the start of every commit message, then: Done for sage-4.7.alpha5 Of course you get lots of silly commit messages like Trac #11141: #11141: add PolyGUI and cygdb to SAGE_LOCAL/bin/.hgignore

[sage-devel] Re: Patch submitting procedures

2011-04-04 Thread Keshav Kini
On Apr 4, 1:13 pm, William Stein wrote: > Great idea!  Post a ticket. This is now #11121 and awaits review :) -Keshav -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more option

[sage-devel] Re: Patch submitting procedures

2011-04-03 Thread Keshav Kini
On Apr 4, 3:23 am, William Stein wrote: > Could we change the default to "git = true" as a patch to the version > of hg we distribute with Sage?   Or, alternatively, have a patch that > prints a warning > whenever Sage's hg is used but git = false?   The second option would > be safer, since a use

Re: [sage-devel] Re: Patch submitting procedures

2011-04-03 Thread William Stein
On Sat, Apr 2, 2011 at 5:25 PM, Keshav Kini wrote: > Indeed. Mercurial's workflow is not really supposed to be carried out > by sending patches to people (the encouraged behavior is to use `hg > pull` from other people's repositories), so the default patch / export > format only includes a subset

[sage-devel] Re: Patch submitting procedures

2011-04-02 Thread Keshav Kini
Indeed. Mercurial's workflow is not really supposed to be carried out by sending patches to people (the encouraged behavior is to use `hg pull` from other people's repositories), so the default patch / export format only includes a subset of the total information so that it can be backwards compati

Re: [sage-devel] Re: Patch submitting procedures

2011-03-29 Thread David Roe
If the script automatically prepended: > > Trac #: > > to the start of every commit message, then: > > 1. the ticket number text would be uniform > > 2. if a wrong ticket number was indicated, it would be obvious which was > the correct ticket number, as it's always first in the standard forma

[sage-devel] Re: Patch submitting procedures

2011-03-29 Thread Jason Grout
On 3/29/11 6:58 AM, Jeroen Demeyer wrote: On 2011-03-29 13:15, Jason Grout wrote: On 3/28/11 4:36 AM, Jeroen Demeyer wrote: Also the correct(!) ticket number should appear on the first line of the commit message. Does the patch merging script not automatically do this? This is not the case.

Re: [sage-devel] Re: Patch submitting procedures

2011-03-29 Thread Jeroen Demeyer
On 2011-03-29 13:15, Jason Grout wrote: > On 3/28/11 4:36 AM, Jeroen Demeyer wrote: >> Also the correct(!) ticket >> number should appear on the first line of the commit message. > > Does the patch merging script not automatically do this? This is not the case. It would be possible to do this au

[sage-devel] Re: Patch submitting procedures

2011-03-29 Thread Jason Grout
On 3/28/11 4:36 AM, Jeroen Demeyer wrote: Also the correct(!) ticket number should appear on the first line of the commit message. Does the patch merging script not automatically do this? I thought at one time somebody added this. Again, the patch merging script already knows this, and if t

[sage-devel] Re: Patch submitting procedures

2011-03-29 Thread slabbe
> 1) When submitting a patch, make sure there is reasonable *commit > message* (use hg qrefresh -e to set the message). or hg qrefresh -m "#: Commit message" to do it from the command line. I think if one does hg qrefresh -e "#: Commit message" it erases the patch and replaces it by t

[sage-devel] Re: patch for TLS

2010-10-07 Thread Jason Grout
On 10/7/10 1:53 PM, jason-s...@creativetrax.com wrote: (cc to both twisted and sage-devel lists) Hi all, In the Sage project (http://sagemath.org), we apply a patch to the Twisted version we distribute. I'd like to clean out our custom patches and push them upstream, if possible. So I have a co

[sage-devel] Re: Patch review

2010-01-24 Thread Oscar Lazo
On 24 ene, 13:44, Oscar Gerardo Lazo Arjona wrote: > After considerable battling with Mercurial, I've made a patch to include > coordinate transformations Ehh.. it's available in http://trac.sagemath.org/sage_trac/ticket/7872 as 13535.patch thanks -- To post to this group, send an email to

[sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-24 Thread Mariah
William, > Yes it does.   The patch is here: > >    http://trac.sagemath.org/sage_trac/attachment/ticket/4644/trac_4644.p... > > I'm reading it, and it is applied.  Maybe the patch posted to ticket > 4644 is wrong? You are correct, the patch is applied ... but it is not working for me, but workin

[sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-24 Thread John H Palmieri
On Nov 24, 11:16 am, Mariah wrote: > John, Robert, George, > > Is your version of sage an upgrade from a previous version > of sage?   No, I looked at the 4.2.1 and 4.3.alpha0 source, in particular the file SAGE_ROOT/spkg/standard/sage_scripts-4.3.alpha0.spkg: apply "tar jxf" to this and look at

Re: [sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-24 Thread William Stein
On Tue, Nov 24, 2009 at 11:16 AM, Mariah wrote: > John, Robert, George, > > Is your version of sage an upgrade from a previous version > of sage?  Rather than do that, I am building sage from source, > specifically the sage-4.2.1.tar source.  And sage from > source does NOT have the patch.  Specif

[sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-24 Thread Mariah
John, Robert, George, Is your version of sage an upgrade from a previous version of sage? Rather than do that, I am building sage from source, specifically the sage-4.2.1.tar source. And sage from source does NOT have the patch. Specifically, sage-sage from source has lines 369-416: if [ $1 =

[sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-23 Thread Georg S. Weber
For what it's worth, this is from Sage-4.3.alpha0 (when I do ./sage -sh): Starting subshell with Sage environment variables set. Be sure to exit when you are done and do not do anything with other copies of Sage! Bypassing shell configuration files ... /Users/Shared/sage/build/sage-4.3.alpha0 s

Re: [sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-23 Thread Robert Bradshaw
On Nov 23, 2009, at 12:05 PM, John H Palmieri wrote: > On Nov 23, 11:56 am, Mariah wrote: >> Minh, >> >> The patch may have been merged into sage-4.1.2. >> But it is NOT in sage-4.2.1. >> >> Just do (in sage-4.2.1) "./sage -sh". >> I expect to see (at the end) >> >> * >> /home/mariah/sage/sag

[sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-23 Thread John H Palmieri
On Nov 23, 11:56 am, Mariah wrote: > Minh, > > The patch may have been merged into sage-4.1.2. > But it is NOT in sage-4.2.1. > > Just do (in sage-4.2.1) "./sage -sh". > I expect to see (at the end) > > * > /home/mariah/sage/sage-4.2.1-x86_64-Linux-core2-fc > sage subshell$ > * This is wh

[sage-devel] Re: patch in trac # 4644 not in sage-4.2.1 ???

2009-11-23 Thread Mariah
Minh, The patch may have been merged into sage-4.1.2. But it is NOT in sage-4.2.1. Just do (in sage-4.2.1) "./sage -sh". I expect to see (at the end) * /home/mariah/sage/sage-4.2.1-x86_64-Linux-core2-fc sage subshell$ * Yet what I see is just * Bypassing shell configuration files .

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-21 Thread Alexander Dreyer
Hello, > Can you post a link to the spkg. I've installed Sun Studio 12 update 1 > on my machine at home, which installs the Sun compilers in a different > directory to on 't2'. For some reason Sun changed the default from > /opt/SWUNspro which they have used for years, to /opt/sunstudio12.1 her

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-21 Thread Dr. David Kirkby
Alexander Dreyer wrote: > Hello, >> In order to obey this, the following lines should be added to >> patch/custom.py: > ok, that seems to fix it indeed. I've attached to corresponding > custom.py to the trac ticket. > > Regards, > Alexander Can you post a link to the spkg. I've installed Sun S

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-21 Thread Alexander Dreyer
Hello, > In order to obey this, the following lines should be added to > patch/custom.py: ok, that seems to fix it indeed. I've attached to corresponding custom.py to the trac ticket. Regards, Alexander -- Dr. rer. nat. Dipl.-Math. Alexander Dreyer Abteilung "Systemanalyse, Prognose und Regel

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-19 Thread Alexander Dreyer
Hello Dave, hello Martin, unfortunately, I didn't find the time to have a look at that the issue, but > The Sage install makefile defines CXX to be g++ so no code should ignore that. In order to obey this, the following lines should be added to patch/custom.py: --- try: CC = os.environ['CC'

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-18 Thread David Kirkby
2009/8/18 Minh Nguyen : > > Hi Alexander, > > On Tue, Aug 18, 2009 at 10:42 PM, Alexander > Dreyer wrote: >> >> Hello Martin, hello Dave, >> >>> Alright, thanks for checking this. I've CCed Alexander so he can tell me >>> what >>> he did back then and I can do it too >> as far as I can see it fro

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-18 Thread Minh Nguyen
Hi Alexander, On Tue, Aug 18, 2009 at 10:42 PM, Alexander Dreyer wrote: > > Hello Martin, hello Dave, > >> Alright, thanks for checking this. I've CCed Alexander so he can tell me what >> he did back then and I can do it too > as far as I can see it from the package, the patch is included. So > m

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-18 Thread Alexander Dreyer
Hello Martin, hello Dave, > Alright, thanks for checking this. I've CCed Alexander so he can tell me what > he did back then and I can do it too as far as I can see it from the package, the patch is included. So maybe, my fix fails for some reason. Is there somewhere on t2 an experimental Solaris

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-16 Thread Martin Albrecht
> I've marked > > http://trac.sagemath.org/sage_trac/ticket/6177 > > that as '[with patch; needs work]' as it breaks on Solaris. There were > previous issues on Solaris with PolyBoRi which were resolved. With the > updated .spkg, those issues return. Basically if the Sun C++ compiler > (CC) can be

[sage-devel] Re: patch reviews

2009-08-16 Thread Martin Albrecht
> Are > polybori-0-6-3.4.patch > polybori-0-6-3.5.patch > > included in that spkg file? The patches were added after the link to the > .spkg file was posted. These are revisions of the same patch. These are patches against the main Sage tree and thus not included in the SPKG. Cheers, Martin --

[sage-devel] Re: patch reviews (PolyBoRi patch)

2009-08-15 Thread Dr. David Kirkby
Martin Albrecht wrote: > http://trac.sagemath.org/sage_trac/ticket/6177 > > but is there a .spkg file to test it with? The ticket says: "The SPKG is here: http://sage.math.washington.edu/home/malb/spkgs/polybori-0.6.spkg"; >>> Yes, but that link was posted 3 months a

[sage-devel] Re: patch reviews

2009-08-15 Thread Dr. David Kirkby
Martin Albrecht wrote: > On Saturday 15 August 2009, William Stein wrote: >> On Sat, Aug 15, 2009 at 3:15 PM, Dr. David >> >> Kirkby wrote: >>> William Stein wrote: On Sat, Aug 15, 2009 at 2:58 PM, Dr. David Kirkby wrote: > William Stein wrote: >> Hi Sage-devel, >> >

[sage-devel] Re: patch reviews

2009-08-15 Thread Martin Albrecht
On Saturday 15 August 2009, William Stein wrote: > On Sat, Aug 15, 2009 at 3:15 PM, Dr. David > > Kirkby wrote: > > William Stein wrote: > >> On Sat, Aug 15, 2009 at 2:58 PM, Dr. David > >> > >> Kirkby wrote: > >>> William Stein wrote: > Hi Sage-devel, > > Sage-4.1.1 was just releas

[sage-devel] Re: patch reviews

2009-08-15 Thread William Stein
On Sat, Aug 15, 2009 at 3:15 PM, Dr. David Kirkby wrote: > > William Stein wrote: >> On Sat, Aug 15, 2009 at 2:58 PM, Dr. David >> Kirkby wrote: >>> William Stein wrote: Hi Sage-devel, Sage-4.1.1 was just released, so now is a perfect time to review a few patches.  Spend a few

[sage-devel] Re: patch reviews

2009-08-15 Thread Dr. David Kirkby
William Stein wrote: > On Sat, Aug 15, 2009 at 2:58 PM, Dr. David > Kirkby wrote: >> William Stein wrote: >>> Hi Sage-devel, >>> >>> Sage-4.1.1 was just released, so now is a perfect time to review a few >>> patches. Spend a few minutes soon, skim through >>> >>> http://trac.sagemath.org/sage

[sage-devel] Re: patch reviews

2009-08-15 Thread William Stein
On Sat, Aug 15, 2009 at 2:58 PM, Dr. David Kirkby wrote: > > William Stein wrote: >> Hi Sage-devel, >> >> Sage-4.1.1 was just released, so now is a perfect time to review a few >> patches.  Spend a few minutes soon, skim through >> >>     http://trac.sagemath.org/sage_trac/report/14 >> >> and revi

[sage-devel] Re: patch reviews

2009-08-15 Thread Dr. David Kirkby
William Stein wrote: > Hi Sage-devel, > > Sage-4.1.1 was just released, so now is a perfect time to review a few > patches. Spend a few minutes soon, skim through > > http://trac.sagemath.org/sage_trac/report/14 > > and review 1 ticket. > > -- William > > > I'd take a look at http://

[sage-devel] Re: patch reviews

2009-08-15 Thread William Stein
On Sat, Aug 15, 2009 at 2:23 PM, David Joyner wrote: > > On Sat, Aug 15, 2009 at 4:58 PM, William Stein wrote: >> >> Hi Sage-devel, >> >> Sage-4.1.1 was just released, so now is a perfect time to review a few >> patches.  Spend a few minutes soon, skim through >> >>    http://trac.sagemath.org/sag

[sage-devel] Re: patch reviews

2009-08-15 Thread David Joyner
On Sat, Aug 15, 2009 at 4:58 PM, William Stein wrote: > > Hi Sage-devel, > > Sage-4.1.1 was just released, so now is a perfect time to review a few > patches.  Spend a few minutes soon, skim through > >    http://trac.sagemath.org/sage_trac/report/14 > > and review 1 ticket. I gave http://trac.s

[sage-devel] Re: [patch] fixes "I" conversion to sympy

2009-07-13 Thread Ondrej Certik
On Mon, Jul 13, 2009 at 9:09 PM, Minh Nguyen wrote: > > Hi Ondrej, > > On Tue, Jul 14, 2009 at 10:09 AM, Ondrej Certik wrote: >> >> Hi, >> >> I forgot my trac login, could someone please forward this to the trac? >> Thanks. > > > > Done. See ticket #6424 > > http://trac.sagemath.org/sage_trac/ti

[sage-devel] Re: [patch] fixes "I" conversion to sympy

2009-07-13 Thread Minh Nguyen
Hi Ondrej, On Tue, Jul 14, 2009 at 10:09 AM, Ondrej Certik wrote: > > Hi, > > I forgot my trac login, could someone please forward this to the trac? Thanks. Done. See ticket #6424 http://trac.sagemath.org/sage_trac/ticket/6424 -- Regards Minh Van Nguyen --~--~-~--~~

[sage-devel] Re: patch naming scheme on trac

2009-06-26 Thread peterjeremy
On 2009-Jun-24 13:56:59 -0700, Robert Miller wrote: > >> Another point to make is a video I saw recently by the SVN guys, who >> claimed that the amount of discussion which centers around a decision >> is inversely proportional to how important it is. They related a story >> where the project near

[sage-devel] Re: patch naming scheme on trac

2009-06-26 Thread Craig Citro
> Btw: would it be easy to extract from the current automated release > tools a python function that given a ticket number would return the > url's of the corresponding patches on trac? > See the first two functions in $SAGE_ROOT/local/bin/sage-apply-ticket. -cc --~--~-~--~~

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread Nicolas M. Thiery
On Wed, Jun 24, 2009 at 01:46:29PM -0700, Robert Miller wrote: > > On Jun 24, 10:34 pm, Robert Miller wrote: > > > I really like having the ticket number first, it makes it easy to see   > > > (given an ordered list of patches) what patches belong as part of a   > > > single ticket. E.g. > > > >

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread Robert Miller
> On Thu, Jun 25, 2009 at 02:19:38AM -0700, Jason Grout wrote: > > When Mike was experimenting with trac 0.11, he made a plugin or > > something that put a "raw" link next to the attachment link, so an > > attachment would look like: > > > trac_3948_description.patch (raw) Apply on top of previous

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread Pat LeSmithe
Jason Grout wrote: > When Mike was experimenting with trac 0.11, he made a plugin or > something that put a "raw" link next to the attachment link, so an > attachment would look like: > > trac_3948_description.patch (raw) Apply on top of previous patches > > where clicking on trac_... would br

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread Nicolas M. Thiery
On Thu, Jun 25, 2009 at 02:19:38AM -0700, Jason Grout wrote: > >> At the bottom of the html view, there's a link entitled "original > >> format" which gives the raw patch. It's the same as the html-view > >> url, but with "attachment" replaced with "raw-attachment." > >> > > > > And it is a major

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread Dan Drake
On Thu, 25 Jun 2009 at 09:37AM +0100, John Cremona wrote: > I did not know that, which will be useful. What is the canonical > recipe for getting the patch's URL? When I try I sometimes find I > have downloaded some html thing by mistake. I didn't know that qimport did that either, so I made thi

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread Jason Grout
William Stein wrote: > On Thu, Jun 25, 2009 at 10:48 AM, Robert > Bradshaw wrote: >> On Jun 25, 2009, at 1:37 AM, John Cremona wrote: >> >>> 2009/6/25 Jason Grout : Robert Miller wrote: I think the following is a counterexample to "The trac_ prefix does not bring an

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread William Stein
On Thu, Jun 25, 2009 at 10:48 AM, Robert Bradshaw wrote: > > On Jun 25, 2009, at 1:37 AM, John Cremona wrote: > >> 2009/6/25 Jason Grout : >>> >>> Robert Miller wrote: >>> I think the following is a counterexample to "The trac_ prefix >>> does >>> not bring any useful information." >>>

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread Robert Bradshaw
On Jun 25, 2009, at 1:37 AM, John Cremona wrote: > 2009/6/25 Jason Grout : >> >> Robert Miller wrote: >> I think the following is a counterexample to "The trac_ prefix >> does >> not bring any useful information." > I still think it's not really, and it is just making the name

[sage-devel] Re: patch naming scheme on trac

2009-06-25 Thread John Cremona
2009/6/25 Jason Grout : > > Robert Miller wrote: > I think the following is a counterexample to "The trac_ prefix does > not bring any useful information." I still think it's not really, and it is just making the name longer, but I don't really care either. >>> I don't see the us

[sage-devel] Re: patch naming scheme on trac

2009-06-24 Thread Jason Grout
Robert Miller wrote: I think the following is a counterexample to "The trac_ prefix does not bring any useful information." >>> I still think it's not really, and it is just making the name longer, >>> but I don't really care either. >> I don't see the use for it either, but it's not a h

[sage-devel] Re: patch naming scheme on trac

2009-06-24 Thread Jaap Spies
Robert Miller wrote: I think the following is a counterexample to "The trac_ prefix does not bring any useful information." >>> I still think it's not really, and it is just making the name longer, >>> but I don't really care either. >> I don't see the use for it either, but it's not a h

[sage-devel] Re: patch naming scheme on trac

2009-06-24 Thread Robert Miller
> Another point to make is a video I saw recently by the SVN guys, who > claimed that the amount of discussion which centers around a decision > is inversely proportional to how important it is. They related a story > where the project nearly forked and many feelings were hurt over > something ten

[sage-devel] Re: patch naming scheme on trac

2009-06-24 Thread Robert Miller
On Jun 24, 10:34 pm, Robert Miller wrote: > > I really like having the ticket number first, it makes it easy to see   > > (given an ordered list of patches) what patches belong as part of a   > > single ticket. E.g. > > > 6201-heegner.patch > > 6201-referee-fixes.patch > > ... > > +1 Something o

  1   2   >