On 3/29/11 6:58 AM, Jeroen Demeyer wrote:
On 2011-03-29 13:15, Jason Grout wrote:
On 3/28/11 4:36 AM, Jeroen Demeyer wrote:
Also the correct(!) ticket
number should appear on the first line of the commit message.
Does the patch merging script not automatically do this?
This is not the case. It would be possible to do this automatically.
But then it's not clear how to handle the case where the commit message
already contains the ticket number. Even more difficult is the case
when the author adds a *wrong* ticket number to the commit message.
Currently, I can easily check this. Because of this, I choose not to
automatically add a ticket number to a commit message.
If the script automatically prepended:
Trac #xxxx:
to the start of every commit message, then:
1. the ticket number text would be uniform
2. if a wrong ticket number was indicated, it would be obvious which was
the correct ticket number, as it's always first in the standard format
3. people would eventually get in the habit of not adding the ticket
number, and we wouldn't have to deal with inconsistent formatting of the
number, wrong ticket numbers, forgetting to add ticket numbers, etc.
Thanks,
Jason
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
