Robert Bradshaw writes:
> On Tue, Nov 27, 2012 at 10:51 AM, Jason Grout
> wrote:
>> On 11/24/12 7:41 PM, Robert Bradshaw wrote:
>>
>>> Cool. (The doable part, not the unholy mess part :-). If that's the
>>> case, how about we simply ignore the issue at the moment, remove it
>>> all in the git con
On Tue, Nov 27, 2012 at 10:51 AM, Jason Grout
wrote:
> On 11/24/12 7:41 PM, Robert Bradshaw wrote:
>
>> Cool. (The doable part, not the unholy mess part :-). If that's the
>> case, how about we simply ignore the issue at the moment, remove it
>> all in the git conversion, and document + enforce a
On 11/24/12 7:41 PM, Robert Bradshaw wrote:
Cool. (The doable part, not the unholy mess part :-). If that's the
case, how about we simply ignore the issue at the moment, remove it
all in the git conversion, and document + enforce a no-whitespace
policy as as part of the new development workflow.
On 11/24/12 8:11 AM, Ivan Andrus wrote:
I have no idea how much work it would be though, and there's always the
slight chance you might break something that way.
Here's an example of code that changes behavior when there is trailing
whitespace:
print 1 + \
2
If there is a space after the \,
Volker Braun writes:
> On Sunday, November 25, 2012 7:30:21 PM UTC, Keshav Kini wrote:
>
> Yup. (The latter would of course be better.) But it would be on
> everyone's local sage install, not on trac or in the release
> management
> scripts :)
>
>
> Well it better be a hook in th
On Sunday, November 25, 2012 7:30:21 PM UTC, Keshav Kini wrote:
> Yup. (The latter would of course be better.) But it would be on
> everyone's local sage install, not on trac or in the release management
> scripts :)
Well it better be a hook in the local repo, its very annoying to commit and
Ivan Andrus writes:
> On Nov 25, 2012, at 1:01 AM, Keshav Kini wrote:
>
>> Travis Scrimshaw writes:
>>> Hey,
>>> I'd be happy with A), but perhaps we could have an option D) where
>>> when we upload (or merge) patches into sage, we automatically strip
>>> all whitespace in the patch file?
>>
On Sat, Nov 24, 2012 at 6:11 AM, Ivan Andrus wrote:
> I disagree. Perhaps I am alone in this, but I often (used to) move to the
> end of the line, go back a few characters (to get inside parenthesis or
> something), and start typing. If there is trailing whitespace that I didn't
> know about I w
On Nov 25, 2012, at 1:01 AM, Keshav Kini wrote:
> Travis Scrimshaw writes:
>> Hey,
>> I'd be happy with A), but perhaps we could have an option D) where
>> when we upload (or merge) patches into sage, we automatically strip
>> all whitespace in the patch file?
>
> This will get nasty once we
+1 for doing it during the git conversion
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To post to this group, send email to sage-devel@googlegroups.com.
To unsubscribe from this group, send email to
sage-devel+unsubscr...@googlegroups.com.
Vis
On Sat, Nov 24, 2012 at 4:13 PM, Keshav Kini wrote:
> Ivan Andrus writes:
>> I disagree. Perhaps I am alone in this, but I often (used to) move
>> to the end of the line, go back a few characters (to get inside
>> parenthesis or something), and start typing. If there is trailing
>> whitespace t
Robert Bradshaw writes:
> On Fri, Nov 23, 2012 at 12:23 PM, Volker Braun wrote:
>> b) misguides people writing patches into making unnecessary whitespace
>> changes ("trailing whitespace is bad, hence I'll take it out everywhere")
>>
>> Its confusing and slows us down with no real benefit.
>
> Th
Ivan Andrus writes:
> I disagree. Perhaps I am alone in this, but I often (used to) move
> to the end of the line, go back a few characters (to get inside
> parenthesis or something), and start typing. If there is trailing
> whitespace that I didn't know about I would be extremely annoyed
> beca
Travis Scrimshaw writes:
> Hey,
>I'd be happy with A), but perhaps we could have an option D) where
> when we upload (or merge) patches into sage, we automatically strip
> all whitespace in the patch file?
This will get nasty once we stop using patch files and switch to git.
Commits should no
Hey,
I'd be happy with A), but perhaps we could have an option D) where when
we upload (or merge) patches into sage, we automatically strip all
whitespace in the patch file?
Best.
Travis
On Saturday, November 24, 2012 9:57:34 AM UTC-8, Volker Braun wrote:
>
> On Saturday, November 24, 2012
On Saturday, November 24, 2012 4:41:07 PM UTC, P Purkayastha wrote:
> Actually, what I meant to say is that the current policy encourages one
> to not put trailing white space in edited lines. The suggestion is to
> make this official.
Thats precisely why I wrote the post in the first place.
On 11/25/2012 12:27 AM, P Purkayastha wrote:
On 11/25/2012 12:02 AM, Volker Braun wrote:
On Saturday, November 24, 2012 2:11:44 PM UTC, P Purkayastha wrote:
But, we do
want our code to look "good" and be less frustrating to hack around,
don't we?
But thats precisely my point, trai
On 11/25/2012 12:02 AM, Volker Braun wrote:
On Saturday, November 24, 2012 2:11:44 PM UTC, P Purkayastha wrote:
But, we do
want our code to look "good" and be less frustrating to hack around,
don't we?
But thats precisely my point, trailing whitespace is by definition not
visible s
On Saturday, November 24, 2012 2:11:44 PM UTC, P Purkayastha wrote:
> But, we do
> want our code to look "good" and be less frustrating to hack around,
> don't we?
>
But thats precisely my point, trailing whitespace is by definition not
visible so it doesn't change whether your code "looks" g
On Saturday, November 24, 2012 2:11:54 PM UTC, Ivan Andrus wrote:
> I disagree. Perhaps I am alone in this, but I often (used to) move to the
> end of the line, go back a few characters (to get inside parenthesis or
> something), and start typing.
>
http://www.emacswiki.org/emacs/NavigatingP
I disagree. Perhaps I am alone in this, but I often (used to) move to the end
of the line, go back a few characters (to get inside parenthesis or something),
and start typing. If there is trailing whitespace that I didn't know about I
would be extremely annoyed because all my typing was in the
On 11/24/2012 09:47 PM, Volker Braun wrote:
Really, 110 trailing whitespace characters? And you encounter that
often? A quick grep shows that lots of trailing whitespace is
exceedingly rare and only happens in a handful of docstrings with matrices.
Well, I was trying to patch something in the m
On Saturday, November 24, 2012 12:39:28 PM UTC, P Purkayastha wrote:
> It has happened often that I start editing some lines in sage and I
> suddenly find myself having to delete a lot of trailing whitespace
> characters on the line I am appending to or editing something. I see the
> line endin
On 11/24/2012 08:05 PM, Volker Braun wrote:
You talk about trailing whitespace as if getting rid of it were a worthy
goal in itself. It is not. Humans don't care about trailing whitespace,
we don't see it unless you misconfigure your editor. Its purely for the
Maybe you don't care, but I surely
You talk about trailing whitespace as if getting rid of it were a worthy
goal in itself. It is not. Humans don't care about trailing whitespace, we
don't see it unless you misconfigure your editor. Its purely for the
benefit of automated merge tools. If we disallow patch hunks that change
trail
On 11/24/2012 07:48 PM, Volker Braun wrote:
On Saturday, November 24, 2012 7:41:20 AM UTC, Robert Bradshaw wrote:
Anyone want to go first in formulating a policy?
The two obvious possibilities that are easily verifyable for a computer are:
A) No trailing whitespace is allowed anywhere. St
26 matches
Mail list logo
